From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FE3143D85; Sat, 30 Mar 2024 17:45:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32B874064C; Sat, 30 Mar 2024 17:44:55 +0100 (CET) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by mails.dpdk.org (Postfix) with ESMTP id 733F8402E6 for ; Sat, 30 Mar 2024 17:44:48 +0100 (CET) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-22a96054726so2131087fac.0 for ; Sat, 30 Mar 2024 09:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711817088; x=1712421888; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=hTHjfF1/4y9WyzASfq9tItYQaD7b4WuSIGpELLPt4yEjJYgMELc08/8OBtgesHtWnd vkmPQj920dc4Z8CtEw0XbOurHxieNA/xxl/2xlwe3woUO/eW6mccRhSnYk9fed82Vmj1 bjUeNrmwBlYKGXX53nXnQZ+Z2tRqw8n6ML1NzHQDEFy2dSKFwvyT9d5UgRe/NkmT937M ApGSj701t47AoV56Z9lOO8J/+WYq9OJ6E4dGznnRp3lC5fxWP392RKsehGr1QW2l0gq9 XIFirDdKZSzoeM2Lr5XazD4I2V+qIIYd4yx7HAetA5bfLa5up1YNXkrL7jA7rPPk/SBw XVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711817088; x=1712421888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=eihyw3a5YogeUwKt/gmLbGCZy9fWKM5y+IdTWv7zj6CZrx6WC38kBAbSV9Kmb6TCL+ 0P5eungtIHOVWqiGAJVYioHePuMYDzpuo8bz5e8glOoPVi9T58zbMutU8FFFuFzq9TXr gS8M4FMn5+V6O58UhvtFIUFtJ1uq4FO+28hYciKQUaEMc5tV3arscoF3NKM6tHIFh4mW 4DfPqZ3nz/Md/7fqxPOFw3z6MJI1+S2+GAYEBdQ/e/5McjxxqSQf97CaUFc6/Oi8cPIW QwhUKWTOuWFlaXb9bIcq0ZADgQFNK+VGTCspvXumklcPIOX2re3JA7FQaYpX8jLGRkKh aCZg== X-Gm-Message-State: AOJu0YxVHhpziTqpAcJGb3tm6Fck5nCqgBo2GWqQezJXYIrAqmJ/tHw7 DtNJL5RT6mfwBjRbP7qb3hDg69Nl66plmBxT+FuO24mGeXkBqVkBTu5NdiRzNXFhqo7dIWxzHpL a X-Google-Smtp-Source: AGHT+IGqNB6HrtX9Odz9AWaACRLISOeJnzaH9ByVtzytuHmEpNG+7DseTolbI/RXu3jRRaOpcUESxg== X-Received: by 2002:a05:6871:8783:b0:229:fd96:1e40 with SMTP id td3-20020a056871878300b00229fd961e40mr5587638oab.44.1711817087764; Sat, 30 Mar 2024 09:44:47 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id by1-20020a056a02058100b005dc26144d96sm4192417pgb.75.2024.03.30.09.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 09:44:47 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , Bruce Richardson Subject: [PATCH v20 05/14] eal: do not duplicate rte_init_alert() messages Date: Sat, 30 Mar 2024 09:42:16 -0700 Message-ID: <20240330164433.50144-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240330164433.50144-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240330164433.50144-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0