From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8AF643DAF; Tue, 2 Apr 2024 04:53:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5628F4028C; Tue, 2 Apr 2024 04:53:53 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id C0EBA4026F for ; Tue, 2 Apr 2024 04:53:51 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2a07b092c4fso3534729a91.0 for ; Mon, 01 Apr 2024 19:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712026431; x=1712631231; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5fmbaUPctccUtIb170IKAjy1iZPdfj0vzKS7/5/azLY=; b=Y/2lfTWTaJEeaoPykptlNuXZZf+g7MP7gSEObp4ADqK4idXvCbnIe13UC9whzXy7nF dwMNLf+dPETIrYbwQ9qdMzaP780j5IFrutJYOISxsl+fNu7s69wcM78Z0dZ94FDVoQwi uRNoYj0zMDzxP6nGkcAi4hQWWP2ASKmFCqDIzi5oU/mCzCQJO8mMrfRFZuUkbu0KRM9g yFkkVkU7ryVnFiEtzoI9WmranZ4044XM1y53qsl/3sgazIxnl2FGCPlInvh3ZAFii9oq 6ZBytK1/IWCY0PlVTboHZeYik9TYxLcCidOzhqPy3mvYSftVO/SDOBY5yCox0R9DR/oO jKyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712026431; x=1712631231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5fmbaUPctccUtIb170IKAjy1iZPdfj0vzKS7/5/azLY=; b=H6RJYDTpclep1nrHdRvSqZqM7ZeHU5l23xNQDWju/MEpUn7ZijUTX6Pb9XP1zlZgEW bcwDWNkJV58YsrPdynbjy4AYwEOxBPs/3FLm4nSkKauH+SMgYT4OEPVD8JWUsrnDkkAA j2U9DMO8/jfN2vruWGgY2VNtXFFPQN3r5he6c4exLlHHC6DEodoU9rQ36Tbun20nUw/8 0hj1A8U7mZbLvRuVJMqDipzSNaEjMkN1B7Y7fBA7HcykDbb8sqMqbYIfZDC0djzrBI53 0bqnGr8VgsjD/HanGFztuplu6pKYKjT0E7D/L8af6kxmuypwRqWp7gTNi7050mq/CnVv 82Dg== X-Forwarded-Encrypted: i=1; AJvYcCXwZ+07Gj6aTcdoOGhAnHEcQVS0pEfIL+DXeqIGeHTdkwSJ+ys0c8OmN4H0MatZlOLiycyRjkxAwSDwunA= X-Gm-Message-State: AOJu0YwNiUT+OIi9oGBttPLTUJGSMQSCfr72IVEgO1QCwRMpGeOfEcCS PLOiQljXm1aUq6w5hVecyiSfqcyFlcCoiKv0ciEszk0lpXR1eYDcROhlUdTusGQ= X-Google-Smtp-Source: AGHT+IFQZAavQaxsRjCHOw7AeBCbcthfLWA/x2Tm8tr8Cp0VAVtDlCEd827dYm+hg/WdHQ/LFdQCiw== X-Received: by 2002:a17:90a:a597:b0:29b:f6c1:cf01 with SMTP id b23-20020a17090aa59700b0029bf6c1cf01mr9185371pjq.40.1712026430863; Mon, 01 Apr 2024 19:53:50 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id z11-20020a17090ad78b00b002a232e4f9ddsm3752241pju.34.2024.04.01.19.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 19:53:50 -0700 (PDT) Date: Mon, 1 Apr 2024 19:53:48 -0700 From: Stephen Hemminger To: Honnappa Nagarahalli Cc: Aditya Ambadipudi , "dev@dpdk.org" , "jackmin@nvidia.com" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "roretzla@linux.microsoft.com" , "konstantin.v.ananyev@yandex.ru" , "konstantin.ananyev@huawei.com" , "mb@smartsharesystems.com" , "hofors@lysator.liu.se" , Dhruv Tripathi , Wathsala Wathawana Vithanage , nd Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library Message-ID: <20240401195348.00ad9f65@hermes.local> In-Reply-To: <4D4742AD-D867-4E5E-8D86-A9D588E62C48@arm.com> References: <20230821060420.3509667-1-honnappa.nagarahalli@arm.com> <20240401013729.1466298-1-aditya.ambadipudi@arm.com> <20240401070503.737db4f5@hermes.local> <20240401174758.3a03f6b9@hermes.local> <20240401190032.7e609283@hermes.local> <4D4742AD-D867-4E5E-8D86-A9D588E62C48@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Apr 2024 02:14:06 +0000 Honnappa Nagarahalli wrote: > > On Apr 1, 2024, at 9:00=E2=80=AFPM, Stephen Hemminger wrote: > >=20 > > On Tue, 2 Apr 2024 01:35:28 +0000 > > Honnappa Nagarahalli wrote: > > =20 > >>> On Apr 1, 2024, at 7:47=E2=80=AFPM, Stephen Hemminger wrote: > >>>=20 > >>> On Mon, 1 Apr 2024 22:28:52 +0000 > >>> Aditya Ambadipudi wrote: > >>> =20 > >>>> Thanks, Stephen, for the comment. > >>>>=20 > >>>> Unfortunately, we don't have the dev setup nor the resources to test= out this change using MSVC. > >>>>=20 > >>>> Thank you, > >>>> Aditya Ambadipudi =20 > >>>=20 > >>> All it requires is the community version of MSVC which is free. And s= etting up a Windows > >>> VM with KVM is free and easy. > >>>=20 > >>> IMHO all new libraries have to build on all environments, unless they= are enabling > >>> platform specific features. =20 > >> I see that UNH CI is running Windows VMs, the tests are passing there.= So, we do not need to anything. > >> =20 > >=20 > > That only tests the clang part. > > You need to modify lib/meson.build to get it tested with the windows co= mpiler. =20 > Any idea on when is this getting added to CI? You need to add this to next version of the patch. I tried it and MSVC has no problems with the new code. Another issue is the naming. Right now the choice of 'deque' generates lots= of checkpatch errors, and every bit of new code that uses the library will get= a warning as well. Can you think of a better name? diff --git a/lib/meson.build b/lib/meson.build index 8c8c1e98e2..127e4dc68c 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -75,6 +75,7 @@ if is_ms_compiler 'kvargs', 'telemetry', 'eal', + 'deque', 'ring', ] endif