From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56D2C43DB0; Tue, 2 Apr 2024 06:20:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D24154028C; Tue, 2 Apr 2024 06:20:15 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6DDD44026F for ; Tue, 2 Apr 2024 06:20:14 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 857F620E6F69; Mon, 1 Apr 2024 21:20:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 857F620E6F69 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712031613; bh=x3quqygxSDIoW7kKE50Ri28yWg8iG12o7i9vZUUgiBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mfoB4wDNmRNT68ywaefym2pTjm0gdgJ3A/tkwF0uVaQ/VVYxZaV9uiw4G4s5r092Y /leFFaz0ZCqFETE4LQza4KndG8tPgs5HaGwofdVX4/wbviYQFkZuwzO+eFrvMPaY3p NcwIt5YqwSmdtFqZdQrRsnMfc74dkEe+IesC02eI= Date: Mon, 1 Apr 2024 21:20:13 -0700 From: Tyler Retzlaff To: Aditya Ambadipudi Cc: Stephen Hemminger , Honnappa Nagarahalli , "dev@dpdk.org" , "jackmin@nvidia.com" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "konstantin.v.ananyev@yandex.ru" , "konstantin.ananyev@huawei.com" , "mb@smartsharesystems.com" , "hofors@lysator.liu.se" , Dhruv Tripathi , Wathsala Wathawana Vithanage , nd Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library Message-ID: <20240402042013.GC1488@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230821060420.3509667-1-honnappa.nagarahalli@arm.com> <20240401013729.1466298-1-aditya.ambadipudi@arm.com> <20240401070503.737db4f5@hermes.local> <20240401174758.3a03f6b9@hermes.local> <20240401190032.7e609283@hermes.local> <4D4742AD-D867-4E5E-8D86-A9D588E62C48@arm.com> <20240401195348.00ad9f65@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 02, 2024 at 03:03:13AM +0000, Aditya Ambadipudi wrote: > Hello Stephen, > > I have a copy of CLRS with me. And Deque is a very standard word in computer science. Even CLRS which is considered one of the most foundational books in computer science uses the word deque. i'm kind of inclined to agree with this. double ended queue is pretty well known as ``deque`` perhaps most notably from stl. https://en.cppreference.com/w/cpp/container/deque i would however strongly advise that there be no use of ``deque`` bare (without the rte_ prefix) in any public header. (i.e. inline function variables , parameter names, etc...). that would almost certainly result in frustration for C++ consumers of dpdk that may be doing the following: #include #include using namespace std; a quick pass of the patches and i don't see any instances without the rte_ prefix so only cautioning that we would want to avoid it. > > I don't think there is any better word to describe the datastructure we are building other than "deque". > > Is there a way to add an exception for that word in the dictionary words check we run? I genuinely think the readability of this library that we are building will suffer if we don't use the word "deque" here. > > Thank you, > Aditya Ambadipudi > > [image/jpeg][image/jpeg] > > ________________________________ > From: Stephen Hemminger > Sent: Monday, April 1, 2024 9:53 PM > To: Honnappa Nagarahalli > Cc: Aditya Ambadipudi ; dev@dpdk.org ; jackmin@nvidia.com ; matan@nvidia.com ; viacheslavo@nvidia.com ; roretzla@linux.microsoft.com ; konstantin.v.ananyev@yandex.ru ; konstantin.ananyev@huawei.com ; mb@smartsharesystems.com ; hofors@lysator.liu.se ; Dhruv Tripathi ; Wathsala Wathawana Vithanage ; nd > Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library > > On Tue, 2 Apr 2024 02:14:06 +0000 > Honnappa Nagarahalli wrote: > > > > On Apr 1, 2024, at 9:00 PM, Stephen Hemminger wrote: > > > > > > On Tue, 2 Apr 2024 01:35:28 +0000 > > > Honnappa Nagarahalli wrote: > > > > > >>> On Apr 1, 2024, at 7:47 PM, Stephen Hemminger wrote: > > >>> > > >>> On Mon, 1 Apr 2024 22:28:52 +0000 > > >>> Aditya Ambadipudi wrote: > > >>> > > >>>> Thanks, Stephen, for the comment. > > >>>> > > >>>> Unfortunately, we don't have the dev setup nor the resources to test out this change using MSVC. > > >>>> > > >>>> Thank you, > > >>>> Aditya Ambadipudi > > >>> > > >>> All it requires is the community version of MSVC which is free. And setting up a Windows > > >>> VM with KVM is free and easy. > > >>> > > >>> IMHO all new libraries have to build on all environments, unless they are enabling > > >>> platform specific features. > > >> I see that UNH CI is running Windows VMs, the tests are passing there. So, we do not need to anything. > > >> > > > > > > That only tests the clang part. > > > You need to modify lib/meson.build to get it tested with the windows compiler. > > Any idea on when is this getting added to CI? > > You need to add this to next version of the patch. > I tried it and MSVC has no problems with the new code. > > Another issue is the naming. Right now the choice of 'deque' generates lots of > checkpatch errors, and every bit of new code that uses the library will get a warning > as well. Can you think of a better name? > > diff --git a/lib/meson.build b/lib/meson.build > index 8c8c1e98e2..127e4dc68c 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -75,6 +75,7 @@ if is_ms_compiler > 'kvargs', > 'telemetry', > 'eal', > + 'deque', > 'ring', > ] > endif