From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1368343DC3; Tue, 2 Apr 2024 17:25:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B27CB4028C; Tue, 2 Apr 2024 17:25:39 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 020444026F for ; Tue, 2 Apr 2024 17:25:37 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e704078860so4490222b3a.0 for ; Tue, 02 Apr 2024 08:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712071537; x=1712676337; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rhZZTLtcI+o73c5yaaSG0F2NEo5IpOhHA/+JSqdffX0=; b=egCWpxmr6svf8rZBLoo6TCL9PonPm6NPGECHOjBoI8BEuawEqeBHNQhMYd1mQD8Cr/ tLzgyKwgalRfA9lLURshcmfTGsUl78+jJ2NtjTNS1ycYb6YSs31Q4oyVGBLzX74VE9M3 eGxahRAg/Cf87NvWj9MJlXdjTiy912GKHNfFW+UvwJzBCT6eiRh3bcIOqFxJ0aFGViDm 251LRMoz0WA8/bU/d5VkViNwD/R6jKv4AT9KseYEhx7aNcajDwL2JVpk0tYwFGz6X1Tf 527h0uhvQRXA4uSczpcZEwrA9ubyZpmIUT7HyrPWrcmtwe0sGmz16Qpcthnu89VlIRDD p01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712071537; x=1712676337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rhZZTLtcI+o73c5yaaSG0F2NEo5IpOhHA/+JSqdffX0=; b=efPlvo7Zc1F0uFvpWWO4Mm2cXym1Nluvh1CeiQFljtKQSLuGvEnyTVSzW1atNwcyXi f4JKSP8suKYYX+FljN+lQ7SVosKGy93owEt/wAoRH4k/bqFuqml3aDZnzfuJR3lYdouW XYtN1U3iKHP9/RhZNLb3MI3X7RsbQEkM9UHRV/ViKPpoVV+mU8bwo0m92eNRLkjalUUx 5Man4VApsJUOLBpePMtAquXR64a3KAYr1DDUTtaFWtf6y9ZiZupoZT92B2pJzo5twRYE 0JAHPt5k/URuplK71SKW0x7ZCbxTUN/20wuRm2kLGMniEpvH5+6wPNWZM4mn1+zk0djX r3cg== X-Forwarded-Encrypted: i=1; AJvYcCXtSxtGzxpvkixXN3WbFqH5T/j6ggMieXePDuXA+pN20K4JNieY7FczdFhUjg8fFv8NnPqTboLjlzyd3Cs= X-Gm-Message-State: AOJu0YyMYUVfyGSzX1wZnBOxiNVaJOsEdW/Z+fX/3cJsOA4Yph8oPCa/ hZorrr5z2fF8MAefJuvgs9Q2VYQ42BWEXM4LNO9Cf2oUkIg6NiT5Xmg4DMekmCY= X-Google-Smtp-Source: AGHT+IGHVLsXTlJoVR5KZKI+5/2YnjiwUfi+cGLOCVW/31cHFq+6HQuuxQwgT5/eldVlQHem4Gx4Sw== X-Received: by 2002:a05:6a00:80e:b0:6e6:ac71:8b38 with SMTP id m14-20020a056a00080e00b006e6ac718b38mr44253pfk.22.1712071536939; Tue, 02 Apr 2024 08:25:36 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id q14-20020aa7982e000000b006e73508485bsm9886084pfl.100.2024.04.02.08.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 08:25:36 -0700 (PDT) Date: Tue, 2 Apr 2024 08:25:34 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Aditya Ambadipudi , "dev@dpdk.org" , "jackmin@nvidia.com" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "roretzla@linux.microsoft.com" , "konstantin.v.ananyev@yandex.ru" , "konstantin.ananyev@huawei.com" , "mb@smartsharesystems.com" , Honnappa Nagarahalli , Dhruv Tripathi , Wathsala Wathawana Vithanage , nd Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library Message-ID: <20240402082534.27640a73@hermes.local> In-Reply-To: References: <20230821060420.3509667-1-honnappa.nagarahalli@arm.com> <20240401013729.1466298-1-aditya.ambadipudi@arm.com> <20240401070503.737db4f5@hermes.local> <20240401174758.3a03f6b9@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Apr 2024 08:05:41 +0200 Mattias R=C3=B6nnblom wrote: > On 2024-04-02 02:47, Stephen Hemminger wrote: > > On Mon, 1 Apr 2024 22:28:52 +0000 > > Aditya Ambadipudi wrote: > > =20 > >> Thanks, Stephen, for the comment. > >> > >> Unfortunately, we don't have the dev setup nor the resources to test o= ut this change using MSVC. > >> > >> Thank you, > >> Aditya Ambadipudi =20 > >=20 > > All it requires is the community version of MSVC which is free. And set= ting up a Windows > > VM with KVM is free and easy. > >=20 > > IMHO all new libraries have to build on all environments, unless they a= re enabling > > platform specific features. =20 >=20 > Requiring all contributors to build and test on what is, in this=20 > context, a pretty obscure platform with a pretty obscure compiler seems=20 > like a bad idea to me. >=20 > It will raise the bar for contributions further. >=20 > In principle I agree though. Your contribution should not only build,=20 > but also run (and be tested) on all platforms. Otherwise, Windows isn't=20 > supported in the upstream, but rather we have a Windows port (which=20 > happens to live in the same source tree). >=20 > I never tested any contribution on a FreeBSD system, but at least those=20 > use the de-facto standard compilers and a standard API (POSIX), so the=20 > likelihood of things actually working is greater (but maybe not great=20 > enough). >=20 > Surely, this is something the tech board must have discussed when it=20 > agreed to supporting Windows *and* MSVC. Many if not most of the=20 > man-hours involved won't be spent by the Windows maintainer, but the=20 > individual future contributors. This what CI systems are for. FreeBSD and Windows are enabled in the build system; just need to make sure all new libraries are enabled. That said, I am all for keeping focus. So open to discussions on dropping lesser platforms or build environments if they interfere.