From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FFEF43DC3; Tue, 2 Apr 2024 19:15:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3F064025D; Tue, 2 Apr 2024 19:15:55 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id ABF674021F for ; Tue, 2 Apr 2024 19:15:53 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-29ddfada0d0so4045974a91.3 for ; Tue, 02 Apr 2024 10:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712078153; x=1712682953; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GZMMpSEgzeU2OGATaKfW4bBtniTCwjaEngVJDHsd1t0=; b=ShzFpoiDfQ8NAogiqpbsSpppEVMMDL3ay8vIcfECRh5XFJ9NHmtzvs3+C29bC9g7xl R55VYjGnGc5ou8MZbMiZYnAf1SNcOzv+7enP5W6YT0S2TZ5G5oHf3OoB2/hIXGr5vYuF r/zcD7RtAJyGljIKOLCnzP5IHHr8BvF8ililyrQzkJdaicIpntH6wN2O+B77hDGVQnA7 Q9QEfA+Rj8kLMXyoiqVOGsWNIiVJwiKDLTiXtj0uESVPpzoVycMItmyjpFrNWk1+ec7E 3ggxz/U+YZoPx/d3v0g5lLYBJ44RGdu7sn3cM/VEZRB2m9sidhEHin8YfZP4I2Kx7Rmh 7tjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712078153; x=1712682953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GZMMpSEgzeU2OGATaKfW4bBtniTCwjaEngVJDHsd1t0=; b=eap2gqHFXcVQbxhv3ZeXD4FXf4btZbsBq/qzUokjcKQj7EIaGAOAuYxKsH8SXYGsm4 CVJxX2QxCBsVKtpEljBMnaMgyplfedV1RtuT/CVj+O6S2roqV1U2146QDsElROl1dR4L zaocZiHU+yaeimSr7SgLw9RG0ZDtjJNd2OmQfXT5OUJrmolUaEP3helLnUPsz4qwh6fm 2xghOWrN2b7PGCuuYdjTQYLND1LvZWzPyXLJD+HDJn2oj19c2s4xTro+PoDobAC9jUY3 QZYgHY5AK9OL29vPDQdnMvxCpmGx8U1JoMkpqNpiWU9DDYV3Aqk8Ufd5JlzZ6urso8cw Rciw== X-Gm-Message-State: AOJu0YyXqLKJOgDrVXxFOkrRvaAX9MjI+3Y7YM8Q5j1zRnGiqCPkCU/4 FwGT2o0FicrtCDN1M/VFa40KDWp15Rg5wv9QFd93VrgcQs2djhw6qKRWg1Cp+G4= X-Google-Smtp-Source: AGHT+IEm89zgJnMXeSipG6U88dUaQUOU/tTQA0WLqa3BHNrXgUkIjNuNRMRy4hMQFZ0jDnVim3J9Eg== X-Received: by 2002:a17:90a:d797:b0:2a2:7343:3eee with SMTP id z23-20020a17090ad79700b002a273433eeemr1389989pju.8.1712078152809; Tue, 02 Apr 2024 10:15:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id dw5-20020a17090b094500b002a28c7eb7a6sm33423pjb.20.2024.04.02.10.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:15:52 -0700 (PDT) Date: Tue, 2 Apr 2024 10:15:50 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz Subject: Re: [PATCH] build: exclude rather than include libs in MSVC build Message-ID: <20240402101550.6e2966ad@hermes.local> In-Reply-To: <1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com> References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Apr 2024 09:55:48 -0700 Tyler Retzlaff wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retzlaff For mbuf, since it requires mempool, you might not need to explicitly exclude it. But the change looks good. Acked-by: Stephen Hemminger