From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C09C43DCA; Tue, 2 Apr 2024 22:45:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FE1040272; Tue, 2 Apr 2024 22:45:54 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 78ECB4025D for ; Tue, 2 Apr 2024 22:45:53 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6ea8ee55812so5616892b3a.0 for ; Tue, 02 Apr 2024 13:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712090752; x=1712695552; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TduWbQ1pJKQ1FyCjm7qzkqT1Zta6SsWdumKkweVNi7g=; b=bCdy0AYuMcLXpVtkknUwj8R8uEmXUq21q3LGb+Ma8YyXkUmCvbQHHn0iqnZrx/SaeD fN5kvFpge24FZQSf4htOORBKzEQgNPXe0OQFGnw5PKGw66TvA9Hx+OkXjYibJuLuuNU6 l0+RZA0KTd0T7DFoVFY5ngNZIx4nRUAro2eI8ALwgxkFwVDhpzswd1AgRweTNHL72FxG eYqj36UIdWawnQz/f3CB3+NEEPGiIYR7tdd7Rxxz0vDEG+o+9QBdlOeMOhBtd56s9T2Z lLH80oH9a7Y1R4GLmZR/nUSAkE5VjVpZ89U44+HyL2mSZZkRGDJBijKDnA9CfsG6p7Af sPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712090752; x=1712695552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TduWbQ1pJKQ1FyCjm7qzkqT1Zta6SsWdumKkweVNi7g=; b=J24U37bRRZGTaWkkVok9VMi6fSQ2qBJ5ni7Sze+hR7bRZmEjTW0DKP4eKsOKgWgvGH OTPQvdjb51iK2TGzFztXqRsTZQy+XfMSjgSHPlQ0DwWkOoJyMec9FeXwS1+dLknLmRo1 cDSRXob7IFNXZ5gBWrGu1rNIQgzHOwrsRmDqGfEm4blAJa+QEjnt6V8LXfAb4S7ScLbG FcCa5yu1aFuOClZErsw1J0S/iG8mrXu3Yc/X+cwcsju6WKLSl+cTifuQ9usyVNZSWJyV 7eqm47S3f4hFZ0LWH+yT3M4qfAMOPyB6B2vTQpDARRCqaz2Qno0Xx36s3WnWxvCTrsRR pOPA== X-Gm-Message-State: AOJu0YysSAoRneBGf9aWmQx/s8/y+ZL+v36NSl1kMk8tro2M8PPn8k6L q8ou5bzqSaUoLT5awycNawoYQ/UBnB30UCY7FIDvZoXoSDamigHU1SGL8q5ITD8= X-Google-Smtp-Source: AGHT+IGys9+2RYrx2e/a3qsek8Y76WojVBxB3uEfV8X3JeRU/Gh+zLO8K43SGfgFxHAct5uFrSTBng== X-Received: by 2002:a05:6a20:6a0c:b0:1a3:50fb:4f7c with SMTP id p12-20020a056a206a0c00b001a350fb4f7cmr16799425pzk.29.1712090752601; Tue, 02 Apr 2024 13:45:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id h5-20020a056a00230500b006ead792b6f2sm10225349pfh.1.2024.04.02.13.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 13:45:52 -0700 (PDT) Date: Tue, 2 Apr 2024 13:45:49 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com Subject: Re: [PATCH v9 2/4] mbuf: remove rte marker fields Message-ID: <20240402134549.0d3d22dc@hermes.local> In-Reply-To: <1712088530-24948-3-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1712088530-24948-1-git-send-email-roretzla@linux.microsoft.com> <1712088530-24948-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Apr 2024 13:08:48 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Provide new rearm_data and rx_descriptor_fields1 fields in anonymous > unions as single element arrays of with types matching the original > markers to maintain API compatibility. > > This change breaks the API for cacheline{0,1} fields that have been > removed from rte_mbuf but it does not break the ABI, to address the > false positives of the removed (but 0 size fields) provide the minimum > libabigail.abignore for type = rte_mbuf. > > Signed-off-by: Tyler Retzlaff Release note should be for 24.07 not 24.03.