DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 2/4] doc: replace ifconfig and brctl usage in howto
Date: Tue,  2 Apr 2024 09:29:34 -0700	[thread overview]
Message-ID: <20240402163050.133923-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20240402163050.133923-1-stephen@networkplumber.org>

The brctl command is deprecated and not supported on lastest
distros. Ifconfig command is legacy and no longer maintained;
replace it with ip commands in documentation.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/howto/lm_bond_virtio_sriov.rst | 58 +++++++++++------------
 doc/guides/howto/lm_virtio_vhost_user.rst |  2 +-
 2 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/doc/guides/howto/lm_bond_virtio_sriov.rst b/doc/guides/howto/lm_bond_virtio_sriov.rst
index 60b4462c2c..751b1de90b 100644
--- a/doc/guides/howto/lm_bond_virtio_sriov.rst
+++ b/doc/guides/howto/lm_bond_virtio_sriov.rst
@@ -445,21 +445,21 @@ Setup bridge on host_server_1
    # ens3f0 is the Niantic NIC
    # ens6f0 is the Fortville NIC
 
-   ifconfig ens3f0 down
-   ifconfig tap1 down
-   ifconfig ens6f0 down
-   ifconfig virbr0 down
-
-   brctl show virbr0
-   brctl addif virbr0 ens3f0
-   brctl addif virbr0 ens6f0
-   brctl addif virbr0 tap1
-   brctl show virbr0
-
-   ifconfig ens3f0 up
-   ifconfig tap1 up
-   ifconfig ens6f0 up
-   ifconfig virbr0 up
+   ip link set dev ens3f0 down
+   ip link set dev tap1 down
+   ip link set dev ens6f0 down
+   ip link set dev virbr0 down
+
+   bridge link show dev virbr0
+   ip link set dev ens3f0 master virbr0
+   ip link set dev ens6f0 master virbr0
+   ip link set dev tap1 master virbr0
+   bridge link show dev virbr0
+
+   ip link set dev ens3f0 up
+   ip link set dev tap1 up
+   ip link set dev ens6f0 up
+   ip link set dev virbr0 up
 
 connect_to_qemu_mon_on_host.sh
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -548,21 +548,21 @@ Setup bridge on host_server_2
    # ens4f0 is the Niantic NIC
    # ens5f0 is the Fortville NIC
 
-   ifconfig ens4f0 down
-   ifconfig tap1 down
-   ifconfig ens5f0 down
-   ifconfig virbr0 down
+   ip link set dev ens4f0 down
+   ip link set dev tap1 down
+   ip link set dev ens5f0 down
+   ip link set dev virbr0 down
 
-   brctl show virbr0
-   brctl addif virbr0 ens4f0
-   brctl addif virbr0 ens5f0
-   brctl addif virbr0 tap1
-   brctl show virbr0
+   bridge link show dev virbr0
+   ip link set dev ens4f0 master virbr0
+   ip link set dev ens5f0 master virbr0
+   ip link set dev tap1 master virbr0
+   bridge link show dev virbr0
 
-   ifconfig ens4f0 up
-   ifconfig tap1 up
-   ifconfig ens5f0 up
-   ifconfig virbr0 up
+   ip link set dev ens4f0 up
+   ip link set dev tap1 up
+   ip link set dev ens5f0 up
+   ip link set dev virbr0 up
 
 .. _lm_bond_virtio_sriov_vm_scripts:
 
@@ -585,7 +585,7 @@ Set up DPDK in the Virtual Machine
    /root/dpdk/usertools/dpdk-hugepages.py --setup 2G
    /root/dpdk/usertools/dpdk-hugepages.py --show
 
-   ifconfig -a
+   ip link show
    /root/dpdk/usertools/dpdk-devbind.py --status
 
    rmmod virtio-pci ixgbevf
diff --git a/doc/guides/howto/lm_virtio_vhost_user.rst b/doc/guides/howto/lm_virtio_vhost_user.rst
index c5c48f10a9..2f9a93e849 100644
--- a/doc/guides/howto/lm_virtio_vhost_user.rst
+++ b/doc/guides/howto/lm_virtio_vhost_user.rst
@@ -415,7 +415,7 @@ setup_dpdk_virtio_in_vm.sh
    /root/dpdk/usertools/dpdk-hugepages.py --setup 2G
    /root/dpdk/usertools/dpdk-hugepages.py --show
 
-   ifconfig -a
+   ip -br link show
    /root/dpdk/usertools/dpdk-devbind.py --status
 
    rmmod virtio-pci
-- 
2.43.0


  parent reply	other threads:[~2024-04-02 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 16:29 [PATCH 0/4] Replace references to ifconfig in doc Stephen Hemminger
2024-04-02 16:29 ` [PATCH 1/4] doc: remove references to ifconfig Stephen Hemminger
2024-04-02 16:29 ` Stephen Hemminger [this message]
2024-04-02 16:29 ` [PATCH 3/4] doc: replace ifconfig in testpmd doc Stephen Hemminger
2024-04-02 16:29 ` [PATCH 4/4] doc: replace use of ifconfig in nics Stephen Hemminger
2024-04-02 16:39 ` [PATCH 0/4] Replace references to ifconfig in doc Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402163050.133923-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).