From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B2E43DF0; Wed, 3 Apr 2024 23:51:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FDE940272; Wed, 3 Apr 2024 23:51:41 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 971FA40269 for ; Wed, 3 Apr 2024 23:51:39 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2a2c028b8a6so197179a91.1 for ; Wed, 03 Apr 2024 14:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712181099; x=1712785899; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lTOVNEL4J5CYycKustW9Tq4IksEQne3CLWP6VbWnutI=; b=KDwps7vGtCUI/SR5UEf7NR5TCkQt0ZjsamJlLLDYMWl0rIM2iyRjG+w4WG9eAY02eu UnfZqv2PjA6lXLEnWW47N4pbt18H/gBCZHl+uM0i/Y0e8hX1h6oilkMDxZA/FCfYTDnN l9hUc6nAGEhgTISIq12aVtqip4gv7zV7iNEursMlfSN4LtJxDxiWgVskkm6ntBMt6+kF 1xlcvaXQwY7sOfJW20XF+Hf+Inzywf5uMNir9rW/JzHQKQOsGJBti5vsptf5OEJraMZe iBIHOsvxGiWQwMhaBZuFH/zhcXt8ARim8A24BoLh7ACE14IL8PD10yQKKNVUc4QZTFL4 xunQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712181099; x=1712785899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lTOVNEL4J5CYycKustW9Tq4IksEQne3CLWP6VbWnutI=; b=hwNouB53iJDGws3Vw4BbbLZirmCetbHJ0iUzrmp4mxesMSJT0bDyEi4G7A9K4DN3A4 BLEfSj43v/L5fS5B5H8cnybR4UV8JXHLfLzdY+dtpmd0BtpHSc3mlBxlcQciEvY3gBeo 7mSvIOBwMfaY9P76U+3ZmiE/Q9OuQZ1t+B2TYaG0fKGddf1O51yvQvuazvzcffWIsxJr o4prDL14IlmrfsgHAHhaFPvAJNuvF3sMSPv/aIAvTU5LimF7ng4Szvl99Qdbyv+zMmuS f1P5sLPHVRX/l43AAf2b8C4oYjQ7omdbSRzL0z6r6NJKuZ6UAHlMSzDt4RZUCY3mc5Ye y4Kw== X-Gm-Message-State: AOJu0YyVzKCLmB5+frQzDhyOP6AzyCSzyTjf88afZGTrTv68UemqyM7a 3el3S4aZ9go2H+UD0YD7xwTy7wbtXuYw38jqZwwkVIxycbYhxd5KMAkp7REtNBY= X-Google-Smtp-Source: AGHT+IHRxVFEk+kowJXfUaC8Nuawu6iRsHOFrkAb8j5i6RIMdUr0IMveBOkQ2b7Z5QSkqGoD6rFLDg== X-Received: by 2002:a17:90b:4b50:b0:2a0:3c31:7d07 with SMTP id mi16-20020a17090b4b5000b002a03c317d07mr824534pjb.48.1712181098813; Wed, 03 Apr 2024 14:51:38 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id j5-20020a17090ae60500b002a03a597526sm179019pjy.25.2024.04.03.14.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 14:51:38 -0700 (PDT) Date: Wed, 3 Apr 2024 14:51:36 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz , Srikanth Yalavarthi , Vladimir Medvedkin Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build Message-ID: <20240403145136.449ef6e0@hermes.local> In-Reply-To: <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 3 Apr 2024 11:23:19 -0700 Tyler Retzlaff wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > With this change we now get immediate CI build coverage for the libs > meter, timer, pci, cfgfile > > v2: > * add a few more explicit exclusions for now as they are known to require > more than trivial work and avoid needing to disable them later as the > dependent libraries are enabled. If you need to do another revision, it might be good idea to add comment to the meson.build file when doing exclusions as to what is missing.