From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57E1943DEE; Wed, 3 Apr 2024 19:46:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6AA74025D; Wed, 3 Apr 2024 19:46:08 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id C906C4025C for ; Wed, 3 Apr 2024 19:46:07 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0222A20E8CBC; Wed, 3 Apr 2024 10:46:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0222A20E8CBC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712166367; bh=xD7g+mcgQi//ePHj06EOJnoR0NmBPd41oxy8J/1Di00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JU4vI/IZkV9azow4fmIjP3xgtGuiI1jn0pqi817PUenHPS3q/QbZD164B7f9Jgq0W BOTAULjJDe6NQW5nKTvA7ZgvxQ15ha9OjUWvOS/FNq2ceHi3Uzes3/aTKdBJ/omP1b uA8vqXQQ9Umaf0BqGGtvTUnfvztTX6THWdnUuV08= Date: Wed, 3 Apr 2024 10:46:06 -0700 From: Tyler Retzlaff To: Honnappa Nagarahalli Cc: Stephen Hemminger , Aditya Ambadipudi , "dev@dpdk.org" , "jackmin@nvidia.com" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "konstantin.v.ananyev@yandex.ru" , "konstantin.ananyev@huawei.com" , "mb@smartsharesystems.com" , "hofors@lysator.liu.se" , Dhruv Tripathi , Wathsala Wathawana Vithanage , nd Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library Message-ID: <20240403174606.GA7375@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230821060420.3509667-1-honnappa.nagarahalli@arm.com> <20240401013729.1466298-1-aditya.ambadipudi@arm.com> <20240401070503.737db4f5@hermes.local> <20240401174758.3a03f6b9@hermes.local> <20240401190032.7e609283@hermes.local> <4D4742AD-D867-4E5E-8D86-A9D588E62C48@arm.com> <20240401195348.00ad9f65@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 03, 2024 at 04:50:02PM +0000, Honnappa Nagarahalli wrote: > > > > On Apr 1, 2024, at 9:53 PM, Stephen Hemminger wrote: > > > > On Tue, 2 Apr 2024 02:14:06 +0000 > > Honnappa Nagarahalli wrote: > > > >>> On Apr 1, 2024, at 9:00 PM, Stephen Hemminger wrote: > >>> > >>> On Tue, 2 Apr 2024 01:35:28 +0000 > >>> Honnappa Nagarahalli wrote: > >>> > >>>>> On Apr 1, 2024, at 7:47 PM, Stephen Hemminger wrote: > >>>>> > >>>>> On Mon, 1 Apr 2024 22:28:52 +0000 > >>>>> Aditya Ambadipudi wrote: > >>>>> > >>>>>> Thanks, Stephen, for the comment. > >>>>>> > >>>>>> Unfortunately, we don't have the dev setup nor the resources to test out this change using MSVC. > >>>>>> > >>>>>> Thank you, > >>>>>> Aditya Ambadipudi > >>>>> > >>>>> All it requires is the community version of MSVC which is free. And setting up a Windows > >>>>> VM with KVM is free and easy. > >>>>> > >>>>> IMHO all new libraries have to build on all environments, unless they are enabling > >>>>> platform specific features. > >>>> I see that UNH CI is running Windows VMs, the tests are passing there. So, we do not need to anything. > >>>> > >>> > >>> That only tests the clang part. > >>> You need to modify lib/meson.build to get it tested with the windows compiler. > >> Any idea on when is this getting added to CI? > > > > You need to add this to next version of the patch. > > I tried it and MSVC has no problems with the new code. > > > > Another issue is the naming. Right now the choice of 'deque' generates lots of > > checkpatch errors, and every bit of new code that uses the library will get a warning > > as well. Can you think of a better name? > > > > diff --git a/lib/meson.build b/lib/meson.build > > index 8c8c1e98e2..127e4dc68c 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -75,6 +75,7 @@ if is_ms_compiler > > 'kvargs', > > 'telemetry', > > 'eal', > > + 'deque', > > 'ring', > > ] > > endif > As discussed in Techboard meeting, the above change is not required as Tyler has a patch [1] that addresses this. > > [1] https://patches.dpdk.org/project/dpdk/patch/1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com/ agreed, please merge my series first to get the correct outcome. thanks!