From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C7B743E06; Fri, 5 Apr 2024 17:02:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6158A402D4; Fri, 5 Apr 2024 17:02:50 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 16B9E402CE for ; Fri, 5 Apr 2024 17:02:48 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2a46de5185eso489001a91.1 for ; Fri, 05 Apr 2024 08:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712329368; x=1712934168; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fFgfcJHLx8pPY8VuapKHcaCnHCsP9CnTraDfO78jwA0=; b=XBZb6OIkIYj1cWC9o++zoZz6guvKD3S9tSbHG4LdU3J5Y5fmCmTq39AolW0YLWSusr k+MwVgUg8XS7oXCmAa0IyDkVW9iYIHZkQB33EqOYNNzejUCPPUx+VlOc1g2Bx8hELNYM QJoFhnhdmXzvpDWhfdwnmGNZNoiCAZCfLkQoag4AhqMDKWmRPnPtx0TpcspN3EIdDUVA 7SkA+eGs0xYzvBPV1OqiSTsX6iKUL6KLKuCF/bNIJpA3s08ZR8gfSTcNU2y6mb6sCBRx NOL3lzOgnpo337BKTWw6VDTzs4eSudM8VmzySuTiSuYRLC2Oovhqhf4hpbSPdm9wZel6 /JJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712329368; x=1712934168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fFgfcJHLx8pPY8VuapKHcaCnHCsP9CnTraDfO78jwA0=; b=nSVgGasLcQBCCEeWp/OGSQYTI/IL9jYzcld62t2vrnso1bQuETc9ARGCNQ2fRtx+h3 twjvkoLLCgO5mJlSxR4yW42JhHIsWcbw84zdT7W3ynCyV23Z5bJtzHMV7qyxhxfWBmVQ r4rbOLx8bcNEvgauQoocUZ7AmZI7bdZy/el+fRosB17bHrIyA/JKPo67V3m2UZaA3ini IaU59FZisfKYZ0vzGpM45STqDs0jtRMVpepQaQTuy/Soy7YrkMKNSWprryhEHKNZUYAN fLz2xFs/ADURfuhe7Mw4gHVARdTOxq6p1ggFrg+rysWw70MUpGYyRJ84q8h6uzT3KgNP thkA== X-Gm-Message-State: AOJu0YzPJwu2MNUz2idnLgbBRbsDyiE9uQe3EGWLwkZiPsx7iQF0FC3J jeCpV+/Pb4wSKMHQQp2J2wU1Jf0ey3Yr5q0tS+zoten1AMd2AV3NVMU5e/hzr3M= X-Google-Smtp-Source: AGHT+IGnok9aiSlf3UECSq13cKjuT0tj8Iai3DT659Vvsl83C4n7V805SDkUnJaVSqZvT9dFVNzgDQ== X-Received: by 2002:a17:90b:10c:b0:2a1:fe2c:75e9 with SMTP id p12-20020a17090b010c00b002a1fe2c75e9mr1578726pjz.42.1712329368056; Fri, 05 Apr 2024 08:02:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d22-20020a17090ae29600b0029bce05b7dfsm3430660pjz.32.2024.04.05.08.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 08:02:47 -0700 (PDT) Date: Fri, 5 Apr 2024 08:02:46 -0700 From: Stephen Hemminger To: "Chautru, Nicolas" Cc: "dev@dpdk.org" , Gagandeep Singh , Hemant Agrawal Subject: Re: [PATCH v3 17/30] baseband: replace use of fixed size rte_memcpy Message-ID: <20240405080246.4fe69e3b@hermes.local> In-Reply-To: References: <20240229225936.483472-1-stephen@networkplumber.org> <20240402215502.278838-1-stephen@networkplumber.org> <20240402215502.278838-18-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 5 Apr 2024 01:22:59 +0000 "Chautru, Nicolas" wrote: > Hi Stephen, > > Your script is causing some odd line split which are not required I believe. Also doing mix of space and tabs. > > - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN); > + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, > + ACC_FCW_LD_BLEN); The coccinelle spatch tool seems to still think that max line length should be 80. Will fix these manually.