From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B611643E0C; Fri, 5 Apr 2024 18:44:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84AEE402D4; Fri, 5 Apr 2024 18:44:33 +0200 (CEST) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id C5DE8402CE for ; Fri, 5 Apr 2024 18:44:31 +0200 (CEST) Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3c4f23d23d9so1384272b6e.3 for ; Fri, 05 Apr 2024 09:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712335471; x=1712940271; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=22UCMyUamROs8vFIW6mYY2AkIrwRjcG5TdSlGokOXQU=; b=VYlaUv6nNBDYZonW6/3RlTaX0FcvbrgVtBYeX2kb8ZDtqyPMn/MYc72dA2R6GM87Vm Vo5H4MXkbj/DXD3HaoYfKFCUo4/9Qb/17+Onrz1gJ9JlGQRqhK4sziMCQsZG0T2gOIHy NWMRGyBg+HgoL6kkGuUzvM8f5D55HibpeRA5YdNXxTQUM9ma6l5VisMa+kFIx2KnKBNX 5UhSIiUK0l9lIrrt5tXuhkv0CZYGda5/n/PdzKxpEprO2rgPTWmqq4XRbuKAWJ0StJ4c MKmwIxZLaE2AxU6SiUcirnhQiiBzHXu9W/H1diKis5lW5gRtQTSV5+8W8x2Gh69nFhHv WNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712335471; x=1712940271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=22UCMyUamROs8vFIW6mYY2AkIrwRjcG5TdSlGokOXQU=; b=POMgdXqke/8YWuq2r4pvsB1lDYO+oW4bZ+3w7j5kfzzOkQ3SGnvYixDzcHNsZj/DxB WimOPCNjd8rhYrBGEzjicKcCL7X78hp4vy21Ic0xiZfpXir4/mb82K+6tWdPshB7/FuO 45zkjJndPmtfM03v0kiN9PMguIo8DU3Z8jm30ACmNGcqJ2PBEX88jJXKYaT79qnrxVJk rc9QlTUDe37hCoWPJcLN3rSArIsmcxBCVyTOeHOhOjL+g5dYj43tIK6ArHamtXUlZXO/ CyJt3eept6i/Zz8xxmTREhvePpY2BWSUWs+Foc2WT6DZczpABKL/pE90ICyQ84f5bqHk soqw== X-Gm-Message-State: AOJu0YwsiHSRrH/QX0TXB6WLf2JNIubP/RfIl8up/9Gh9YNHdUkWUtNl K++keUY5x7U0R7/NErOVjKvUexMdrhhbfPme6gvbAY2zi6Tb3GvPw0hddNGUMDo= X-Google-Smtp-Source: AGHT+IGcvRjwfSpyq/T3nHN3d+qtHgWpp9kz8Vx0PrYYkcoylO5a0BrhLnQJasMKRySKgnR33vgGAg== X-Received: by 2002:a05:6359:5092:b0:183:55a6:b22c with SMTP id on18-20020a056359509200b0018355a6b22cmr2114048rwb.2.1712335470898; Fri, 05 Apr 2024 09:44:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id w26-20020a63161a000000b005f0a1a46f08sm1485388pgl.11.2024.04.05.09.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 09:44:30 -0700 (PDT) Date: Fri, 5 Apr 2024 09:44:27 -0700 From: Stephen Hemminger To: Dengdui Huang Cc: , , , , Subject: Re: [PATCH] app/testpmd: handle IEEE1588 init fail Message-ID: <20240405094427.32d19496@hermes.local> In-Reply-To: <20240330074409.273916-1-huangdengdui@huawei.com> References: <20240330074409.273916-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 30 Mar 2024 15:44:09 +0800 Dengdui Huang wrote: > When the port's timestamping function failed to initialize > (for example, the device does not support PTP), the packets > received by the hardware do not contain the timestamp. > In this case, IEEE1588 packet forwarding should not start. > This patch fix it. > > Plus, adding a failure message when failed to disable PTP. > > Fixes: a78040c990cb ("app/testpmd: update forward engine beginning") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang Noticed that ieee1588 part is printing errors to stdout, but other parts of test-pmd are using stderr or TEST_PMD_LOG. It would be good to decide on one good way to handle this across all of testpmd.