From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id ED8AC43E0C;
Fri, 5 Apr 2024 18:57:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 51914406B7;
Fri, 5 Apr 2024 18:55:59 +0200 (CEST)
Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com
[209.85.210.181])
by mails.dpdk.org (Postfix) with ESMTP id 2F9C040E5E
for <dev@dpdk.org>; Fri, 5 Apr 2024 18:55:58 +0200 (CEST)
Received: by mail-pf1-f181.google.com with SMTP id
d2e1a72fcca58-6ecee1f325bso1894073b3a.2
for <dev@dpdk.org>; Fri, 05 Apr 2024 09:55:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712336157;
x=1712940957; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;
b=Uo+RxTVGaS4bpS8oMx9aiFPXKTgCr5SUG5ae1iap9eecsLLU9JwWYPvGFkywqiD53t
ZWsrStGuVIzoskd34B47gqEvdZ1IGUOlMrKq2LNzMp3MNdgqbTrbrt8TMiF+iKK2dT9F
v/nNRNlMH56iL6lhmYfKXC6C0aRv93MD9+ez2KBICJAIBQFB479Ah/92QUgLGaY/RVgF
pvpobs+/L48kUIgpBYIyvkm13H13v5+SdgRoQicj0SenJElFS91T35P2c8l2s/+i4rtX
xiQIa35sLJbMYJM7PmjA47RKeaMLuciIaGiWBFjaIEN0P7iM44NZN+vZcwRBWH+bo+Zu
o1dA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1712336157; x=1712940957;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;
b=oRJwrARKsZfQDkxWxbaWZEERJyv589rFw26E0SQoV2hzZStiLqvQHK3+hztWJllxVt
Bv+SUfaXPAxPtU3yhfqplw+pZVi1ySCI0yQ4TRUHumsfu0YESioMgKRB1PQbBI3zI1wJ
Qu4XsHnofMeL5DZjOoF/AobCq/exJJ3p0QsjlTn6XWH1+ziHXAtHYVwvtx5SCRs5Ht1R
Aojo13nur84CQ6w/Yj/WAviDlOVn+rcZwSnSGv+FfHECMnEiomCXZAoN5vA3NZ/mls0Y
vqgm62ZyhOhJSQcOBy2Dbk/vapEHNoOD58KQ8vV9//edp9+/kEfhHgnRiIqj9ZGUSJa2
grjw==
X-Gm-Message-State: AOJu0YxU75/LkFGihsnfF1H2XKd37yu39O7m0mtKx0rJrXiMfmp5H3BB
6fMzPNj6ZjGrb2261xLq7EfijWptTFzGmfyBaGiQlbNIkxLzwORYisr3SSSlmLxyyMd3J+IXVcm
n1JQCVg==
X-Google-Smtp-Source: AGHT+IEjEIosbX9ZuRCjj8mygRsWxwfwKZYqAcCr7HdOVUDdfd+4TshSMVhNI27sEC0bXt7RoY0myg==
X-Received: by 2002:a05:6a00:14d3:b0:6ea:afd1:9023 with SMTP id
w19-20020a056a0014d300b006eaafd19023mr2395117pfu.0.1712336157352;
Fri, 05 Apr 2024 09:55:57 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
c2-20020aa781c2000000b006e6c0f8ce1bsm1728555pfn.47.2024.04.05.09.55.56
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 05 Apr 2024 09:55:56 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Rosen Xu <rosen.xu@intel.com>, Sachin Saxena <sachin.saxena@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [PATCH v4 16/30] raw: replace use of fixed size rte_memcpy
Date: Fri, 5 Apr 2024 09:53:27 -0700
Message-ID: <20240405165518.367503-17-stephen@networkplumber.org>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20240405165518.367503-1-stephen@networkplumber.org>
References: <20240403163432.437275-1-stephen@networkplumber.org>
<20240405165518.367503-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Automatically generated by devtools/cocci/rte_memcpy.cocci
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +--
drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +--
drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +--
drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++----
drivers/raw/ifpga/ifpga_rawdev.c | 11 +++++------
drivers/raw/skeleton/skeleton_rawdev.c | 8 +++-----
drivers/raw/skeleton/skeleton_rawdev_test.c | 1 -
7 files changed, 15 insertions(+), 22 deletions(-)
diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c
index 859f28dcc1..c2aaed9203 100644
--- a/drivers/raw/ifpga/afu_pmd_he_hssi.c
+++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c
@@ -15,7 +15,6 @@
#include <rte_eal.h>
#include <rte_malloc.h>
-#include <rte_memcpy.h>
#include <rte_io.h>
#include <rte_vfio.h>
#include <bus_pci_driver.h>
@@ -314,7 +313,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config,
if (cfg->port >= NUM_HE_HSSI_PORTS)
return -EINVAL;
- rte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));
+ memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));
return 0;
}
diff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c
index c7c5cda48c..ffb7075c84 100644
--- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c
+++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c
@@ -15,7 +15,6 @@
#include <rte_eal.h>
#include <rte_malloc.h>
-#include <rte_memcpy.h>
#include <rte_io.h>
#include <rte_vfio.h>
#include <bus_pci_driver.h>
@@ -363,7 +362,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config,
if ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES))
return -EINVAL;
- rte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));
+ memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));
return 0;
}
diff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c
index a1db533eeb..b799e40d2d 100644
--- a/drivers/raw/ifpga/afu_pmd_he_mem.c
+++ b/drivers/raw/ifpga/afu_pmd_he_mem.c
@@ -14,7 +14,6 @@
#include <rte_eal.h>
#include <rte_malloc.h>
-#include <rte_memcpy.h>
#include <rte_io.h>
#include <rte_vfio.h>
#include <bus_pci_driver.h>
@@ -126,7 +125,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config,
if (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg))
return -EINVAL;
- rte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));
+ memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));
return 0;
}
diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c
index 67b3941265..9236c0b153 100644
--- a/drivers/raw/ifpga/afu_pmd_n3000.c
+++ b/drivers/raw/ifpga/afu_pmd_n3000.c
@@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,
if ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) ||
(cfg->nlb_cfg.end > MAX_CACHE_LINES))
return -EINVAL;
- rte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg,
- sizeof(struct rte_pmd_afu_nlb_cfg));
+ memcpy(&priv->nlb_cfg, &cfg->nlb_cfg,
+ sizeof(struct rte_pmd_afu_nlb_cfg));
} else if (cfg->type == RTE_PMD_AFU_N3000_DMA) {
if (cfg->dma_cfg.index >= NUM_N3000_DMA)
return -EINVAL;
@@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,
cfg->dma_cfg.length);
}
}
- rte_memcpy(&priv->dma_cfg, &cfg->dma_cfg,
- sizeof(struct rte_pmd_afu_dma_cfg));
+ memcpy(&priv->dma_cfg, &cfg->dma_cfg,
+ sizeof(struct rte_pmd_afu_dma_cfg));
} else {
IFPGA_RAWDEV_PMD_ERR("Invalid type of N3000 AFU");
return -EINVAL;
diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index f89bd3f9e2..d5d47e14dd 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -14,7 +14,6 @@
#include <rte_log.h>
#include <rte_malloc.h>
#include <rte_devargs.h>
-#include <rte_memcpy.h>
#include <rte_pci.h>
#include <bus_pci_driver.h>
#include <rte_kvargs.h>
@@ -258,7 +257,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev)
if (point < 12)
return -1;
point -= 12;
- rte_memcpy(ifpga_dev->parent_bdf, &link[point], 12);
+ memcpy(ifpga_dev->parent_bdf, &link[point], 12);
point = strlen(link1);
if (point < 26)
@@ -948,10 +947,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev,
if (ret)
return ret;
- rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,
- sizeof(u64));
- rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,
- sizeof(u64));
+ memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,
+ sizeof(u64));
+ memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,
+ sizeof(u64));
IFPGA_RAWDEV_PMD_INFO("%s: uuid_l=0x%lx, uuid_h=0x%lx\n",
__func__,
diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c
index 6e99d35536..256f45cb5d 100644
--- a/drivers/raw/skeleton/skeleton_rawdev.c
+++ b/drivers/raw/skeleton/skeleton_rawdev.c
@@ -20,7 +20,6 @@
#include <rte_log.h>
#include <rte_malloc.h>
#include <rte_memory.h>
-#include <rte_memcpy.h>
#include <rte_lcore.h>
#include <bus_vdev_driver.h>
@@ -245,8 +244,8 @@ static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,
skelq = &skeldev->queues[queue_id];
if (queue_id < SKELETON_MAX_QUEUES)
- rte_memcpy(queue_conf, skelq,
- sizeof(struct skeleton_rawdev_queue));
+ memcpy(queue_conf, skelq,
+ sizeof(struct skeleton_rawdev_queue));
return 0;
}
@@ -281,8 +280,7 @@ static int skeleton_rawdev_queue_setup(struct rte_rawdev *dev,
if (skeldev->num_queues > queue_id &&
q->depth < SKELETON_QUEUE_MAX_DEPTH) {
- rte_memcpy(q, queue_conf,
- sizeof(struct skeleton_rawdev_queue));
+ memcpy(q, queue_conf, sizeof(struct skeleton_rawdev_queue));
clear_queue_bufs(queue_id);
} else {
SKELETON_PMD_ERR("Invalid queue configuration");
diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c
index b7a7f623aa..dc32c4e29b 100644
--- a/drivers/raw/skeleton/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c
@@ -7,7 +7,6 @@
#include <rte_common.h>
#include <rte_mbuf.h>
#include <rte_malloc.h>
-#include <rte_memcpy.h>
#include <dev_driver.h>
#include <rte_rawdev.h>
#include <bus_vdev_driver.h>
--
2.43.0