From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6C0A543E0E;
Fri, 5 Apr 2024 23:18:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4622F4069D;
Fri, 5 Apr 2024 23:18:02 +0200 (CEST)
Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com
[209.85.215.178])
by mails.dpdk.org (Postfix) with ESMTP id F3FDB4028A
for <dev@dpdk.org>; Fri, 5 Apr 2024 23:17:59 +0200 (CEST)
Received: by mail-pg1-f178.google.com with SMTP id
41be03b00d2f7-5ce6b5e3c4eso1683443a12.2
for <dev@dpdk.org>; Fri, 05 Apr 2024 14:17:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712351879;
x=1712956679; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;
b=PPSIXYZkPOaqu46Se4KMrh1dT2giGx7i2BABLE3a00G54476Z32D0AGe36KZUe5Fha
Mayix+J1hdY5KZQ8iEtSxnGWWRh44vMygTTQOEWK0ysVx+3N87NyStrLXXrb0sbzn0Hr
JUXCaXCCTuPzty5zFKpukDzmgh0GsqXGDOYDdH5XAuV10TjHNsyuVZXZhElxSEKCtotV
jCkQxLdKHmo7/UfGVBDkP2MKE0k8XP1ijHmeJHTgGa6fw6oEUV4R4rL4d2oteDYwFuZg
iqX0nUt47Wr+iPt68dZx1toWrcEMZkrgipYcMTvvEwdiFrr8pA20Yo7oGy2LiLRIXviQ
GVuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1712351879; x=1712956679;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;
b=oWFWmHLxLDvuBA+jVH7FX98QHcPTEk6vqqVLjJvHIwg8L1jxm20gq9wi8bUEEPze8V
zsmr4Lvqrs/O9K6Nc7lvjscFhx4qAXSAWbkMOQHiHc5LNrdToZeRwoUPyCNricyzGO4D
R5mip/mbDlPagCF9r8A1WbBfNgOWhJgnMJXsoAMOFCr9umJTrpHMLcDB3k5KUYskGAz2
qrE4yqfhif++F4KbnCMvFwtGGcJZrER2cDgvjL8gXqF2w95avCX3chVKPPrz8ULIi8ai
7c6It7ofIuN6e7adTKWnEOapredlSNT04RSuRHBa4tY8yA/IbacKdskmeI5DLRbB9cLO
xWbA==
X-Gm-Message-State: AOJu0YyJjvEmNHtZb//FtDAA/JniLVJ1KQ7tDnS80WdzpH+Z+QQLtkeB
WuLmfq96jUgphL9q++e83SMdDy2GyIh4AG3WOXP0XWWY6QfDdTceGmE3+Z/gQYR5aF7u/Px8OYi
AaeAr0Q==
X-Google-Smtp-Source: AGHT+IHAQnU6CANJQMUhXTaCveQbht5mZrV6D75LHrt0zl8AGMX7+5bnyasJVebYwNzQT5IOd2zD/w==
X-Received: by 2002:a17:90a:bf04:b0:2a2:21a0:b151 with SMTP id
c4-20020a17090abf0400b002a221a0b151mr2570858pjs.20.1712351879158;
Fri, 05 Apr 2024 14:17:59 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
r32-20020a17090a43a300b002a2f1e6f50bsm2137521pjg.1.2024.04.05.14.17.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 05 Apr 2024 14:17:58 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v6 3/8] net/tap: remove unused fields
Date: Fri, 5 Apr 2024 14:14:55 -0700
Message-ID: <20240405211745.699697-4-stephen@networkplumber.org>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20240405211745.699697-1-stephen@networkplumber.org>
References: <20240130034925.44869-1-stephen@networkplumber.org>
<20240405211745.699697-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The driver doesn't support these other hash types, and there
is no reason to implement these in future. The rss_flows list
was set but never used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.h | 4 +---
drivers/net/tap/tap_flow.c | 1 -
drivers/net/tap/tap_rss.h | 6 ------
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h
index dc8201020b..1bcf92ce80 100644
--- a/drivers/net/tap/rte_eth_tap.h
+++ b/drivers/net/tap/rte_eth_tap.h
@@ -77,14 +77,12 @@ struct pmd_internals {
int ioctl_sock; /* socket for ioctl calls */
int nlsk_fd; /* Netlink socket fd */
int flow_isolate; /* 1 if flow isolation is enabled */
- int flower_support; /* 1 if kernel supports, else 0 */
- int flower_vlan_support; /* 1 if kernel supports, else 0 */
int rss_enabled; /* 1 if RSS is enabled, else 0 */
int persist; /* 1 if keep link up, else 0 */
/* implicit rules set when RSS is enabled */
int map_fd; /* BPF RSS map fd */
int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */
- LIST_HEAD(tap_rss_flows, rte_flow) rss_flows;
+
LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */
/* implicit rte_flow rules set when a remote device is active */
LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows;
diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index a78fd50cd4..8fccd599f0 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd,
errno, strerror(errno));
return err;
}
- LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next);
}
pmd->rss_enabled = 1;
diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h
index dff46a012f..8766ffc244 100644
--- a/drivers/net/tap/tap_rss.h
+++ b/drivers/net/tap/tap_rss.h
@@ -21,12 +21,6 @@ enum hash_field {
HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */
HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */
HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */
- HASH_FIELD_L2_SRC, /* Ethernet src addr */
- HASH_FIELD_L2_DST, /* Ethernet dst addr */
- HASH_FIELD_L3_SRC, /* L3 src addr */
- HASH_FIELD_L3_DST, /* L3 dst addr */
- HASH_FIELD_L4_SRC, /* TCP/UDP src ports */
- HASH_FIELD_L4_DST, /* TCP/UDP dst ports */
};
struct rss_key {
--
2.43.0