DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [PATCH] net/ice: fix EIPT check is always true
  2024-04-08 15:16 [PATCH] net/ice: fix EIPT check is always true Shiyang He
@ 2024-04-08  9:28 ` David Marchand
  0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2024-04-08  9:28 UTC (permalink / raw)
  To: Shiyang He; +Cc: dev, stable, Qi Zhang, Murphy Yang, Bruce Richardson

On Mon, Apr 8, 2024 at 9:55 AM Shiyang He <shiyangx.he@intel.com> wrote:
>
> When enabling hardware outer UDP TX offload checksum, the EIPT judgment
> is always true because ICE_TX_CTX_EIPT_NONE = 0x0.
>
> This patch fixes it by checking the non-zero EIPT flag.

Duplicate of: https://patchwork.dpdk.org/project/dpdk/patch/20240405144604.906695-2-david.marchand@redhat.com/.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] net/ice: fix EIPT check is always true
@ 2024-04-08 15:16 Shiyang He
  2024-04-08  9:28 ` David Marchand
  0 siblings, 1 reply; 2+ messages in thread
From: Shiyang He @ 2024-04-08 15:16 UTC (permalink / raw)
  To: dev; +Cc: stable, Shiyang He, Qi Zhang, Murphy Yang

When enabling hardware outer UDP TX offload checksum, the EIPT judgment
is always true because ICE_TX_CTX_EIPT_NONE = 0x0.

This patch fixes it by checking the non-zero EIPT flag.

Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload")
Cc: stable@dpdk.org

Signed-off-by: Shiyang He <shiyangx.he@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 13aabe97a5..3e2264de7d 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2751,7 +2751,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
 	 * Calculate the tunneling UDP checksum.
 	 * Shall be set only if L4TUNT = 01b and EIPT is not zero
 	 */
-	if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
+	if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE &&
 		(*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING) &&
 		(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM))
 		*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-08  9:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 15:16 [PATCH] net/ice: fix EIPT check is always true Shiyang He
2024-04-08  9:28 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).