From: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
To: <dev@dpdk.org>
Cc: <Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
Subject: [PATCH 11/24] net/axgbe: use definitions for mailbox commands
Date: Fri, 12 Apr 2024 08:52:36 -0400 [thread overview]
Message-ID: <20240412125249.10625-11-VenkatKumar.Ande@amd.com> (raw)
In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com>
Instead of using hardcoded values, use enumerations for mailbox command
and sub commands.
Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
---
drivers/net/axgbe/axgbe_ethdev.h | 25 +++++++++++++++++++++++++
drivers/net/axgbe/axgbe_phy_impl.c | 25 +++++++++++++++----------
2 files changed, 40 insertions(+), 10 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
index 469b3876c0..20b36ced55 100644
--- a/drivers/net/axgbe/axgbe_ethdev.h
+++ b/drivers/net/axgbe/axgbe_ethdev.h
@@ -230,6 +230,31 @@ enum axgbe_mdio_mode {
AXGBE_MDIO_MODE_CL45,
};
+enum axgbe_mb_cmd {
+ AXGBE_MB_CMD_POWER_OFF = 0,
+ AXGBE_MB_CMD_SET_1G,
+ AXGBE_MB_CMD_SET_2_5G,
+ AXGBE_MB_CMD_SET_10G_SFI,
+ AXGBE_MB_CMD_SET_10G_KR,
+ AXGBE_MB_CMD_RRC
+};
+
+enum axgbe_mb_subcmd {
+ AXGBE_MB_SUBCMD_NONE = 0,
+
+ /* 10GbE SFP subcommands */
+ AXGBE_MB_SUBCMD_ACTIVE = 0,
+ AXGBE_MB_SUBCMD_PASSIVE_1M,
+ AXGBE_MB_SUBCMD_PASSIVE_3M,
+ AXGBE_MB_SUBCMD_PASSIVE_OTHER,
+
+ /* 1GbE Mode subcommands */
+ AXGBE_MB_SUBCMD_10MBITS = 0,
+ AXGBE_MB_SUBCMD_100MBITS,
+ AXGBE_MB_SUBCMD_1G_SGMII,
+ AXGBE_MB_SUBCMD_1G_KX
+};
+
struct axgbe_phy {
uint32_t supported;
uint32_t advertising;
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c
index a58d51d606..8cc99d3a6b 100644
--- a/drivers/net/axgbe/axgbe_phy_impl.c
+++ b/drivers/net/axgbe/axgbe_phy_impl.c
@@ -1217,7 +1217,7 @@ static void axgbe_phy_pll_ctrl(struct axgbe_port *pdata, bool enable)
}
static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata,
- unsigned int cmd, unsigned int sub_cmd)
+ enum axgbe_mb_cmd cmd, enum axgbe_mb_subcmd sub_cmd)
{
unsigned int s0 = 0;
unsigned int wait;
@@ -1262,7 +1262,7 @@ static void axgbe_phy_rrc(struct axgbe_port *pdata)
/* Receiver Reset Cycle */
- axgbe_phy_perform_ratechange(pdata, 5, 0);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_RRC, AXGBE_MB_SUBCMD_NONE);
PMD_DRV_LOG(DEBUG, "receiver reset complete\n");
}
@@ -1272,7 +1272,7 @@ static void axgbe_phy_power_off(struct axgbe_port *pdata)
struct axgbe_phy_data *phy_data = pdata->phy_data;
/* Power off */
- axgbe_phy_perform_ratechange(pdata, 0, 0);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_POWER_OFF, AXGBE_MB_SUBCMD_NONE);
phy_data->cur_mode = AXGBE_MODE_UNKNOWN;
@@ -1287,14 +1287,18 @@ static void axgbe_phy_sfi_mode(struct axgbe_port *pdata)
/* 10G/SFI */
if (phy_data->sfp_cable != AXGBE_SFP_CABLE_PASSIVE) {
- axgbe_phy_perform_ratechange(pdata, 3, 0);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,
+ AXGBE_MB_SUBCMD_ACTIVE);
} else {
if (phy_data->sfp_cable_len <= 1)
- axgbe_phy_perform_ratechange(pdata, 3, 1);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,
+ AXGBE_MB_SUBCMD_PASSIVE_1M);
else if (phy_data->sfp_cable_len <= 3)
- axgbe_phy_perform_ratechange(pdata, 3, 2);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,
+ AXGBE_MB_SUBCMD_PASSIVE_3M);
else
- axgbe_phy_perform_ratechange(pdata, 3, 3);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,
+ AXGBE_MB_SUBCMD_PASSIVE_OTHER);
}
phy_data->cur_mode = AXGBE_MODE_SFI;
@@ -1309,7 +1313,8 @@ static void axgbe_phy_kr_mode(struct axgbe_port *pdata)
axgbe_phy_set_redrv_mode(pdata);
/* 10G/KR */
- axgbe_phy_perform_ratechange(pdata, 4, 0);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_KR,
+ AXGBE_MB_SUBCMD_NONE);
phy_data->cur_mode = AXGBE_MODE_KR;
PMD_DRV_LOG(DEBUG, "10GbE KR mode set\n");
@@ -1322,7 +1327,7 @@ static void axgbe_phy_kx_2500_mode(struct axgbe_port *pdata)
axgbe_phy_set_redrv_mode(pdata);
/* 2.5G/KX */
- axgbe_phy_perform_ratechange(pdata, 2, 0);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_2_5G, AXGBE_MB_SUBCMD_NONE);
phy_data->cur_mode = AXGBE_MODE_KX_2500;
}
@@ -1333,7 +1338,7 @@ static void axgbe_phy_sgmii_1000_mode(struct axgbe_port *pdata)
axgbe_phy_set_redrv_mode(pdata);
/* 1G/SGMII */
- axgbe_phy_perform_ratechange(pdata, 1, 2);
+ axgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_1G, AXGBE_MB_SUBCMD_1G_SGMII);
phy_data->cur_mode = AXGBE_MODE_SGMII_1000;
}
--
2.34.1
next prev parent reply other threads:[~2024-04-12 12:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:52 [PATCH 01/24] net/axgbe: remove use of comm_owned field Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 02/24] net/axgbe: remove field of SFP diagnostic support Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 03/24] net/axgbe: improve SFP 100Mbps auto-negotiation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 04/24] net/axgbe: check mdio for non-zero ports and CL45 PHYs Venkat Kumar Ande
2024-04-22 15:21 ` Ferruh Yigit
2024-04-12 12:52 ` [PATCH 05/24] net/axgbe: remove unnecessary conversion to bool Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 06/24] net/axgbe: reset link when the link never comes back Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 07/24] net/axgbe: check fluctuations for 1G BELFUSE SFP Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 08/24] net/axgbe: update DMA coherency values Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 09/24] net/axgbe: disable interrupts during device removal Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 10/24] net/axgbe: yellow carp devices do not need rrc Venkat Kumar Ande
2024-04-12 12:52 ` Venkat Kumar Ande [this message]
2024-04-12 12:52 ` [PATCH 12/24] net/axgbe: enable PLL control for fixed PHY modes only Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 13/24] net/axgbe: improve the SFP codes check for DAC cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 14/24] net/axgbe: improve logic around active and passive cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 15/24] net/axgbe: check only the minimum speed for cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 16/24] net/axgbe: add support for 10 Mbps speed Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 17/24] net/axgbe: flow Tx Ctrl Registers are h/w ver dependent Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 18/24] net/axgbe: delay AN timeout during KR training Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 19/24] net/axgbe: separate C22 and C45 transactions Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 20/24] net/axgbe: replace mii generic macro for c45 with AXGBE Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 21/24] net/axgbe: add 2.5GbE support to 10G BaseT mode Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 22/24] net/axgbe: add support for Rx adaptation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 23/24] net/axgbe: improve the false linkup in axgbe PHY status Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 24/24] net/axgbe: extend 10Mbps support to MAC version 21H Venkat Kumar Ande
2024-04-22 15:12 ` [PATCH 01/24] net/axgbe: remove use of comm_owned field Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412125249.10625-11-VenkatKumar.Ande@amd.com \
--to=venkatkumar.ande@amd.com \
--cc=Selwin.Sebastian@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).