From: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
To: <dev@dpdk.org>
Cc: <Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
Subject: [PATCH 14/24] net/axgbe: improve logic around active and passive cables
Date: Fri, 12 Apr 2024 08:52:39 -0400 [thread overview]
Message-ID: <20240412125249.10625-14-VenkatKumar.Ande@amd.com> (raw)
In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com>
SFP+ active and passive cables are copper cables with fixed SFP+ end
connectors. Due to a misinterpretation of this, SFP+ active cables could
end up not being recognized, causing the driver to fail to establish a
connection.
Introduce a new enum in SFP+ cable types, XGBE_SFP_CABLE_FIBER, that is
the default cable type, and handle active and passive cables when they are
specifically detected.
Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
---
drivers/net/axgbe/axgbe_phy_impl.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c
index b5b962151d..693590da53 100644
--- a/drivers/net/axgbe/axgbe_phy_impl.c
+++ b/drivers/net/axgbe/axgbe_phy_impl.c
@@ -69,6 +69,7 @@ enum axgbe_sfp_cable {
AXGBE_SFP_CABLE_UNKNOWN = 0,
AXGBE_SFP_CABLE_ACTIVE,
AXGBE_SFP_CABLE_PASSIVE,
+ AXGBE_SFP_CABLE_FIBER,
};
enum axgbe_sfp_base {
@@ -601,16 +602,18 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata)
axgbe_phy_sfp_parse_quirks(pdata);
- /* Assume ACTIVE cable unless told it is PASSIVE */
+ /* Assume FIBER cable unless told otherwise */
if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_PASSIVE) {
phy_data->sfp_cable = AXGBE_SFP_CABLE_PASSIVE;
phy_data->sfp_cable_len = sfp_base[AXGBE_SFP_BASE_CU_CABLE_LEN];
- } else {
+ } else if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_ACTIVE) {
phy_data->sfp_cable = AXGBE_SFP_CABLE_ACTIVE;
+ } else {
+ phy_data->sfp_cable = AXGBE_SFP_CABLE_FIBER;
}
/* Determine the type of SFP */
- if (phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE &&
+ if (phy_data->sfp_cable != AXGBE_SFP_CABLE_FIBER &&
axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000))
phy_data->sfp_base = AXGBE_SFP_BASE_10000_CR;
else if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)
--
2.34.1
next prev parent reply other threads:[~2024-04-12 12:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:52 [PATCH 01/24] net/axgbe: remove use of comm_owned field Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 02/24] net/axgbe: remove field of SFP diagnostic support Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 03/24] net/axgbe: improve SFP 100Mbps auto-negotiation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 04/24] net/axgbe: check mdio for non-zero ports and CL45 PHYs Venkat Kumar Ande
2024-04-22 15:21 ` Ferruh Yigit
2024-04-12 12:52 ` [PATCH 05/24] net/axgbe: remove unnecessary conversion to bool Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 06/24] net/axgbe: reset link when the link never comes back Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 07/24] net/axgbe: check fluctuations for 1G BELFUSE SFP Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 08/24] net/axgbe: update DMA coherency values Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 09/24] net/axgbe: disable interrupts during device removal Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 10/24] net/axgbe: yellow carp devices do not need rrc Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 11/24] net/axgbe: use definitions for mailbox commands Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 12/24] net/axgbe: enable PLL control for fixed PHY modes only Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 13/24] net/axgbe: improve the SFP codes check for DAC cables Venkat Kumar Ande
2024-04-12 12:52 ` Venkat Kumar Ande [this message]
2024-04-12 12:52 ` [PATCH 15/24] net/axgbe: check only the minimum speed for cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 16/24] net/axgbe: add support for 10 Mbps speed Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 17/24] net/axgbe: flow Tx Ctrl Registers are h/w ver dependent Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 18/24] net/axgbe: delay AN timeout during KR training Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 19/24] net/axgbe: separate C22 and C45 transactions Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 20/24] net/axgbe: replace mii generic macro for c45 with AXGBE Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 21/24] net/axgbe: add 2.5GbE support to 10G BaseT mode Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 22/24] net/axgbe: add support for Rx adaptation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 23/24] net/axgbe: improve the false linkup in axgbe PHY status Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 24/24] net/axgbe: extend 10Mbps support to MAC version 21H Venkat Kumar Ande
2024-04-22 15:12 ` [PATCH 01/24] net/axgbe: remove use of comm_owned field Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412125249.10625-14-VenkatKumar.Ande@amd.com \
--to=venkatkumar.ande@amd.com \
--cc=Selwin.Sebastian@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).