DPDK patches and discussions
 help / color / mirror / Atom feed
From: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
To: <dev@dpdk.org>
Cc: <Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
Subject: [PATCH 02/24] net/axgbe: remove field of SFP diagnostic support
Date: Fri, 12 Apr 2024 08:52:27 -0400	[thread overview]
Message-ID: <20240412125249.10625-2-VenkatKumar.Ande@amd.com> (raw)
In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com>

The driver currently sets an indication of whether the SFP supports, and
that the driver can obtain, diagnostics data.  This isn't currently used
by the driver.  Remove this field and the logic supporting it.

Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
---
 drivers/net/axgbe/axgbe_phy_impl.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c
index 70e7c56439..e1b926d48a 100644
--- a/drivers/net/axgbe/axgbe_phy_impl.c
+++ b/drivers/net/axgbe/axgbe_phy_impl.c
@@ -220,7 +220,6 @@ struct axgbe_phy_data {
 	unsigned int sfp_rx_los;
 	unsigned int sfp_tx_fault;
 	unsigned int sfp_mod_absent;
-	unsigned int sfp_diags;
 	unsigned int sfp_changed;
 	unsigned int sfp_phy_avail;
 	unsigned int sfp_cable_len;
@@ -701,14 +700,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata)
 	if (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom))) {
 		phy_data->sfp_changed = 1;
 		memcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom));
-
-		if (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) {
-			uint8_t diag_type;
-			diag_type = sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG];
-
-			if (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE))
-				phy_data->sfp_diags = 1;
-		}
 	} else {
 		phy_data->sfp_changed = 0;
 	}
@@ -769,7 +760,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *phy_data)
 	phy_data->sfp_rx_los = 0;
 	phy_data->sfp_tx_fault = 0;
 	phy_data->sfp_mod_absent = 1;
-	phy_data->sfp_diags = 0;
 	phy_data->sfp_base = AXGBE_SFP_BASE_UNKNOWN;
 	phy_data->sfp_cable = AXGBE_SFP_CABLE_UNKNOWN;
 	phy_data->sfp_speed = AXGBE_SFP_SPEED_UNKNOWN;
-- 
2.34.1


  reply	other threads:[~2024-04-12 12:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 12:52 [PATCH 01/24] net/axgbe: remove use of comm_owned field Venkat Kumar Ande
2024-04-12 12:52 ` Venkat Kumar Ande [this message]
2024-04-12 12:52 ` [PATCH 03/24] net/axgbe: improve SFP 100Mbps auto-negotiation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 04/24] net/axgbe: check mdio for non-zero ports and CL45 PHYs Venkat Kumar Ande
2024-04-22 15:21   ` Ferruh Yigit
2024-04-12 12:52 ` [PATCH 05/24] net/axgbe: remove unnecessary conversion to bool Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 06/24] net/axgbe: reset link when the link never comes back Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 07/24] net/axgbe: check fluctuations for 1G BELFUSE SFP Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 08/24] net/axgbe: update DMA coherency values Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 09/24] net/axgbe: disable interrupts during device removal Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 10/24] net/axgbe: yellow carp devices do not need rrc Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 11/24] net/axgbe: use definitions for mailbox commands Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 12/24] net/axgbe: enable PLL control for fixed PHY modes only Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 13/24] net/axgbe: improve the SFP codes check for DAC cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 14/24] net/axgbe: improve logic around active and passive cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 15/24] net/axgbe: check only the minimum speed for cables Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 16/24] net/axgbe: add support for 10 Mbps speed Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 17/24] net/axgbe: flow Tx Ctrl Registers are h/w ver dependent Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 18/24] net/axgbe: delay AN timeout during KR training Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 19/24] net/axgbe: separate C22 and C45 transactions Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 20/24] net/axgbe: replace mii generic macro for c45 with AXGBE Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 21/24] net/axgbe: add 2.5GbE support to 10G BaseT mode Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 22/24] net/axgbe: add support for Rx adaptation Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 23/24] net/axgbe: improve the false linkup in axgbe PHY status Venkat Kumar Ande
2024-04-12 12:52 ` [PATCH 24/24] net/axgbe: extend 10Mbps support to MAC version 21H Venkat Kumar Ande
2024-04-22 15:12 ` [PATCH 01/24] net/axgbe: remove use of comm_owned field Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412125249.10625-2-VenkatKumar.Ande@amd.com \
    --to=venkatkumar.ande@amd.com \
    --cc=Selwin.Sebastian@amd.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).