From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 591F143E55; Sat, 13 Apr 2024 00:52:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D70240A6C; Sat, 13 Apr 2024 00:52:51 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id ECDB8406B8 for ; Sat, 13 Apr 2024 00:52:49 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5462E20EBE36; Fri, 12 Apr 2024 15:52:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5462E20EBE36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712962369; bh=Bdpplz5kkns/t1SawGQ4IkThePYGUwPqTnVT1ZVq2f4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TG3FHf9+AeHfd6rRDD90+oqtUJhMJC/AHacHC8La56/FTezXqd1ULLKZgnH/r4jYh XjSz+Cu3/FHBmjzPRjnzoHSkQddW1jqeuPCG95didHm6Cs4wrvoeLD2Wmo/onPT6tD OJICGNo7Qu8zPy73zOkXbsdjLW6aa2iPNUKIGhHM= Date: Fri, 12 Apr 2024 15:52:49 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, Harman Kalra Subject: Re: [PATCH v2 2/2] buildtools: when building static library use static deps Message-ID: <20240412225249.GA23425@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 12, 2024 at 03:09:12PM +0100, Bruce Richardson wrote: > On Thu, Mar 14, 2024 at 11:30:22PM -0700, Tyler Retzlaff wrote: > > Use static deps when default_library=static and use shared deps when > > using default_library=shared. > > > > Signed-off-by: Tyler Retzlaff > > --- > > buildtools/chkincs/meson.build | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > > index f2dadca..66245a5 100644 > > --- a/buildtools/chkincs/meson.build > > +++ b/buildtools/chkincs/meson.build > > @@ -20,11 +20,19 @@ sources += gen_c_files.process(dpdk_chkinc_headers) > > > > # some driver SDK headers depend on these two buses, which are mandatory in build > > # so we always include them in deps list > > -deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > -# add the rest of the libs to the dependencies > > -foreach l:dpdk_libs_enabled > > - deps += get_variable('shared_rte_' + l) > > -endforeach > > shorter fix might be to use get_option('default_library') in place of the > "shared" string, rather than using a condition. done in v3. > > /Bruce > > > +if is_shared_enabled > > + deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > + # add the rest of the libs to the dependencies > > + foreach l:dpdk_libs_enabled > > + deps += get_variable('shared_rte_' + l) > > + endforeach > > +else > > + deps = [get_variable('static_rte_bus_vdev'), get_variable('static_rte_bus_pci')] > > + # add the rest of the libs to the dependencies > > + foreach l:dpdk_libs_enabled > > + deps += get_variable('static_rte_' + l) > > + endforeach > > +endif > > > > executable('chkincs', sources, > > c_args: cflags, > > -- > > 1.8.3.1 > >