DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ronak Doshi <ronak.doshi@broadcom.com>
To: Jochen Behrens <jbehrens@vmware.com>, Ronak Doshi <doshir@vmware.com>
Cc: <dev@dpdk.org>, Ronak Doshi <ronak.doshi@broadcom.com>,
	<stable@dpdk.org>
Subject: [PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command
Date: Wed, 17 Apr 2024 23:36:44 -0700	[thread overview]
Message-ID: <20240418063644.24737-1-ronak.doshi@broadcom.com> (raw)

Vmxnet3 uses capability registers to advertise the supported
capabilities of UPT device. It uses DCR0_REG command register
for this purpose. However, the register command enum misses
one command which technically is not used by dpdk vmxnet3
driver yet. This can cause issue for commands added later.

This patch fixes this issue by adding a reserved
command in its place.

Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
Cc: stable@dpdk.org

Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
--
Change log
v2: fixed typo
---
 drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h
index 24c235876e..a6bb281d8d 100644
--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
@@ -126,6 +126,7 @@ typedef enum {
    VMXNET3_CMD_RESERVED7,
    VMXNET3_CMD_RESERVED8,
    VMXNET3_CMD_GET_MAX_QUEUES_CONF,
+   VMXNET3_CMD_RESERVED11,
    VMXNET3_CMD_GET_MAX_CAPABILITIES,
    VMXNET3_CMD_GET_DCR0_REG,
 } Vmxnet3_Cmd;
-- 
2.11.0


             reply	other threads:[~2024-04-18  6:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  6:36 Ronak Doshi [this message]
2024-04-19  8:35 ` Ferruh Yigit
2024-04-22 17:48   ` Ronak Doshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418063644.24737-1-ronak.doshi@broadcom.com \
    --to=ronak.doshi@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=doshir@vmware.com \
    --cc=jbehrens@vmware.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).