From: Stephen Hemminger <stephen@networkplumber.org>
To: "Jianyue Wu (NSB)" <jianyue.wu@nokia-sbell.com>
Cc: "roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"'dev@dpdk.org'" <dev@dpdk.org>
Subject: Re: [PATCH] eal/linux: enhanced error handling for affinity
Date: Mon, 22 Apr 2024 08:30:46 -0700 [thread overview]
Message-ID: <20240422083046.2ffe5087@hermes.local> (raw)
In-Reply-To: <fa21c475248e4a42850697eb76b0de50@nokia-sbell.com>
On Mon, 22 Apr 2024 13:23:50 +0000
"Jianyue Wu (NSB)" <jianyue.wu@nokia-sbell.com> wrote:
> + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, "
> + "ret: %d, errno: %d, error description: %s",
> + thread_name, cpus_str,
> + ret, errno, strerror(errno));
> + }
That error message is way too long, and error strings should not be broken across lines.
"Set affinity thread %s to %s failed: %s"
And it is a lot effort to deduce the cpuset and thread name here.
Probably better to just move the error message back to the caller.
next prev parent reply other threads:[~2024-04-22 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:25 [dpdk-dev] Does memif support primary<->secondary process communication? Wu, Jianyue (NSB - CN/Hangzhou)
2021-06-09 12:07 ` Wu, Jianyue (NSB - CN/Hangzhou)
2024-04-22 13:23 ` [PATCH] eal/linux: enhanced error handling for affinity Jianyue Wu (NSB)
2024-04-22 13:49 ` Ferruh Yigit
2024-04-26 21:31 ` Patrick Robb
2024-04-22 13:50 ` Ferruh Yigit
2024-04-22 15:26 ` Stephen Hemminger
2024-04-22 15:27 ` Stephen Hemminger
2024-04-22 15:30 ` Stephen Hemminger [this message]
2024-04-23 3:01 ` Jianyue Wu (NSB)
2024-04-24 5:45 ` [PATCH v2] " Jianyue Wu (NSB)
2024-04-23 3:02 [PATCH] " Jianyue Wu
2024-04-24 15:50 ` Stephen Hemminger
2024-04-25 1:08 ` 吴剑跃
2024-04-25 5:40 ` 吴剑跃
2024-04-25 15:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422083046.2ffe5087@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jianyue.wu@nokia-sbell.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).