From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00CB443EDB; Mon, 22 Apr 2024 17:30:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C043040647; Mon, 22 Apr 2024 17:30:49 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 4159F40268 for ; Mon, 22 Apr 2024 17:30:49 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1e5aa82d1f6so33933905ad.0 for ; Mon, 22 Apr 2024 08:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799848; x=1714404648; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wh+aO3Affm0Rnbx3iG964tX7abXCIeVT5BCqU9wrO2g=; b=q+4k+bLl8kao+HfVxJmMmlf63KwqtReJM1s6p98qBmYVv9p6BW1cEyTpPY9kIdQ9S/ UbqlXbJWs/gEF2kZJmtDmIFaX50Dy0CgjvnBeDywsYWQmwCl7Tv6Z26dNF++WWgWOvhA YJ/cafzumciyqivrlXY0wK+VgOzhvAWlWe6j+4zd8C7y4mIzAX+yY27Rt5cMFf8pFQHU hsVvNle/XOIgbQbnbwLLUVI/JK/YnhlsaRYsPr38akazXx5kksaJbN2RKbrL8u1rOV8W Nmb0td3ESrelM8grTM2TafjgwR2jWR+a+Z9hbjC2j9NWCPoNTXTBaQ1i17iUrWsl7Ug7 a2hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713799848; x=1714404648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wh+aO3Affm0Rnbx3iG964tX7abXCIeVT5BCqU9wrO2g=; b=BOJepAFLBLBweSVEM+xsHQkm4VkKhviHooU5x8Q/3UpLVEN5emcuCxpfATRR4Eg4rL xmZ9h2nJRRaTXmjxHpBUBRifQwQHfSs7QjG7nhFkU8nopGaUVbI6kWDO6RfP1v04Pbnr A1hTx3JDhwh/Y5LXc0+uvufW0ghLpaqNiU1XoG5mZN63yKsqtR0JSjN3KlJXf+xLIj3x aQcvIv4BFLjxBjDqEa57CDpfT9P/wAyfCxNDSJSIHX5YyOOTTrE74qiji9Kft9+em97q VHy57F20NO8D05ptpsRqs/Rl3oTSETmsz+ub58sfnBmjFynpx5p/hI9YWoHCs7vZcV+G 3ANw== X-Forwarded-Encrypted: i=1; AJvYcCW3N7rujl81zYGEVU997OKoR0CBCL7nUyO8qP0OSifor4/UhgbHXR3uGpmZNevuwRE1yRm1IH/fS76ugrY= X-Gm-Message-State: AOJu0Yy2YD711ulXy+M+sYIfvl4PKH8NthXDFc24sL/1SxaQqbbPvMFt VbNx0k3RdYy0+J5vIIXjx2Yiw/yhZrUrpDbGtZBnLpzPcauu6CGoRd5n4WZtXBI= X-Google-Smtp-Source: AGHT+IGGBjsgDmlA8porRfi5MBtJ1/PllI0YkkjblQ+fNh8hP5QrIf2QRFnDKL2jfqJZhbmpwzg2Gw== X-Received: by 2002:a17:902:ce8d:b0:1e5:e5e8:73f5 with SMTP id f13-20020a170902ce8d00b001e5e5e873f5mr14892294plg.2.1713799848282; Mon, 22 Apr 2024 08:30:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id w16-20020a170902e89000b001e8ab6b927asm7029275plg.39.2024.04.22.08.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 08:30:48 -0700 (PDT) Date: Mon, 22 Apr 2024 08:30:46 -0700 From: Stephen Hemminger To: "Jianyue Wu (NSB)" Cc: "roretzla@linux.microsoft.com" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "'dev@dpdk.org'" Subject: Re: [PATCH] eal/linux: enhanced error handling for affinity Message-ID: <20240422083046.2ffe5087@hermes.local> In-Reply-To: References: <6edc5c20ca9e4bc5822bcf3f87cab66c@nokia-sbell.com> <930beb572a814989b86186c55fa574be@nokia-sbell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 22 Apr 2024 13:23:50 +0000 "Jianyue Wu (NSB)" wrote: > + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, " > + "ret: %d, errno: %d, error description: %s", > + thread_name, cpus_str, > + ret, errno, strerror(errno)); > + } That error message is way too long, and error strings should not be broken across lines. "Set affinity thread %s to %s failed: %s" And it is a lot effort to deduce the cpuset and thread name here. Probably better to just move the error message back to the caller.