From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9895143EDC; Mon, 22 Apr 2024 18:20:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DD0F40DCE; Mon, 22 Apr 2024 18:20:11 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 00F07402C5 for ; Mon, 22 Apr 2024 18:20:08 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-602801ea164so288496a12.0 for ; Mon, 22 Apr 2024 09:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713802808; x=1714407608; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=i2HhjvdFZKmfWQVAa1KUO7vp6HmYDWQsvSYuar+U9TU=; b=vNDr4uKTt98JRrK23ttK5w9N0dfH0dEx11sxVhPTyaehknwtFOkutMWzLuzKP4iY15 Jq+QMkNfMIJvLXRVW9ll7HAUcLHrTAHkfCTCyIgvDcJOi7CnLdWUwfaJygy8RtsKLL1M pgFdOhb2IzuFlhQ2uuqSx8VAGDhJMHUyB9rQ+YtKJXXV5Dhx4Hkm4QLopi+k6wkTEFZl tlJ9XxRcEeedraD3UXbnmGvzyyvrXroHuyIHB6YnDivXVteHWRFLzgDhu3qScwx4BoCE 4ztW0JfhgT48Awo99Ct5gRJCj38KQbCeFfRAXfCRpxwz3XjSbN4UkDw7ci7uX/Ohtt1R 3Kqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713802808; x=1714407608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i2HhjvdFZKmfWQVAa1KUO7vp6HmYDWQsvSYuar+U9TU=; b=B4E0rSwOUETKFfmNFo0k7A3PYYBVRMWlg/JhwbEmSY6EzubUkGR+RCM0XSi0Elj0VS n/Q3V9VdqlvqVkFhbGIN/JeTNh9XYAlWv/vaEqbuc9cto2K0KcVjTMqpRUD6n3pXiotz WTJP50i7qYbw/YeOKkXPsVLac3cWLFHRBZdLlPzuj4frpLf0Z1UwMDjTCtE0p2GOuo4V AHVH5MMQmjNJaM2Jf+w/LRAHmDatfbVljI3v5yDYljuT9nIe30jWN85FloDPhy4o4Y/5 jRL+zQv5SSNj3n+9h29eNNulhHPSQ8K4XYoQqB8r87uoG/FB05O3c0s2lrjyAFZus2jr zXvw== X-Gm-Message-State: AOJu0Yxqa7rlXQLMbe6oN3QsMyAtML7Q3TCaVxgfNQgNVp6h9N/VN6ck lZicR80E4frB8MwS4YZpmBh2e7JvjlnhS2hqYBfvHBnd5ckZx23VNrGSAYo8RIE= X-Google-Smtp-Source: AGHT+IHTTCMS62vhpKgkgARYwCYJSIKDDaFw3snIEa9NKFQL62rbhFcPrPd0KFFwvLr723HxJgtrgA== X-Received: by 2002:a17:90a:5d04:b0:2a0:4c3b:2c39 with SMTP id s4-20020a17090a5d0400b002a04c3b2c39mr10249574pji.23.1713802807893; Mon, 22 Apr 2024 09:20:07 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id s4-20020a17090aa10400b002a54632931bsm9578761pjp.23.2024.04.22.09.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 09:20:07 -0700 (PDT) Date: Mon, 22 Apr 2024 09:20:03 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: , "Nicolas Chautru" , "Gagandeep Singh" , "Hemant Agrawal" , "Parav Pandit" , "Xueming Li" , "Nipun Gupta" , "Nikhil Agarwal" , "Sachin Saxena" , "Rosen Xu" , "Tomasz Duszynski" , "Chengwen Feng" , "Long Li" , "Nithin Dabilpuram" , "Kiran Kumar K" , "Sunil Kumar Kori" , "Satha Rao" , "Harman Kalra" , "Jingjing Wu" , "Nagadheeraj Rottela" , "Srikanth Jampala" , "Andrew Rybchenko" , "Lee Daly" , "Pablo de Lara" , "Fan Zhang" , "Ashish Gupta" , "Sunila Sahu" , "Ruifeng Wang" , "Michael Shamis" , "Liron Himi" , "Kai Ji" , "Anoob Joseph" , "Zhangfei Gao" , "Bruce Richardson" , "Kevin Laatz" , "Conor Walsh" , "Abdullah Sevincer" , "Jerin Jacob" , "Harry van Haaren" , "Elena Agostini" , "John W. Linville" , "Ciara Loftus" , "Shepard Siegel" , "Ed Czeck" , "John Miller" , "Rahul Lakkireddy" , "Apeksha Gupta" , "John Daley" , "Hyong Youb Kim" , "Ziyang Xuan" , "Xiaoyun Wang" , "Guoyang Zhou" , "Andrew Boyer" , "Jakub Grajciar" , "Zyta Szpak" , "Martin Spinler" , "Tetsuya Mukawa" , "Vamsi Attunuru" , "Cristian Dumitrescu" , "Matan Azrad" , "Maxime Coquelin" , "Chenbo Xia" , "Konstantin Ananyev" , "Akhil Goyal" , "Byron Marohn" , "Yipeng Wang" , "Thomas Monjalon" , "Ferruh Yigit" , "Vladimir Medvedkin" , "Zhirun Yan" , "Sameh Gobriel" , "Reshma Pattan" , "Srikanth Yalavarthi" , "Jasvinder Singh" , "Pavan Nikhilesh" , "Anatoly Burakov" , "David Hunt" , "Sivaprasad Tummala" , "Honnappa Nagarahalli" , "Ori Kam" , "Volodymyr Fialko" , "Ciara Power" Subject: Re: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT Message-ID: <20240422092003.425c9138@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3D8@smartserver.smartshare.dk> References: <20240420000827.192451-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35E9F3D0@smartserver.smartshare.dk> <20240422081347.2d356390@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F3D8@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 22 Apr 2024 17:24:43 +0200 Morten Br=C3=B8rup wrote: > #define RTE_LOG_REGISTER_IMPL(type, name, level) \ > - int type; \ > + extern int type; \ > RTE_INIT(__##type) \ > { \ > type =3D rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \ > if (type < 0) \ > type =3D RTE_LOGTYPE_EAL; \ > } \ > + int type Not all logtypes can/should be extern.