DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
	maxime.coquelin@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
	Hernan Vargas <hernan.vargas@intel.com>
Subject: [PATCH v1 4/5] baseband/acc: improve error description
Date: Mon, 22 Apr 2024 08:40:07 -0700	[thread overview]
Message-ID: <20240422154008.119800-5-hernan.vargas@intel.com> (raw)
In-Reply-To: <20240422154008.119800-1-hernan.vargas@intel.com>

Remove dead code for error and update description of one error print.

Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
 drivers/baseband/acc/rte_acc100_pmd.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index f37722879c20..8ec521675f34 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -1152,7 +1152,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,
 	uint16_t harq_out_length, harq_in_length, ncb_p, k0_p, parity_offset;
 	uint32_t harq_index;
 	uint32_t l;
-	uint32_t max_hc_in;
 
 	fcw->qm = op->ldpc_dec.q_m;
 	fcw->nfiller = op->ldpc_dec.n_filler;
@@ -1222,21 +1221,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,
 		fcw->hcin_size1 = 0;
 	}
 
-	/* Enforce additional check on FCW validity */
-	max_hc_in = RTE_ALIGN_CEIL(fcw->ncb - fcw->nfiller, ACC_HARQ_ALIGN_64B);
-	if ((fcw->hcin_size0 > max_hc_in) ||
-			(fcw->hcin_size1 + fcw->hcin_offset > max_hc_in) ||
-			((fcw->hcin_size0 > fcw->hcin_offset) &&
-			(fcw->hcin_size1 != 0))) {
-		rte_bbdev_log(ERR, " Invalid FCW : HCIn %d %d %d, Ncb %d F %d",
-				fcw->hcin_size0, fcw->hcin_size1,
-				fcw->hcin_offset,
-				fcw->ncb, fcw->nfiller);
-		/* Disable HARQ input in that case to carry forward */
-		op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE;
-		fcw->hcin_en = 0;
-	}
-
 	fcw->itmax = op->ldpc_dec.iter_max;
 	fcw->itstop = check_bit(op->ldpc_dec.op_flags,
 			RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE);
@@ -1286,8 +1270,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,
 		fcw->hcout_offset = 0;
 
 		if (fcw->hcout_size0 == 0) {
-			rte_bbdev_log(ERR, " Invalid FCW : HCout %d",
-				fcw->hcout_size0);
+			rte_bbdev_log(ERR, " Disabling HARQ output as size is zero");
 			op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE;
 			fcw->hcout_en = 0;
 		}
-- 
2.37.1


  parent reply	other threads:[~2024-04-22 15:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 15:40 [PATCH v1 0/5] ACC100 improvements and clean up Hernan Vargas
2024-04-22 15:40 ` [PATCH v1 1/5] baseband/acc: remove ACC100 unused code Hernan Vargas
2024-05-02 15:27   ` Maxime Coquelin
2024-04-22 15:40 ` [PATCH v1 2/5] baseband/acc: remove ACC100 HARQ pruning Hernan Vargas
2024-05-02 15:28   ` Maxime Coquelin
2024-04-22 15:40 ` [PATCH v1 3/5] baseband/acc: move memory barrier Hernan Vargas
2024-05-02 15:29   ` Maxime Coquelin
2024-04-22 15:40 ` Hernan Vargas [this message]
2024-05-02 15:31   ` [PATCH v1 4/5] baseband/acc: improve error description Maxime Coquelin
2024-04-22 15:40 ` [PATCH v1 5/5] baseband/acc: cosmetic log changes Hernan Vargas
2024-05-02 15:31   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422154008.119800-5-hernan.vargas@intel.com \
    --to=hernan.vargas@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).