From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A1D43EF7; Wed, 24 Apr 2024 16:18:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1DCF434FE; Wed, 24 Apr 2024 16:18:28 +0200 (CEST) Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by mails.dpdk.org (Postfix) with ESMTP id A1F5E402AB for ; Tue, 23 Apr 2024 07:20:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=H4zWf 9YbRNCI0zPjJZQylR67xED3LRmDMzEa4BHfxbY=; b=Yf+nMYh0Kkx91uh4J1Xo/ 8wHrY1KLzVQivrxiO3IuFZY3LUx7l/tsJ8YMekZ9bvLDqfbSI8oAaaSIc9vutFpN PPwQwZtcxmzAE1tdUi9L6lLC4Bvdb8YjJ73o3z6YoQXqJ2I2tZtqiZUcOjteZsd8 x3VIKf3qjbZpv20qlxnEFM= Received: from ubuntu2204.. (unknown [36.24.144.104]) by gzga-smtp-mta-g3-1 (Coremail) with SMTP id _____wD332gURSdm_yINBg--.39914S2; Tue, 23 Apr 2024 13:20:21 +0800 (CST) From: Jianyue Wu To: Cc: dev@dpdk.org, Jianyue Wu Subject: [PATCH v2] eal/linux: enhanced error handling for affinity Date: Tue, 23 Apr 2024 13:20:18 +0800 Message-Id: <20240423052018.81334-1-wujianyue000@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wD332gURSdm_yINBg--.39914S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxXryxAw4rXryrArW5CrWfZrb_yoW5Aw15pF Wjk34Utr4rAr47u343Ja1kZa4YyFnxWa17JrWxCr1fA39rWa15Zry5KFy5Wa15ur4UGan8 ZrW3urZ09r4DJFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRDl1gUUUUU= X-Originating-IP: [36.24.144.104] X-CM-SenderInfo: 5zxmxtpq1xviiqq6il2tof0z/1tbisBfJemV4JBDeywABsp X-Mailman-Approved-At: Wed, 24 Apr 2024 16:18:26 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improve the robustness of setting thread affinity in DPDK by adding detailed error logging. Changes: 1. Check the return value of pthread_setaffinity_np() and log an error if the call fails. 2. Include the current thread name, the intended CPU set, and a detailed error message in the log. Sample prints: EAL: Cannot set affinity for thread dpdk-test with cpus 0, ret: 22, errno: 0, error description: Success EAL: Cannot set affinity for thread dpdk-worker1 with cpus 1, ret: 22, errno: 0, error description: Success Signed-off-by: Jianyue Wu --- lib/eal/common/eal_common_thread.c | 2 +- lib/eal/common/eal_thread.h | 2 +- lib/eal/unix/rte_thread.c | 22 ++++++++++++++++++++-- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c index a53bc639ae..31a2fab2a7 100644 --- a/lib/eal/common/eal_common_thread.c +++ b/lib/eal/common/eal_common_thread.c @@ -103,7 +103,7 @@ rte_thread_get_affinity(rte_cpuset_t *cpusetp) } int -eal_thread_dump_affinity(rte_cpuset_t *cpuset, char *str, unsigned int size) +eal_thread_dump_affinity(const rte_cpuset_t *cpuset, char *str, unsigned int size) { unsigned cpu; int ret; diff --git a/lib/eal/common/eal_thread.h b/lib/eal/common/eal_thread.h index 1c3c3442d3..85ab84baa5 100644 --- a/lib/eal/common/eal_thread.h +++ b/lib/eal/common/eal_thread.h @@ -50,7 +50,7 @@ unsigned eal_cpu_socket_id(unsigned cpu_id); * 0 for success, -1 if truncation happens. */ int -eal_thread_dump_affinity(rte_cpuset_t *cpuset, char *str, unsigned int size); +eal_thread_dump_affinity(const rte_cpuset_t *cpuset, char *str, unsigned int size); /** * Dump the current thread cpuset. diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index 1b4c73f58e..8f9eaf0dcf 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -369,8 +369,26 @@ int rte_thread_set_affinity_by_id(rte_thread_t thread_id, const rte_cpuset_t *cpuset) { - return pthread_setaffinity_np((pthread_t)thread_id.opaque_id, - sizeof(*cpuset), cpuset); + int ret; + char cpus_str[RTE_CPU_AFFINITY_STR_LEN] = {'\0'}; + char thread_name[RTE_MAX_THREAD_NAME_LEN] = {'\0'}; + + errno = 0; + ret = pthread_setaffinity_np((pthread_t)thread_id.opaque_id, + sizeof(*cpuset), cpuset); + if (ret != 0) { + if (pthread_getname_np((pthread_t)thread_id.opaque_id, + thread_name, sizeof(thread_name)) != 0) + EAL_LOG(ERR, "pthread_getname_np failed!"); + if (eal_thread_dump_affinity(cpuset, cpus_str, RTE_CPU_AFFINITY_STR_LEN) != 0) + EAL_LOG(ERR, "eal_thread_dump_affinity failed!"); + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, " + "ret: %d, errno: %d, error description: %s", + thread_name, cpus_str, + ret, errno, strerror(errno)); + } + + return ret; } int -- 2.34.1