From: Stephen Hemminger <stephen@networkplumber.org>
To: Jianyue Wu <wujianyue000@163.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal/linux: enhanced error handling for affinity
Date: Wed, 24 Apr 2024 08:50:21 -0700 [thread overview]
Message-ID: <20240424085021.11f2ff96@hermes.local> (raw)
In-Reply-To: <20240423030243.59895-1-wujianyue000@163.com>
On Tue, 23 Apr 2024 11:02:43 +0800
Jianyue Wu <wujianyue000@163.com> wrote:
> Improve the robustness of setting thread affinity in DPDK
> by adding detailed error logging.
Is this an error you saw in your application or something inside DPDK?
> Changes:
> 1. Check the return value of pthread_setaffinity_np() and log an error
> if the call fails.
Not sure this is necessary. The rte_thread functions are intended to
be os independent wrapper for threads. Does it need to be this chatty.
> 2. Include the current thread name, the intended CPU set, and a detailed
> error message in the log.
This introduces a more code and ends up being Linux/BSD specific only
for the case where application did something wrong.
next prev parent reply other threads:[~2024-04-24 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 3:02 Jianyue Wu
2024-04-24 15:50 ` Stephen Hemminger [this message]
2024-04-25 1:08 ` 吴剑跃
2024-04-25 5:40 ` 吴剑跃
2024-04-25 15:04 ` Stephen Hemminger
2024-04-26 3:14 ` Jianyue Wu
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 11:25 [dpdk-dev] Does memif support primary<->secondary process communication? Wu, Jianyue (NSB - CN/Hangzhou)
2021-06-09 12:07 ` Wu, Jianyue (NSB - CN/Hangzhou)
2024-04-22 13:23 ` [PATCH] eal/linux: enhanced error handling for affinity Jianyue Wu (NSB)
2024-04-22 13:49 ` Ferruh Yigit
2024-04-26 21:31 ` Patrick Robb
2024-04-22 13:50 ` Ferruh Yigit
2024-04-22 15:26 ` Stephen Hemminger
2024-04-22 15:27 ` Stephen Hemminger
2024-04-22 15:30 ` Stephen Hemminger
2024-04-23 3:01 ` Jianyue Wu (NSB)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424085021.11f2ff96@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wujianyue000@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).