From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F219343EF9; Wed, 24 Apr 2024 21:05:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA7A6435CE; Wed, 24 Apr 2024 21:05:42 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 84E4740689 for ; Wed, 24 Apr 2024 21:05:41 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1e411e339b8so1346025ad.3 for ; Wed, 24 Apr 2024 12:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713985541; x=1714590341; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t85HOfzS/h3BqVqnoOrY66yRPQPZQaXX6y8cI+WDK4k=; b=rzjRUSKbj8LHiU8qwCg1nB1Pmb3P7j3dgDnEKi5aJeIvZOoyuRNCfDhgMRftH1Ul9T Et6d8QN0rEJG5A2KKjpFwsWr4mxqG2CQ/RgBy1VvlULjl79F9e2vgd0mLhkyqpB9tyER 1GcSXSyG0l84ZhkFpvnX+zah90M7GQyQsv+yGN+5rl9M4tx2T0qcxSWNo2bW9Y2fA8l5 QEPtSvzz2edtXwLWtO3XTBVGvXy9sNbzB+RAz45TayFc16o+r9h9x5nISCzOByUZxm2k MCZKVZwcu2b7wkSrC3SnN4bXmnuPG2q42WC9d/yVuSLcdcvt/1tJtc7nlmo7EFvTL6eC rmtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713985541; x=1714590341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t85HOfzS/h3BqVqnoOrY66yRPQPZQaXX6y8cI+WDK4k=; b=LzIJTeObTFTlxoMVc+Pip1jUG0fgtGGdPiljlmTr8sQJku8zB3gjyvbUVcMejDX+fj KN1vTFxTu9nxCWUOqu3UZ9mc0/CZTos1dIiZ4u/CmgfJKrkzxQtwtLL+7Vt+5qYmOp64 EYrC6g8qNCBNTFd/gimMEZGV2ca1KYiH0wXOYX7vJSWgnP+19zTNYdA7IkV8VlEPnild aUYBwnv6/LRpXLqqiREwp0r3idQN+ssx2WyjQJQORI7mlvQtMXr8HUDnGglA9xDhQq/F TyuAknUWDMUK4wfPk63WM+ibELhNuZ6LBrawdPzNdrIftNFUTlWR3IQL+hnIogSLaNMk UpOQ== X-Forwarded-Encrypted: i=1; AJvYcCVCm5kdTnuvPge/r092jZLxpLmAZ8CoFrYXUhxCbNUJWT7cBjzIvGB0F0URCpymNKm2T4gyRZVRs/5qE1I= X-Gm-Message-State: AOJu0Yw0TWl7RROwQjRLTUEovYE38vPAmjN2AIWSnqzhjEtOneCp7VKT ltvXw5is0LyGvU31KzWWnFeEP0bbFUb1cgeAGgBAMgSFQoqGpaYERTKhocM0iZ17MxIb6sqr3Ve 2 X-Google-Smtp-Source: AGHT+IEWiq2BRH0lTcNmDHT98jOYkJFLtBM0iPofA+RShG3KqXMGWktAVjGaTycqRa4JJUjzEMgYCg== X-Received: by 2002:a17:903:1245:b0:1e8:c994:b55b with SMTP id u5-20020a170903124500b001e8c994b55bmr4450325plh.7.1713985540660; Wed, 24 Apr 2024 12:05:40 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id p2-20020a1709027ec200b001e2ba8605dfsm12444001plb.150.2024.04.24.12.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 12:05:40 -0700 (PDT) Date: Wed, 24 Apr 2024 12:05:38 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Ferruh Yigit" , Subject: Re: getting rid of type argument to rte_malloc(). Message-ID: <20240424120538.38ee8669@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3E3@smartserver.smartshare.dk> References: <20240423210847.542cff76@hermes.local> <6e2e5f6e-7ff0-404e-991b-836d496ad164@amd.com> <20240424092351.31878a12@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F3E3@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 24 Apr 2024 19:09:24 +0200 Morten Br=C3=B8rup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Wednesday, 24 April 2024 18.24 > >=20 > > On Wed, 24 Apr 2024 11:29:51 +0100 > > Ferruh Yigit wrote: > > =20 > > > On 4/24/2024 5:08 AM, Stephen Hemminger wrote: =20 > > > > For the 24.11 release, I want to remove the unused type string =20 > > argument =20 > > > > that shows up in rte_malloc() and related functions, then percolate= s =20 > > down =20 > > > > through. It was a idea in the 1.0 release of DPDK, never =20 > > implemented and =20 > > > > never removed. Yes it will cause API breakage, a large sweeping =20 > > change; =20 > > > > probably easily scripted with coccinelle. > > > > > > > > Maybe doing ABI version now? > > > > =20 > > > > > > Won't this impact many applications, is there big enough motivation to > > > force many DPDK applications to update their code, living with it =20 > > looks =20 > > > simpler. > > > =20 > >=20 > > Yeah, probably too big an impact but at least: > > - change the documentation to say "do not use" should be NULL > > - add script to remove all usage inside of DPDK > > - get rid of places where useless arg is passed around inside > > of the allocator internals. =20 >=20 > For the sake of discussion: > Do we want to get rid of the "name" parameter to the memzone allocation f= unctions too? It's somewhat weird that they differ. The name is used by memzone lookup for secondary process etc. >=20 > Or are rte_memzone allocations considered init and control path, while rt= e_malloc allocations are considered fast path? >=20 Not really.