From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FFD143F09; Thu, 25 Apr 2024 20:42:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B14E43943; Thu, 25 Apr 2024 20:42:51 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 5A4AB40A67 for ; Thu, 25 Apr 2024 20:42:49 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1e5c7d087e1so12334495ad.0 for ; Thu, 25 Apr 2024 11:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714070568; x=1714675368; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GpC5nnlfhfetRS2Z3HgnveWD4K3ZjozsWzvJS21QsCI=; b=UsS/Zt2TX+VAC7grcr4znTzto8JhytTWyhV9aQioftcm/Yn2KG9dcaSwBGfkbe6yWl 4/0CYkll16M3aY0Nd5/fg2wN8okzYA+WCDB3JmpqXzr+yhgJbDUn/XNGP77+3IKX+3wT LCGPG6xT2zLk1bOEyz96/LyRKONZ3bLVDweTO3MtailLaLVhTkWtYiZGnRwvwNQOdtgG EGNE5Sa+NPK33t/eagchnZHLmw3JWRarWPHU/YmkOtjrsu/4kXqpx/x9AjoCMqLfOXqO 50RrtGMw/JXhVLvD7zzbzIk8k9ce2rt362bqX6BD+p8c+ktn1z6siujx/q9y3woz0dEW +/wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714070568; x=1714675368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GpC5nnlfhfetRS2Z3HgnveWD4K3ZjozsWzvJS21QsCI=; b=bTGXgBifS1BzzJF9sRhMU98CfQ83DLpCBAqudLC8jLDGRY3/OGp9maUVjllZupMReJ cYcBh2czJm9QdCm8jJoL6QJVqdqYdoiLJgcF3bW2vuW4BV+2uJD8a6J8PUOub3cD8MHg kyCSAe8rnBb1OcGZYHipIXd/ia6bmL5dbiE7oRVXLXePyAeO7kXQZ7c0tSTSIgt1thu8 5Lp2x5WUg8gaNo6ecXMOjkfFnXfCb14LlvEvNKxEERNfwEiGu0bO2oy0cm1KO5Nt8Mw3 9UEipXKY+vI8aeNvmEcKxoDAvQLcwlgsnJNKAmNyyRsLWAfxLA2GgmnEIUfkxnncMV/y bcmQ== X-Gm-Message-State: AOJu0YwAMlfqQjGgXgoxQQC3Zii9vclkOf2JjAVP4XlosNrrITTUI0f9 0t7a+U7v99b8jopxarkCa1P1Mi4+kDqhCuenNRIhpQC5U62d0BsYPH9b8sBkJns= X-Google-Smtp-Source: AGHT+IFtKjh2JkutEtFyDuMZImWFoSC8XeoDjHfNqe86jHammrswDVfGbW+uMDI5cFJZE9m6Po/lZw== X-Received: by 2002:a17:902:b695:b0:1e2:3d05:5f4c with SMTP id c21-20020a170902b69500b001e23d055f4cmr358151pls.39.1714070568474; Thu, 25 Apr 2024 11:42:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id s15-20020a170902ea0f00b001ddc83fda95sm14104854plg.186.2024.04.25.11.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 11:42:48 -0700 (PDT) Date: Thu, 25 Apr 2024 11:42:46 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org Subject: Re: [RFC 1/4] rte_malloc: document that type is unused Message-ID: <20240425114246.3899aa80@hermes.local> In-Reply-To: <20240425183131.GA9356@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20240425182738.4771-1-stephen@networkplumber.org> <20240425182738.4771-2-stephen@networkplumber.org> <20240425183131.GA9356@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 25 Apr 2024 11:31:31 -0700 Tyler Retzlaff wrote: > On Thu, Apr 25, 2024 at 11:23:58AM -0700, Stephen Hemminger wrote: > > The string type is left over from first version of DPDK and > > was never implemented. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/eal/include/rte_malloc.h | 21 +++++++-------------- > > 1 file changed, 7 insertions(+), 14 deletions(-) > > > > diff --git a/lib/eal/include/rte_malloc.h b/lib/eal/include/rte_malloc.h > > index 54a8ac211e..91c9214c57 100644 > > --- a/lib/eal/include/rte_malloc.h > > +++ b/lib/eal/include/rte_malloc.h > > @@ -37,8 +37,7 @@ struct rte_malloc_socket_stats { > > * NUMA socket as the core that calls this function. > > * > > * @param type > > - * A string identifying the type of allocated objects (useful for debug > > - * purposes, such as identifying the cause of a memory leak). Can be NULL. > > + * Legacy argument, never unused should be NULL. > > never unused seems unintended double negative. > > should it be 'unused' or 'never used' thanks