From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [RFC 2/4] devtools/cocci: add script to find unnecessary malloc type
Date: Thu, 25 Apr 2024 11:23:59 -0700 [thread overview]
Message-ID: <20240425182738.4771-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20240425182738.4771-1-stephen@networkplumber.org>
The malloc type argument is unused and should be NULL.
This script finds and fixes those places.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
devtools/cocci/malloc-type.cocci | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 devtools/cocci/malloc-type.cocci
diff --git a/devtools/cocci/malloc-type.cocci b/devtools/cocci/malloc-type.cocci
new file mode 100644
index 0000000000..d1101927e0
--- /dev/null
+++ b/devtools/cocci/malloc-type.cocci
@@ -0,0 +1,27 @@
+//
+// The allocation name field in malloc routines was never
+// implemented and should be NULL
+//
+@@
+expression T != NULL;
+expression num, socket, size, align;
+@@
+(
+- rte_malloc(T, size, align)
++ rte_malloc(NULL, size, align)
+|
+- rte_zmalloc(T, size, align)
++ rte_zmalloc(NULL, size, align)
+|
+- rte_calloc(T, num, size, align)
++ rte_calloc(NULL, num, size, align)
+|
+- rte_malloc_socket(T, size, align, socket)
++ rte_malloc_socket(NULL, size, align, socket)
+|
+- rte_zmalloc_socket(T, size, align, socket)
++ rte_zmalloc_socket(NULL, size, align, socket)
+|
+- rte_calloc_socket(T, num, size, align, socket)
++ rte_calloc_socket(NULL, num, size, align, socket)
+)
--
2.43.0
next prev parent reply other threads:[~2024-04-25 18:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:23 [RFC 0/4] malloc type argument cleanup (part 1) Stephen Hemminger
2024-04-25 18:23 ` [RFC 1/4] rte_malloc: document that type is unused Stephen Hemminger
2024-04-25 18:31 ` Tyler Retzlaff
2024-04-25 18:42 ` Stephen Hemminger
2024-04-25 18:23 ` Stephen Hemminger [this message]
2024-04-25 18:24 ` [RFC 3/4] devtools/cocci: add script to find where rte_calloc should be used Stephen Hemminger
2024-04-25 18:24 ` [RFC 4/4] eal/malloc: remove type argument from internal malloc routines Stephen Hemminger
2024-04-26 16:16 ` Tyler Retzlaff
2024-04-26 22:52 ` Stephen Hemminger
2024-04-26 23:06 ` Tyler Retzlaff
2024-05-07 7:04 ` Morten Brørup
2024-04-26 21:32 ` [RFC 0/4] malloc type argument cleanup (part 1) Patrick Robb
2024-06-15 16:00 ` [PATCH v2 0/3] malloc related cleanups Stephen Hemminger
2024-06-15 16:00 ` [PATCH v2 1/3] rte_malloc: document that type is for tracing Stephen Hemminger
2024-06-15 16:00 ` [PATCH v2 2/3] eal: remove type argument from internal routines Stephen Hemminger
2024-06-15 16:00 ` [PATCH v2 3/3] event/sw: avoid snprintf truncation Stephen Hemminger
2024-06-15 21:40 ` [PATCH v2 0/3] malloc related cleanups Morten Brørup
2024-06-17 17:48 ` Patrick Robb
2024-06-18 14:44 ` [PATCH v3 0/2] malloc type cleanups Stephen Hemminger
2024-06-18 14:44 ` [PATCH v3 1/2] rte_malloc: document that type is for tracing Stephen Hemminger
2024-06-18 14:44 ` [PATCH v3 2/2] eal: remove type argument from internal routines Stephen Hemminger
2024-07-05 14:09 ` [PATCH v3 0/2] malloc type cleanups David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425182738.4771-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).