From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29C4743F19; Fri, 26 Apr 2024 17:47:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F24A43EC8; Fri, 26 Apr 2024 17:47:40 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0391D43D7A for ; Fri, 26 Apr 2024 17:47:38 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 459D3210EF25; Fri, 26 Apr 2024 08:47:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 459D3210EF25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1714146457; bh=EuH/fjE2fvVgNhJ6DGFDCpqIJSVCL+GxmTiQkg6KABw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Et4QEttjh9hRgKsIhY0jhgAJM3vkEqHIFNE6b6/96x4KTI3duXXGBAl99uqDn+5Gn YYqzWV/ZzyCoNb+onHkXxkZ1N5aNDC+6PHK7Z4bg7HQA7ipE+cAR9YLEyzAMPCQSHk KPNGJTrQVvRPgEaV18JeKTlPO7V6qIS6YnqumrTI= Date: Fri, 26 Apr 2024 08:47:37 -0700 From: Tyler Retzlaff To: Jianyue Wu Cc: stephen@networkplumber.org, ferruh.yigit@amd.com, dev@dpdk.org, Jianyue Wu Subject: Re: [PATCH v2] eal/linux: enhanced error handling for affinity Message-ID: <20240426154737.GB27008@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20240425111130.8306-1-wujianyue000@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425111130.8306-1-wujianyue000@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 25, 2024 at 07:11:30PM +0800, Jianyue Wu wrote: > From: Jianyue Wu > > Improve the robustness of setting thread affinity in DPDK > by adding detailed error logging. > > Changes: > 1. Check the return value of pthread_setaffinity_np() and log an error > if the call fails. > 2. Include the current thread name, the intended CPU set, and a detailed > error message in the log. > > Sample prints: > EAL: Cannot set affinity for thread dpdk-test with cpus 0, > ret: 22, errno: 0, error description: Success > EAL: Cannot set affinity for thread dpdk-worker1 with cpus 1, > ret: 22, errno: 0, error description: Success > > Signed-off-by: Jianyue Wu > --- > lib/eal/common/eal_common_thread.c | 2 +- > lib/eal/common/eal_thread.h | 2 +- > lib/eal/unix/rte_thread.c | 27 +++++++++++++++++++++++++-- > 3 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c > index a53bc639ae..31a2fab2a7 100644 > --- a/lib/eal/common/eal_common_thread.c > +++ b/lib/eal/common/eal_common_thread.c > @@ -103,7 +103,7 @@ rte_thread_get_affinity(rte_cpuset_t *cpusetp) > } > > int > -eal_thread_dump_affinity(rte_cpuset_t *cpuset, char *str, unsigned int size) > +eal_thread_dump_affinity(const rte_cpuset_t *cpuset, char *str, unsigned int size) > { > unsigned cpu; > int ret; > diff --git a/lib/eal/common/eal_thread.h b/lib/eal/common/eal_thread.h > index 1c3c3442d3..85ab84baa5 100644 > --- a/lib/eal/common/eal_thread.h > +++ b/lib/eal/common/eal_thread.h > @@ -50,7 +50,7 @@ unsigned eal_cpu_socket_id(unsigned cpu_id); > * 0 for success, -1 if truncation happens. > */ > int > -eal_thread_dump_affinity(rte_cpuset_t *cpuset, char *str, unsigned int size); > +eal_thread_dump_affinity(const rte_cpuset_t *cpuset, char *str, unsigned int size); no objection to adding const > > /** > * Dump the current thread cpuset. > diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c > index 1b4c73f58e..34ac0eabbf 100644 > --- a/lib/eal/unix/rte_thread.c > +++ b/lib/eal/unix/rte_thread.c > @@ -369,8 +369,31 @@ int > rte_thread_set_affinity_by_id(rte_thread_t thread_id, > const rte_cpuset_t *cpuset) > { > - return pthread_setaffinity_np((pthread_t)thread_id.opaque_id, > - sizeof(*cpuset), cpuset); > + int ret; > +#if defined(__linux__) && defined(_GNU_SOURCE) > + char cpus_str[RTE_CPU_AFFINITY_STR_LEN] = {'\0'}; > + char thread_name[RTE_MAX_THREAD_NAME_LEN] = {'\0'}; > + errno = 0; > +#endif > + > + ret = pthread_setaffinity_np((pthread_t)thread_id.opaque_id, > + sizeof(*cpuset), cpuset); > + > +#if defined(__linux__) && defined(_GNU_SOURCE) > + if (ret != 0) { > + if (pthread_getname_np((pthread_t)thread_id.opaque_id, > + thread_name, sizeof(thread_name)) != 0) > + EAL_LOG(ERR, "pthread_getname_np failed!"); > + if (eal_thread_dump_affinity(cpuset, cpus_str, RTE_CPU_AFFINITY_STR_LEN) != 0) > + EAL_LOG(ERR, "eal_thread_dump_affinity failed!"); > + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, " > + "ret: %d, errno: %d, error description: %s", > + thread_name, cpus_str, > + ret, errno, strerror(errno)); > + } > +#endif > + > + return ret; > } > > int > -- i do not think introducing os specific behavior/logging to the EAL is a good idea. logging although not formally part of the api surface should present the same experience for all platforms. the EAL should have a higher standard here. > 2.34.1