From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3ED8143F19;
Fri, 26 Apr 2024 17:51:51 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7C5F943EF8;
Fri, 26 Apr 2024 17:51:41 +0200 (CEST)
Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com
[209.85.215.172])
by mails.dpdk.org (Postfix) with ESMTP id D9A8443F00
for <dev@dpdk.org>; Fri, 26 Apr 2024 17:51:37 +0200 (CEST)
Received: by mail-pg1-f172.google.com with SMTP id
41be03b00d2f7-53fbf2c42bfso1584904a12.3
for <dev@dpdk.org>; Fri, 26 Apr 2024 08:51:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714146697;
x=1714751497; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;
b=deEXkABRAw1K+Ajx33RM2pbdxmfcuEkeDYQn6CLFbPMVq8Tf2UJRfxyC1JYkadS2A7
LpPYzhqjM2xt4tUivS3tmgDadixzZwkh0j5Nb3X+ol1rqI5DtGLyIHDJbbiTaTmNtjfE
91B7tKDK+tICaGkSWq6cQB43F5i3W7zdAOrzvkL6JbVoTDMRXcrFdk53iGCMf61ZW/hG
kpPj/UZlgqhOWKIVcPDM6VxT7h8WQCW2PfTUImZEiyaS8fINVIwPpnzxKAdbXXxH17cg
O3+xPBJNBqCpC6SADH/avPrTlr97ohSxN0VEEy1EV7qIUmTUeHrjsPVDMPsjMrnIwp8h
1ifw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1714146697; x=1714751497;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;
b=ISTUXmrCesZQroEJ0LmbxcwQjTEscOfJf9nwo5Sia3fbZs1GYlm6o8qVtWiINpaiBc
safmcQe3Y+I/+UkHxolyTZ3Z/qnIp77F6ERUIxScQtvfj/p5QSrBqpsRNF9XkmseShx/
bbfu+0crigyEepOQXiAIf1bg4BHOzJISsJ8v5PF9hTW3pUdPMzyuVnZffE25yLgFNOyf
m7IyaUoA5jvepGGGRFFOt+bZE/lAEgmmOBZZrLrIkadDLxkDrAWvfwQRP7Pae/Q5yEzd
Y73BtQkqadlNJej5VPzrcn9RvLVc34gnmAgxFGjJPiw9cu/RVCoMsI/K/SIqIlLez+jJ
hK2Q==
X-Gm-Message-State: AOJu0YxGT6WEmOwnYWgHSceacMxfChZAo7RWdZE3SJsSavfSoia1Dx0o
/ExSpMhaGau+oJu3Bo3Mf/Z87KzpWsYuGo7diT09EUhp+nRvSoNmRziBwhkoiCrEh8SeJ6v98Cq
zjQs=
X-Google-Smtp-Source: AGHT+IHa8edXuW47WAdtjqKRo3Dv3U9BXOcMrvMct2DGwRYzyLdLkJc7e46qY3jjx/+4kqNgkdDtZw==
X-Received: by 2002:a17:90a:bc89:b0:2a2:7a00:f101 with SMTP id
x9-20020a17090abc8900b002a27a00f101mr3013338pjr.47.1714146697034;
Fri, 26 Apr 2024 08:51:37 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
ns5-20020a17090b250500b002a5f44353d2sm16770978pjb.7.2024.04.26.08.51.35
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 26 Apr 2024 08:51:35 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v9 2/9] net/tap: remove unused fields
Date: Fri, 26 Apr 2024 08:48:52 -0700
Message-ID: <20240426155125.125910-3-stephen@networkplumber.org>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20240426155125.125910-1-stephen@networkplumber.org>
References: <20240130034925.44869-1-stephen@networkplumber.org>
<20240426155125.125910-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The driver doesn't support these other hash types, and there
is no reason to implement these in future. The rss_flows list
was set but never used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.h | 4 +---
drivers/net/tap/tap_flow.c | 1 -
drivers/net/tap/tap_rss.h | 6 ------
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h
index dc8201020b..1bcf92ce80 100644
--- a/drivers/net/tap/rte_eth_tap.h
+++ b/drivers/net/tap/rte_eth_tap.h
@@ -77,14 +77,12 @@ struct pmd_internals {
int ioctl_sock; /* socket for ioctl calls */
int nlsk_fd; /* Netlink socket fd */
int flow_isolate; /* 1 if flow isolation is enabled */
- int flower_support; /* 1 if kernel supports, else 0 */
- int flower_vlan_support; /* 1 if kernel supports, else 0 */
int rss_enabled; /* 1 if RSS is enabled, else 0 */
int persist; /* 1 if keep link up, else 0 */
/* implicit rules set when RSS is enabled */
int map_fd; /* BPF RSS map fd */
int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */
- LIST_HEAD(tap_rss_flows, rte_flow) rss_flows;
+
LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */
/* implicit rte_flow rules set when a remote device is active */
LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows;
diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index a78fd50cd4..8fccd599f0 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd,
errno, strerror(errno));
return err;
}
- LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next);
}
pmd->rss_enabled = 1;
diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h
index dff46a012f..8766ffc244 100644
--- a/drivers/net/tap/tap_rss.h
+++ b/drivers/net/tap/tap_rss.h
@@ -21,12 +21,6 @@ enum hash_field {
HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */
HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */
HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */
- HASH_FIELD_L2_SRC, /* Ethernet src addr */
- HASH_FIELD_L2_DST, /* Ethernet dst addr */
- HASH_FIELD_L3_SRC, /* L3 src addr */
- HASH_FIELD_L3_DST, /* L3 dst addr */
- HASH_FIELD_L4_SRC, /* TCP/UDP src ports */
- HASH_FIELD_L4_DST, /* TCP/UDP dst ports */
};
struct rss_key {
--
2.43.0