From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BFACF43F1F;
Sat, 27 Apr 2024 01:06:27 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8BC5F440AD;
Sat, 27 Apr 2024 01:06:27 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 198F24406D
for <dev@dpdk.org>; Sat, 27 Apr 2024 01:06:26 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 51848210EF33; Fri, 26 Apr 2024 16:06:25 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 51848210EF33
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1714172785;
bh=X5PYZ2paL3CSl3UlPFFmcxSZd2ZmwKEAhEP+Xn6SzEA=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=BNOB0oyxqYNBVlpUr4Z3+10BiooNIlh8J6DbzvUqkBpZoxxYce2hwQRJSf/u5NrZO
lMIcBOuw8jNEgICIDgtnQUe3qozispV34zxk3+qXMElpiY01kU+GMahNSIcrQp4HUt
GbJKcZ3UuEYRrc9/SFLzwpn08qq2hmotPX1VtWwM=
Date: Fri, 26 Apr 2024 16:06:25 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [RFC 4/4] eal/malloc: remove type argument from internal malloc
routines
Message-ID: <20240426230625.GA24210@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240425182738.4771-1-stephen@networkplumber.org>
<20240425182738.4771-5-stephen@networkplumber.org>
<20240426161627.GA29409@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
<20240426155229.68bfc50f@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426155229.68bfc50f@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Fri, Apr 26, 2024 at 03:52:29PM -0700, Stephen Hemminger wrote:
> On Fri, 26 Apr 2024 09:16:27 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > >
> > > diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c
> > > index 32e6b78f87..2d9b6aa3e3 100644
> > > --- a/lib/eal/common/eal_common_memzone.c
> > > +++ b/lib/eal/common/eal_common_memzone.c
> > > @@ -191,14 +191,12 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
> > > if (len == 0 && bound == 0) {
> > > /* no size constraints were placed, so use malloc elem len */
> > > requested_len = 0;
> > > - mz_addr = malloc_heap_alloc_biggest(NULL, socket_id, flags,
> > > - align, contig);
> > > + mz_addr = malloc_heap_alloc_biggest(socket_id, flags, align, contig);
> >
> > i may have missed if this was discussed already. for the public api i
> > understand for now we need to keep the unused parameter in the function
> > signatures but for internal api/functions i would prefer the parameter
> > be removed entirely.
> >
> > also somewhat related side-note i don't think msvc has a way of marking
> > function parameters unused as is done with __rte_unused. currently i
> > expand the macro empty and suppress the warning globally which is not
> > great.
>
> I dropped the parameter from all the internal routines. Are you suggesting having
> an different name/version for use internally?
oh, it looks like i can't read a diff.
ignore me! thanks!