From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C942143F49; Mon, 29 Apr 2024 12:02:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8BE74068E; Mon, 29 Apr 2024 12:02:16 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by mails.dpdk.org (Postfix) with ESMTP id 0C5FE402E2 for ; Mon, 29 Apr 2024 12:02:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdCmmUvaml82Jz/0db2j5taZ3j2O144gkKI9j494kxYaCMzgpMK5ZX8TNuTOPybyVKnTnzGbWdVmw2efOOc26UI+VaM2RlpMx6NjyVHvVBaz5TnYF+rPS+qWS5NFpYbTnm+ABIOOwXmnCrm+Bp+GN3zfjIduvtXCWVMq8tLRvh6Wp+wlEskn9OOEV08SEfbRdeDmHEhf+00pYOlsaUS5H/cfkkw34Sn2TAa7rXW7BK4bx4ygNRNC0PgzF5wjF1XCoIYsP2hd0mcCma76ctWwo2b84K+q/yCzxShmXvGHqfFhOUrIEdUsjq1qDAcYe+BfJLDT61UkhoHSEoBHczewKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ueO3Ej3/KMfbWMgaMmO+YPDAHVans1oaNOuz37SP1U=; b=CLjDoS6TTy1W0mwnAd9IIS3RsBuEvCYDTFeFoPG83WqxmJ+abI4IM/GBgjnNnWKvbPCcSvfi8HybRuz7+BE9h+S9EeSz3oGCf/gZAndzS/DEZcgIjdQKBxWt7fy45wTfQX2wNGtmWoxuMWOD86SvalcvyaCJoF0DVNXopF8P+2lUelqiXy+rVDBknPXf+7Rxv7M6GDnh1EhCI3gP5lA4ekEnqcUPOqdM1uqavoWU85+vkIYG3//+YbnciHdhBM9njYxYh0zD4T6W0b/XdIGPY5qwz0KNy7EDfmbMQZ3i8hG0QxRdba7URWEEU/OmSzL/sCzsaMmWUIQ9cAaA1Vn8kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ueO3Ej3/KMfbWMgaMmO+YPDAHVans1oaNOuz37SP1U=; b=yAkr9kri6YV9NVW9iVkJUYrhGNp/FnFiGeI+MMZ/mouxX8xc9u0SSsBOpjzYfnbCBRWlW08MJXyjegjSCnZ1GhtAlraPFB+qAK4En2TPUAEmHJFm9NoaJIQIXMSjTQw//m8sso/DyzsNNXtMkheXRE1IOtPSvL9m5OGZLkmTrqsgKPtHLrwrElEn3Forsk3nI9B87923jv7nJCKlhR1iqELndgGXqfAM+BvK3jVRUdi5RNzbc2aaI0HPk33fT++lNB5hWms/MJOjmW1TSwCO/ECv3xV88caJMv2qF/59p3BlYiuArW8xNgzuswbSGVeD1UCMiQjULReB7n0l55RmeQ== Received: from AM0PR10CA0059.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::39) by PA4PR07MB8392.eurprd07.prod.outlook.com (2603:10a6:102:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Mon, 29 Apr 2024 10:02:10 +0000 Received: from AM4PEPF00025F98.EURPRD83.prod.outlook.com (2603:10a6:20b:150:cafe::3) by AM0PR10CA0059.outlook.office365.com (2603:10a6:20b:150::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.28 via Frontend Transport; Mon, 29 Apr 2024 10:02:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM4PEPF00025F98.mail.protection.outlook.com (10.167.16.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.0 via Frontend Transport; Mon, 29 Apr 2024 10:02:09 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server id 15.2.1258.12; Mon, 29 Apr 2024 12:02:09 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 7162A1C006D; Mon, 29 Apr 2024 12:02:09 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [RFC v3 6/6] eal: add unit tests for atomic bit access functions Date: Mon, 29 Apr 2024 11:51:38 +0200 Message-ID: <20240429095138.106849-7-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240429095138.106849-1-mattias.ronnblom@ericsson.com> References: <20240425085853.97888-2-mattias.ronnblom@ericsson.com> <20240429095138.106849-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00025F98:EE_|PA4PR07MB8392:EE_ X-MS-Office365-Filtering-Correlation-Id: ebdd7eaf-3b3a-4b49-18d6-08dc68336f46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|82310400014|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WC92MWh2ajVlY1dGU1p2cG1tYUdBK056b3M0UU9xeFQ3czcwV2V2ODdDblhC?= =?utf-8?B?L3NKOXV0eElnbTBTeHhtaGg5U2tqSmVET2I0K0RHWW80dDBkVTUwYzlLYVl5?= =?utf-8?B?eXpnemJQMld2Mnpwa0xNalFCcG5qN3c5UXZJbWw5Zmw2bTJEeGRjZGtCWk9B?= =?utf-8?B?ZlZKcTNCYmN6Zkh5WHRHdk1WZzB0a29RWmlYaWtLcFlvdGtJc2E5Qk54aGla?= =?utf-8?B?QzBUb0NxaXZaN2FJazUybTlTRE9yTCtFRXQrUHhnQUp4djR2a05XdzZUUFp4?= =?utf-8?B?a1ZuZVdEdngzWkZJZ3lEN3pEQ2wxTU5kUHRwT0VLZ2hWc1YwK2M4ZGNRMGRx?= =?utf-8?B?dEU2bVNGTGJ3NVBGUk1aczErMHdURTdqdGlYQVc1ZHpvNjVPTXlJYUFKZkRX?= =?utf-8?B?N0xZcmlaT1l3YXhacTg2cEF5U1REMkRORWRRU09KNHpqM0JZM0RGYWpKNXdj?= =?utf-8?B?aCtVNFBZR0lBOERXZXNrSDZvUDRVak1jT3Q1SC9jUDB2eWNiNU53TUo4Qlkx?= =?utf-8?B?TXczYlFTUGlHR2hBUzZYdkhRZFpXd3dKWFgrb25aTmx2ZXZYTlFjeEl1YWdC?= =?utf-8?B?ZnBxV1RWY2ZmOTM4SUdwSFJ3MzdralpVTEpEaVB1MzE1d2RHM2JCclNsRWtz?= =?utf-8?B?M0UxeU9MZjljenZodWFGeTROSGxRbTVldDNXWm1NZUNtRTNTVGlCQXpDZWVo?= =?utf-8?B?YklXNHF6NSsyUEs2ZTRTTklxRjdkZmUwTEtqV2F0SS9WZ2lqRHIvZmJnUzV1?= =?utf-8?B?cE5LQmVzY2pNRCtKNi9sNjJ4UVZucjZ1Q29Yd3Vtb1BnT3BaYjJrQW56Qyt5?= =?utf-8?B?Q1d5bXBSV0NNWE9wcW1uQ042enFRYW42MDREaTFiWUwxdmlKc2dzSXZ5NXZG?= =?utf-8?B?S1Bzek9wcVozQjIveFR5SndnVm9qdHBBTHduSm1jckVFLzJVNVRQMEZwZkxq?= =?utf-8?B?L25haXNtMUlxNHhVR3NvZURTRTRMK3p1cW11Z3FyM3R5VFN0REhOYmF6Ui9L?= =?utf-8?B?SEJZV1J3MUlmZUtwMEtpRngzRlMxcVVjenE3dTJyM01vcnkrUEtKQ2ZaY1Z3?= =?utf-8?B?ZklHdzcyRGY3YUwyZmh0NHZTOEdDQmNjalVHNldNbENPR2NldW9mSVMvZVZU?= =?utf-8?B?a2h4L1VLT0NGVkNYWFQ4Yll0UUF1eU5DOCtLWGRZQkZkeCswVlVwVEtTK3dz?= =?utf-8?B?NkI5ZDhneDhaNWxwaGxOTE5uVEhsWjBxTzFDajBHbUpJV0FhOWpUQmY4Umpn?= =?utf-8?B?dHJCcFBzRzlQQ2JCOGRmK3Mzc0hiK1p2SDJmeXVhLy92cDdjeXRJWXRCMDhS?= =?utf-8?B?RWNYUzQxRSt6azhyY3FBL0t6eExHaHZLNzBuRnpMMzFSOTEwTVlneXVqZ3ho?= =?utf-8?B?bUVKYmJvcTRRQ29pZ3IySE5JWUNudW9jK2hTeHNsQUpFZlZnd3hlbGZXN2hH?= =?utf-8?B?U3B0Vlg0cXlpUEI0ZEVNVTM3V0pRS3dTWjArMmw0RE80eWxXcGloR2lJWVQ2?= =?utf-8?B?TS9mejZDSG5OSmYvT1JsVE5QcGQ1YWN3bisybzFOaFF5VU9CUkdmdnR6QnhW?= =?utf-8?B?TWlIYVVURTAzdnR0Yy9nQzdoVWRWeU9YYkNQTHkwbTBPQlFaVUxBMnc4NVpq?= =?utf-8?B?QzRBZEtDdEk5RFNqNCtjRDhlRTdxSkxiRWJYU0Zua3dHbFRKMkZ6ZS9TNEhi?= =?utf-8?B?SXpuUVJNM1NHcVEyK2ZsTk1mM1hjMjF2UEZKMUppNWRLc1NtUGJaMTFFcU5n?= =?utf-8?B?QkhQVVZPOWEwWWhjaUlhN1Q5VGh5NmFkMGo1ZFpPRHlQc0xnVmlGTkFwTStI?= =?utf-8?B?Z2xOS3l4WHNrTDJlNkg0RVR5enh4YlRCL3N0cS9nRFhCelhFZ09QWGFXMzFT?= =?utf-8?Q?8LJkbSRyP2qlo?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 10:02:09.8784 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebdd7eaf-3b3a-4b49-18d6-08dc68336f46 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F98.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR07MB8392 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_[set|clear|assign|test|test_and_[set|clear|assign]]() family of functions. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom --- app/test/test_bitops.c | 233 ++++++++++++++++++++++++++++++++++- lib/eal/include/rte_bitops.h | 1 - 2 files changed, 232 insertions(+), 2 deletions(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 12c1027e36..d77793dfe8 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -60,6 +63,228 @@ GEN_TEST_BIT_ACCESS(test_bit_once_access_64, rte_bit_once_set, \ rte_bit_once_clear, rte_bit_once_assign, \ rte_bit_once_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access_32, bit_atomic_set, \ + bit_atomic_clear, bit_atomic_assign, \ + bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access_64, bit_atomic_set, \ + bit_atomic_clear, bit_atomic_assign, \ + bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore_ ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign_ ## size(void *arg) \ + { \ + struct parallel_access_lcore_ ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign_ ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore_ ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore_ ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign_ ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign_ ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore_ ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify_ ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore_ ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify_ ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore_ ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore_ ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify_ ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify_ ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + static uint32_t val32; static uint64_t val64; @@ -178,6 +403,12 @@ static struct unit_test_suite test_suite = { TEST_CASE(test_bit_access_64), TEST_CASE(test_bit_once_access_32), TEST_CASE(test_bit_once_access_64), + TEST_CASE(test_bit_atomic_access_32), + TEST_CASE(test_bit_atomic_access_64), + TEST_CASE(test_bit_atomic_parallel_assign_32), + TEST_CASE(test_bit_atomic_parallel_assign_64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify_32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify_64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index 2af5355a8a..5717691e7c 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -485,7 +485,6 @@ extern "C" { uint32_t *: __rte_bit_atomic_test_and_clear32, \ uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \ memory_order) - /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. -- 2.34.1