From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D6F5D43F32;
	Tue, 30 Apr 2024 20:01:12 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6D3E240262;
	Tue, 30 Apr 2024 20:01:12 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A83C24025C
 for <dev@dpdk.org>; Tue, 30 Apr 2024 20:01:10 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 0029021112E0; Tue, 30 Apr 2024 11:01:09 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0029021112E0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1714500070;
 bh=eLVsh4mt9JEB0335BnqtcJcQpJ8N3GKb8/qIzrzWqpw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=pUpD5+FfRpKUxxO+4q7M4VNG7i7iXEakZdE3jp64wyYBsKir2qvldQg6KpJ1znbCf
 5GIn3AUM2/8nxf35KzZw5mKiMvWK/b5JLWHh6TUtOfJXF3u22sgegiMnPVoa/qztZQ
 NzEDLsJLkn6w+VVF5kpWsUKQX2v895nBLdgTy0Dc=
Date: Tue, 30 Apr 2024 11:01:09 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: Mattias =?iso-8859-1?Q?R=F6nnblom?= <hofors@lysator.liu.se>,
 "dev@dpdk.org" <dev@dpdk.org>,
 Mattias =?iso-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: Run unit tests with C++ too
Message-ID: <20240430180109.GA18251@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <4d5510d1-bdc6-43de-abbc-749eaa3c75a4@lysator.liu.se>
 <CAJvnSUDwS8TpOKhnmKZKwsdyDDGw=K4rK_61QZEuUgjYdNAUTw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJvnSUDwS8TpOKhnmKZKwsdyDDGw=K4rK_61QZEuUgjYdNAUTw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Apr 30, 2024 at 09:52:05AM -0400, Patrick Robb wrote:
> On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom <hofors@lysator.liu.se>
> wrote:
> 
> > It would be great if the unit test suite (app/test/*) was compiled (and
> > run) using a C++ (C++11) compiler as well. At least, if such is available.
> >
> 
> Sure, the UNH Lab can try this.
> 
> 
> >
> > With the current state of affairs, header file macros or functions are
> > not verified to be functional (or even valid) C++.
> >
> > "C is a subset of C++", which was never true, is becoming less and less so.
> >
> > If all unit tests aren't valid C++, maybe one could start with an "opt
> > in" model.
> >
> 
> Okay, so basically run the fast-test suite, record all that don't pass,
> submit a bugzilla ticket stating which unit tests are not valid on a
> certain c++ compiler, then bring CI Testing online using the valid subset
> of fast-tests. This should work.

this seems like a reasonable approach.

> 
> 
> >
> > A drawback of this is that the unit tests need to be both valid C and
> > valid C++.
> >