From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EEE343F61; Wed, 1 May 2024 17:41:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E2E8402A7; Wed, 1 May 2024 17:41:44 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id D05F84021E for ; Wed, 1 May 2024 17:41:42 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6ed2170d89fso624381b3a.1 for ; Wed, 01 May 2024 08:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714578102; x=1715182902; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8GC6a43baz7Qrjp7RJv7j42NdRuJoNgJby+AnAjdvOs=; b=UzJ3n93QpK2ecKXSPv+gPz844HMu9Q598O81R+LtOcy2/b9QC0ypDdA0lysqs6Fp9U LHA1UKlcyWcfUIDH9pa2UQPSIJM31K4SnbV6MVGjfj08D1CEk6yzodJjPM0fYamuoH7e 5Qme0VBMPExuux9KZBuUxsv2bleaUTqIHKxU3cb6EV5StXbIZvCohw98HtcxgYAB0eFf hXkIFNMCkeIlP60+bXCPWEcMUFIKRPwrk4sQsD9VJmDXQqmHa1rjdc0h0PPdNbCQLVk0 EbWyok9bVlp1saqAHXbDh2m+2EgAwybR2c5YqVw1d7Pz0hB8ZIKPMWByT8ybLAKlK5S7 Ffkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714578102; x=1715182902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8GC6a43baz7Qrjp7RJv7j42NdRuJoNgJby+AnAjdvOs=; b=o3KuxRHuCzFGgejrmY0p0jRPgUKqm7fO8v8+FhnQEA1ET9v66UC8T/odbXUR5rz6Kh HMfQCkxPfCrC16PeZjRzZgUXYH0dQHj6n69L6oUm/Bu/lNiAGApBV315LO5p0+L4TFNU RnCkYaX9jD3pM9Pd8mVjV+Abc32JkdkYqFD/490po5xwDeEi9WrSh0LmKpEcLcjIIZ9W 7TWttQgpUGQoMiIPDbrPCEnKebqjY7WdtttaEqn//d9dqlJNfsfyeuOnVAm/qa/Vru5X dzBmr8K1lb5lhrFFtk8iEEIZprkBU8zl12a1n+I2sM6Zfm3XH0vxJJi+DueUAjeAU0kd JCxg== X-Gm-Message-State: AOJu0YzJi+SIA6KLknWarmxAPsooX9IRz3JCiO9jchyjb168hOMoI6Z3 IbtSji/Cpa7cppfPXdZsBlzfwtsmeFPkrwmNI8JPsO96MdllIR0cTmdCS4wXu8w= X-Google-Smtp-Source: AGHT+IH6RwMdPUqrnO41sQmOXEX5Ysr2TpUoygKcU/HOxhN9lNPRBt5rnmyo31zxwm9E7a4ZVA5ANQ== X-Received: by 2002:a05:6a20:96d2:b0:1a7:9ed1:fc21 with SMTP id hq18-20020a056a2096d200b001a79ed1fc21mr29043pzc.22.1714578101620; Wed, 01 May 2024 08:41:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id b21-20020aa78715000000b006f3f062c4f4sm7391636pfo.136.2024.05.01.08.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 08:41:41 -0700 (PDT) Date: Wed, 1 May 2024 08:41:38 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v9 0/9] net/tap: fix RSS (BPF) support Message-ID: <20240501084138.30b94678@hermes.local> In-Reply-To: References: <20240130034925.44869-1-stephen@networkplumber.org> <20240426155125.125910-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 May 2024 12:18:16 +0100 Ferruh Yigit wrote: > Thanks for reviving tap eBPF support, I am for merging this set (as > early as possible). > > But I have two concerns, > 1. Build environment header file dependencies and external library > dependency version changed. Not sure if this will impact users. > What do you think at least to update release notes to notify users? Added a short note in release notes. > > 2. We need this to be tested, either by users or test teams. I will > bring the issue in next release status meeting to see if we have anyone > testing tap eBPF support. Agreed. I ended up doing lots of manual tests. That is how it was discovered that > 1 flow rule never worked with TAP. There is a bigger issue here. There is no basic test suite for PMD's. I see lots of differences creeping in with statistics etc. And there is no test suite for rte_flow. Lots of untested code paths and driver differences. Testing actual flows is hard, but basic functional tests should be possible. Like: - try all possible flow rules and actions - make sure that any supported flow rule accepts a valid parameter. and for those supported flow rules pass invalid data (like queue > nrx queue). - make sure validate and create work the same. - make sure that validate doesn't actually create state in hw/sw. should be possible to validate same rule 10,000 times without leaks blowing up.