From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7333143F76; Fri, 3 May 2024 16:21:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41A84402D4; Fri, 3 May 2024 16:21:24 +0200 (CEST) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mails.dpdk.org (Postfix) with ESMTP id ED6CA402D1 for ; Fri, 3 May 2024 16:21:22 +0200 (CEST) Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-78f05341128so612081685a.0 for ; Fri, 03 May 2024 07:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1714746082; x=1715350882; darn=dpdk.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=yrN1p66JnV8Bt/akXcJSPX7ym3dKZoPo13eZdCEa+4s=; b=ZeJMpjZnsgHLLl5KtWMftELhCOr4ub8YMEdXTebz55L4GtouuifGc7htv2vM4wA1p3 jDmDQPtP6eZiFiYPmhkPR65AxVBVsmruQZD91G0Ah32lefANZC0BsyesjOA9afZ0g/Ca sbODFbMPGWwVTb/Zon3u4lMOvwo5UtdFPw1HhTur+vglenTlEta8fYAmM6n+4b8+14TT QmZnRw7Em2J2KpidKhS15GflSWQP4/N80WCgRqwFlx1rb4W6uck5cvDizaCq1Cpi0+XY mweHb4i0y9ahg2zegivll2uElSdeJYx75ASkcNwbKE3LphwnZwpccvRZXy12z7icYGNE wyjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714746082; x=1715350882; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yrN1p66JnV8Bt/akXcJSPX7ym3dKZoPo13eZdCEa+4s=; b=UlDGg0QJYDEHdNNqE0E3VhQ/H75h8yqaVZVCdMlhXJkjdhONrh7vE4sXMN57qxJwMN 4nQJ2kzU4rRLbsUQ652n8sNfLGbcVaLKPo4w2KQK3rfZDY1jGmV0Lm6jtgzxtTX6bl1N clHdW0MT3LB2Mq9ECoLtSG7XS/r9b010LOdMyqKvkTtT9qpVNcbBEpfmIAurp3UTj9kB tuf/c0buwQq91+W7NgH5g9fYa6Wxn5vz65atZHJfTZJ+rEW5ibYdpsXHZnktiKX3uj3C C1NVLJMeeReOsaU8XhrNCkEAoMqAHm/jTyFX5ZoryapW+aq8CZZ/bD0CASCDqTWgjcai MuIw== X-Forwarded-Encrypted: i=1; AJvYcCUU2MDhALP7ZvCuiODupLu74sSg06K36ySg4YX5nMU8rg2zO9A9znrqXGoatO++/rVzhdWIpO7O4MylF40= X-Gm-Message-State: AOJu0YwPqY375CupLaMvZpfgmigJ8Eew00pPq5VLD3GuyGqlxHMnYLQ2 fXHmvhrOM1Sotcc4oFnLSH3ubM+n8t97xD1kRhwC2X5aACgR7OeKHB7kIgSzXZY= X-Google-Smtp-Source: AGHT+IHYToMb/5GaDk47b21ue0XtmdqrCwp5phoip1ffgb51eJzwouZzOyDTVcvV2l7B/QzKXqYQeg== X-Received: by 2002:a05:620a:808:b0:790:a8d3:eaee with SMTP id s8-20020a05620a080800b00790a8d3eaeemr2429184qks.40.1714746082100; Fri, 03 May 2024 07:21:22 -0700 (PDT) Received: from ste-uk-lab-gw ([79.173.157.19]) by smtp.gmail.com with ESMTPSA id ay10-20020a05620a178a00b0078d677e72f3sm1266807qkb.118.2024.05.03.07.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 07:21:21 -0700 (PDT) Date: Fri, 3 May 2024 15:21:18 +0100 From: Daniel Gregory To: David Marchand Cc: Ruifeng Wang , dev@dpdk.org, Punit Agrawal , Liang Ma Subject: Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant Message-ID: <20240503142118.GC3883350@ste-uk-lab-gw> Mail-Followup-To: David Marchand , Ruifeng Wang , dev@dpdk.org, Punit Agrawal , Liang Ma References: <20240502142116.63760-1-daniel.gregory@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 03:32:20PM +0200, David Marchand wrote: > - RTE_BUILD_BUG_ON() should not be used indeed. > IIRC, this issue was introduced with 875f350924b8 ("eal: add a new > helper for wait until scheme"). > Please add a corresponding Fixes: tag in next revision. Will do. Should I CC stable@dpdk.org too? > - This ARM specific implementation should take a rte_memory_order type > instead of a int type for the memorder input variable. > This was missed in 1ec6a845b5cb ("eal: use stdatomic API in public headers"). > > Could you send a fix for this small issue too? Yes, sure thing. Thanks, Daniel