From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C53BC43FB8; Sun, 5 May 2024 18:19:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70C7B4028C; Sun, 5 May 2024 18:19:00 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 244AA4025D for ; Sun, 5 May 2024 18:18:59 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f44ed6e82fso1143224b3a.3 for ; Sun, 05 May 2024 09:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714925938; x=1715530738; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LHdQBC07aFe5/nuwixStBh1SEsbo+2SK2T/jM6gtsS4=; b=k/EnxNsVgx/I4t+QLevM8z8lnyz74KLAs3PTTc7zurNg2Bu5LlLpjSMXf4ATh9zlfi 9sAGpOcHp47Fg2qaqOdYkLC6XicXM4xw571/01gwnIukd1s5oyQ0ZWdgAieo2I74CX3R 4NhrhXtMQhVesCoOaJbYCDNrAMibjdHu8rAdnmcLgD4/z8prbG4qK8ttoEiTllCWqUxZ qd157il6H71TfXmUxVM3nbksbmY1HTlDwE2S6sI4lzpTv+1Za8WDvHm8ylf5BDsd4dup zY7vDIqWK3GbOtB2aSErEhrv0whKsRuMi8fEhW/IHoYw4LvxbDiLoLnflLwpEHBqsWVu zz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714925938; x=1715530738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHdQBC07aFe5/nuwixStBh1SEsbo+2SK2T/jM6gtsS4=; b=F2U2F2B1CF6VRIBWMxnbzU54YqP9lDv1i1b6+RxxbIe46KZL6XCxqaCFf822x0x0u/ ums3jHybDQtoLptn8/dUcixMux0GBg9CsYSBK+AoMpZiptHH2COT62RTk44lyJBzYx4+ rxuNHQf/2qpXCVKrlpNcoBY2YudihgoIM4vw+6ZKDQUdsTQMmIgZxN+VhbEbo6UvWhun vDTEjouiERmkb2HS4w2dUnBFW1XRfgf93dit8wjriYWdRBJpcu+OeOY8OMeZiVeCSPJ8 44FtJjp2u9vKxmA6f3egy+W0ijbxEbRrbeQMNbXIoeQ/OcUZh1MwqVoUh2iiaV6azyGI mZvA== X-Gm-Message-State: AOJu0Yx5QL8GFK6iKz8oKYG2iYbdvuo8R4SZWPZhaU6+AqvNw3XZJpLe JiiaZ8OAJZscy8yZnwmNIU15zZJa43ri5Wxw0xeIgbU6C3ccZiCABdssVzjNv2A= X-Google-Smtp-Source: AGHT+IFyId7p8kSF/RuXhMX+aO0gX9lLtBmiHufdAHVcW1UohZ/w69ti32l5gNCAYlCx54CCzDynqQ== X-Received: by 2002:a05:6a00:1827:b0:6ed:435f:ec9b with SMTP id y39-20020a056a00182700b006ed435fec9bmr10668539pfa.20.1714925938101; Sun, 05 May 2024 09:18:58 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id p40-20020a056a0026e800b006f44d0df062sm4346460pfw.125.2024.05.05.09.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 09:18:57 -0700 (PDT) Date: Sun, 5 May 2024 09:18:55 -0700 From: Stephen Hemminger To: Abdullah =?UTF-8?B?w5ZtZXIgWWFtYcOn?= Cc: dev@dpdk.org Subject: Re: [PATCH v3] devtools: add .clang-format file Message-ID: <20240505091855.6364eaf6@hermes.local> In-Reply-To: <20240504191837.1096185-1-aomeryamac@gmail.com> References: <20240504191837.1096185-1-aomeryamac@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 4 May 2024 19:18:37 +0000 Abdullah =C3=96mer Yama=C3=A7 wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style across the DPDK codebase. >=20 > .clang-format file overrides the default style options provided by > clang-format and large set of IDEs and text editors support it. >=20 > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 > --- > .clang-format | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 138 insertions(+) > create mode 100644 .clang-format Tried this, but it needs some change to how braces at start of function are handled. For example, this is not how DPDK should look: static int -rte_pmd_tap_remove(struct rte_vdev_device *dev) -{ +rte_pmd_tap_remove(struct rte_vdev_device *dev) { struct rte_eth_dev *eth_dev =3D NULL; =20 /* find the ethdev entry */