From: Stephen Hemminger <stephen@networkplumber.org>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: dev@dpdk.org, stable@dpdk.og
Subject: Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic
Date: Fri, 10 May 2024 08:06:12 -0700 [thread overview]
Message-ID: <20240510080612.7b420011@hermes.local> (raw)
In-Reply-To: <20240510100358.18815-2-ciara.loftus@intel.com>
On Fri, 10 May 2024 10:03:57 +0000
Ciara Loftus <ciara.loftus@intel.com> wrote:
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index fee0d5d5f3..968bbf6d45 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -124,6 +124,7 @@ struct rx_stats {
> uint64_t rx_pkts;
> uint64_t rx_bytes;
> uint64_t rx_dropped;
> + uint64_t alloc_failed;
> };
You don't have to use local statistic for this, there already is one in the dev struct
i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find
what dev is.
And the code in ethdev for stats get will put it in the right place.
PS: what is the point of rxq->stats.rx_dropped? It is never incremented.
PPS: Looks like AF_XDP considers kernel full as an error (ie tx_dropped gets counted as error).
This is not what real hardware does.
next prev parent reply other threads:[~2024-05-10 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:03 [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Ciara Loftus
2024-05-10 10:03 ` [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic Ciara Loftus
2024-05-10 12:35 ` Maryam Tahhan
2024-05-10 15:06 ` Stephen Hemminger [this message]
2024-05-13 8:23 ` Maryam Tahhan
2024-05-13 15:53 ` Stephen Hemminger
2024-05-14 8:37 ` Loftus, Ciara
2024-05-10 10:03 ` [PATCH 3/3] net/af_xdp: Fix stats reset Ciara Loftus
2024-05-10 12:36 ` Maryam Tahhan
2024-05-10 12:20 ` [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Maryam Tahhan
2024-05-10 14:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510080612.7b420011@hermes.local \
--to=stephen@networkplumber.org \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.og \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).