From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97B164401B; Mon, 13 May 2024 17:55:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 754BD4067C; Mon, 13 May 2024 17:55:21 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 596CE402CD for ; Mon, 13 May 2024 17:55:20 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6f4472561f1so4182903b3a.0 for ; Mon, 13 May 2024 08:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715615719; x=1716220519; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YITmRs3S5w4f6uYsBaft9fNxBHuqeqsn0SmJRHSWTn4=; b=iG0W6eHSJJo1Uu6v6SR4dKR8JCFa0F+WPSfAoPr8WDZwV0+pEuqSxcUwnKNK1RN6V7 IZ7M3qKMGYh1TS35H2j4TPGneevV06dS9MMDRgWl2SlRFJmUTG0fA+6b6wWzegTCufbs DUQekMMhHqIHaXisGaMh+nhK1wYMNa71IYxu8rxYXtop3WwSB7GXX8azJS8b2SAUybxG +mP2RCmXrzCJhrQ1Gn2f2XM+wn45CEsELbXchxa0nEmD9PCmA8K6438PTZqxXJelHUiu lAiQeArjeClH/6x4CEW2VdOaGNNwepIu/iAYPcaBw2Knn6V/fwrYaMiBG25OWggSpdDG fRdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715615719; x=1716220519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YITmRs3S5w4f6uYsBaft9fNxBHuqeqsn0SmJRHSWTn4=; b=h4qC9r5E63wCqR1VVVGowFuaF4r3vTMemfvIAtiIaPadgSI95LHFPvuwBI5/owQg6v Ll+a9yGFZcg9Fx5ZV49sLGFm73NKna05R/jIUkG5SJPgA7VAC55fNFQzbwtrWHFUWn9G 7It5hRKSjACzlKGRkVCyytRh+5jJgQHuDGyHeHtrTYmrlPpAYZg+UeyqdW7D8+xV975c gOrjVGcTb82CJkmSVk68fQWysZzC/0ZvQ9SRleqHqUGCHh8n9Bp+8weZUhfaxZMmPbVG BwTCrSbaqzX/ekqBgpkaMagIk7w8jXMiRG5ZBOhsjhvUdq3nSCYoWiCNWhyZu9cnb/T/ yUbA== X-Forwarded-Encrypted: i=1; AJvYcCVXH5+ucHiSoqVtfbMg071tuImEjb3X5yewvbK3soM0ZbX99oEnnz1sf8L0tUyjTx8TxdPJxhyzaJal/B0= X-Gm-Message-State: AOJu0YyKkbU0ibMRpHcvlPYWVhpGGQEBsdOqNlP9eDwbxUi7hd2TkwN3 SPDF2dfa/aspP+yGkPZYK9S8w03kjVGXmJQdMdy5BhyUzOM61lMCO5wiuWTv2Fk= X-Google-Smtp-Source: AGHT+IFsYYlJfVGw59z2EHjFkxewY3mnHPSH2N9e6epHVsIcsKKpaxatPibcryt2L4TvYCFumun02w== X-Received: by 2002:a05:6a00:39a5:b0:6f0:c88e:a0dd with SMTP id d2e1a72fcca58-6f4e0384b45mr14200825b3a.28.1715615719461; Mon, 13 May 2024 08:55:19 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4fa8d253csm2859427b3a.165.2024.05.13.08.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 08:55:19 -0700 (PDT) Date: Mon, 13 May 2024 08:55:17 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Abdullah =?UTF-8?B?w5ZtZXIgWWFtYcOn?= , dev@dpdk.org Subject: Re: [PATCH v4] devtools: add .clang-format file Message-ID: <20240513085517.5e572880@hermes.local> In-Reply-To: References: <20240508211934.1143124-1-aomeryamac@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 May 2024 14:08:07 +0100 Ferruh Yigit wrote: > 2. Double tab indentation vs parenthesis align > if (iter->bus != NULL && > - /* not in middle of rte_eth_dev iteration, */ > - iter->class_device == NULL) { > + /* not in middle of rte_eth_dev iteration, */ > + iter->class_device == NULL) { > > DPDK coding guide suggests double tab, but also accepts alignment by > spaces. But as far as I can see most of code has double tab. > Majority of the diff caused because of this rule. I personally am more used the aligned style, and most tools support that. The DPDK one is unique (not done by most other projects). So can we just keep the kernel (what is this clang-format) version.