From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C6F44051; Fri, 17 May 2024 16:54:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54EE14029B; Fri, 17 May 2024 16:54:21 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id BC8C940268 for ; Fri, 17 May 2024 16:54:19 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1edc696df2bso13294225ad.0 for ; Fri, 17 May 2024 07:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715957659; x=1716562459; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AItM1YIcMttIHpPvd9kJMLJHzvK0RjvRcpcqhy60JDY=; b=Q7GTtbwA4rRyuULMue2jlL/JA7gwtHNbMl+tBm5/Rh+9fBupo6xEZpqsateYgBkH7i 8jKx3sq0QX+CZqP4RcXQEZl/0VBkEgVM99kQ6k3It/x+O+FQ2LEocKZQy1buJaEjOf/8 /Jee3CXgDmDTlIqLzJCSdLvrWwzmrs2EGQrBjTJnM/ten6FT6MSAIQfcmDVO7cqgndrl coqEHUtA4FuXMmxQJrQnLasFkH9asdP3/r6zP+yoOYUXEY8LpmZogwayvF5HSraR7pmP r78v8Zoe6uTO4KXL4mDVGT7e6dHm15KAntrFkypXp9I1Tst1of9HQ+Yi2QTvOU5U8gxj 54NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715957659; x=1716562459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AItM1YIcMttIHpPvd9kJMLJHzvK0RjvRcpcqhy60JDY=; b=a68lbfBK4Ezg2frHbA25DPUYezg5YQYt8mzKvjThZu7wMqB5v6PWPJAa21QNlW4xva TlhcS9Cx9En407/Z54LY27JLMsHPVCvmpQzjyq2fttmGKuKabzFwjKgvXmwtk06qGTK2 LVk3q6nPEIwPtc26D89QpN7CHT9MKXNA3aXRX3SF7SoFYyOH9O8HganNgKZTVXkD1yjm gVGf6BJEdJxI+Fjf8KJUAZYW1uWzQkpF8HOjNl4NQa68AkRtZY/f1NSVEezKt8bhJyH9 ndRvOTRHbl9o3Ombj8XsgMc6NHkxM5dXgfNOLk9NN9ea/m2cmSYzA0NBqSzwMVxvx1Pw YyMw== X-Gm-Message-State: AOJu0YwbDIKh4xE0AUBeXjgTwm5gB9uThv58c4BxA1riXetPHXmBXCP6 cu9jyXP9ZpaVWdwHNzXP76gQflcd+rG6BJNl20KcbHs8OCLJxqtL9NLfZhrtpnU= X-Google-Smtp-Source: AGHT+IFMX7KBDJ6mzu3Ln7efupkAzpYHlMjuUdl7NeCY3TE7jvV1S6Ny2L1S38kbjnWSjEKksCSLAg== X-Received: by 2002:a05:6a21:6daa:b0:1af:d35f:f282 with SMTP id adf61e73a8af0-1afde0d4ca7mr24937186637.14.1715957658603; Fri, 17 May 2024 07:54:18 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2ae0f10sm15456715b3a.128.2024.05.17.07.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 07:54:18 -0700 (PDT) Date: Fri, 17 May 2024 07:54:16 -0700 From: Stephen Hemminger To: "Loftus, Ciara" Cc: "dev@dpdk.org" Subject: Re: [PATCH v6 4/9] net/af_xdp: use generic SW stats Message-ID: <20240517075416.68b42c30@hermes.local> In-Reply-To: References: <20240510050507.14381-1-stephen@networkplumber.org> <20240517001302.65514-1-stephen@networkplumber.org> <20240517001302.65514-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 17 May 2024 13:34:30 +0000 "Loftus, Ciara" wrote: > > - tx_bytes += mbuf->pkt_len; > > + rte_eth_count_packet(&txq->stats, pkt_len); > > This change resolves the bugzilla you reported recently (1440 - use after free in af_xdp). Should this be mentioned in the commit message? We probably still need a separate patch for backporting that can be used without this entire series. I suspect it will take longer for this patch set to get integrated. So fixing the bug sooner would make sense.