From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD1B44407B; Mon, 20 May 2024 20:16:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AA2B402CD; Mon, 20 May 2024 20:16:25 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id B6A99400EF for ; Mon, 20 May 2024 20:16:23 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-656d8b346d2so1140297a12.2 for ; Mon, 20 May 2024 11:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716228983; x=1716833783; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jzH71hq4wWxAudT64eVuy8yyKGeaiOs4tG7U/MeeAco=; b=DgFDiUEKXRZbrH7N6ctBSD/dREHbV5Ujy/6fX9joYHSybRUwVQi6W7cuK6RIZp5d38 mcdaDIJpEQZnw4UBeXyaepe007xh16DnL4CiulM3ncwV04E3QbImD9bpvsy2/eEWr6Nh meUuJZanAvg7S650T/E2iXh8nfKjVcih+cKtGEbZR+L9czOZXG3veAhZqoiEdmAxg6yv sC4YucPPBc0i0GDoHc+lTF00oP09Axx1PqLn7huxifHkfkYqdNBlI2ccBveWI+HTt+ha s/hu1oz6MCpK9yjEhvZNgVu5mPmHLedjEbT5UiaH/ggIVmu/t8DQe0lJDxzG5VaGbiE3 IlXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716228983; x=1716833783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jzH71hq4wWxAudT64eVuy8yyKGeaiOs4tG7U/MeeAco=; b=J+99AouL74XmZJj2+VmVuS7nxvHuSDB/yXk4G+mJ56FiyDDEsAPex6s0iwypxU1qNK DbySUxKU3Ehl52EuvZawU0iT+OJ9jda9c0Znc5aNvJ9YA9FCyOgl0Q053eA9vjblzOSp cpLuH5jkKiHQEhhHjxYZ5760x11NNVnvKlxKdtjKMznH42sdMbaY7ugA/xZbdSQWdZVc A/RE0mgIGvLA4WcSRLcmt7veZXDa4AfTmWGGCpBRSsNK/Stfi7by6w8DSk1OW//Cuzn+ hob+vEc6x+qmiHpu5n3l/hFKDUfk93S8EvqNfwQ/WBr7xNfg+bSZ48cWxdlmZxAHAddt WHAA== X-Gm-Message-State: AOJu0Yxry0ivtMQ/mk7WCFZNjHyYGKNucQyUJFSj0Q3MitcskYJdf5z9 KnZI4XRIgGEA6Z9sQNddEjFtwEp5oax91xulAFd2L3JVLo0HkAOJBSYukxXFRkY= X-Google-Smtp-Source: AGHT+IGGwQxc5RIOpws+3f1+mO0Ix6FynNpqP+P7gFumWvh2MMZN2ArdmF9bxMH6d+RfA6mpnEPItQ== X-Received: by 2002:aa7:88d1:0:b0:6ea:c43c:a650 with SMTP id d2e1a72fcca58-6f4e03a164dmr34125265b3a.32.1716228982662; Mon, 20 May 2024 11:16:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f67b28d254sm8587748b3a.210.2024.05.20.11.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 11:16:22 -0700 (PDT) Date: Mon, 20 May 2024 11:16:20 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v12 02/12] net/tap: do not duplicate fd's Message-ID: <20240520111620.08c06959@hermes.local> In-Reply-To: <7c954e25-a3d0-407a-b315-2b1aa8493aab@amd.com> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-3-stephen@networkplumber.org> <7c954e25-a3d0-407a-b315-2b1aa8493aab@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 18:46:30 +0100 Ferruh Yigit wrote: > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > The TAP device can use same file descriptor for both rx and tx queues. > > This allows up to 8 queues (versus 4) to be used with secondary process. > > > > It would be nice to briefly update where this limit comes from, as > removing this limitation can be longer term solution for this issue. Sure, the limit comes from a too low value in RTE_MP_MAX_FD_NUM (8) It should have been set to the max Linux supports which is SCM_MAX_FD (253). But fixing it their breaks the ABI, and needs to wait for 24.11. Impacts AF_XDP as well. By not duplicating we can make TAP work with 8 queues and still get MP support. Good idea anyway not to waste fd's. > > > Bugzilla ID: 1381 > > Signed-off-by: Stephen Hemminger > > > > Can you please move the relevant release notes update to this patch? > So we can distribute the release notes update to patches instead of > dedicated update for it. > > Except from above change, > Acked-by: Ferruh Yigit >