From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F13864407B; Mon, 20 May 2024 20:18:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF1DE4064A; Mon, 20 May 2024 20:18:07 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id EE879400EF for <dev@dpdk.org>; Mon, 20 May 2024 20:18:06 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1eecc71311eso84722705ad.3 for <dev@dpdk.org>; Mon, 20 May 2024 11:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716229086; x=1716833886; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Rku8MfkNRYDCLCq8GaYTAGkDITFEDMvMrQchwW9D4pE=; b=YrCDNZrZHolQz/fYWeQ9LLM3l1zmJhT2wX7ZyY2rSMuq54vu1yCv0sz/an/kbJWfdK 7dhTwCuO1NAGVYvJdjzsuprvuwyIAwmI0MRyqLHI6KGxKvdZ5gPUl6c8wLI+W5l/RZ88 Eksma7v6TAzJd85qGU6snAoDqVRNWaNK7sFal47GQCBJ4lZfIaOAPZnDqiprpztjeNBj 6p537Iq/S3OvXy95tCM9S6pYPzMosQqTv19s8xiOK1ULy0HKxuBmxGAQoUwW9jOeF9qM kPKRoTg8sIqemEHB1L/MXDm9F3W9WVarYpzpapjBYdNTcREWpkONt8KgkeEBE62b5q/d 6RWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716229086; x=1716833886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rku8MfkNRYDCLCq8GaYTAGkDITFEDMvMrQchwW9D4pE=; b=Cva2WMZdznNc/btrPGXV74UxxKlLNTw7YHcnWnBQupc1M/hiTi3Eytfv0CQlHReuAi l28oSff738yiyGlHB8INz/vNg3eSlebts44qd8mEWn1ckayCSgrZ8eOumIr4xK7Yj9+h WyA0eaU+eUYoNT8efSz9HkNEU04pWHsYc7tWV+hahne3POPU/+GjVKGPh2aTzJqebRVz unZJZ/QcyJ4/prOrWTSUoZ6tSyLIxTt1RiLxE+25x+Gal8dei3vUsKLjstQCqvEm62uR S+yb2g3SaFoJkX/nUfP9AdYOzHRWAuS5m9IP2Bmf0aRWbWYTtMhYkQXlcq5zRaF/HtyM O41w== X-Forwarded-Encrypted: i=1; AJvYcCV0S0E5eoaeQl5OrpEhvChWVyReRPg5s+UnvR6Yz5C+8sgk0AIS+Gv9LiQfIFzkhl26hHrwI75owFDTykU= X-Gm-Message-State: AOJu0YwTuaSX3f8PfVTau18gYQardQSF+Jh9ZyBBlDYsenZ4+ggXvWV2 XkJZ1hJmUISyeDbeu71HN6KjnR5YxkuLr9exxcuhtZkOx2Jq3+a+HLCRdOw1EVM= X-Google-Smtp-Source: AGHT+IG+hv4BYgtCv7uml3Wx0gm7KyTdVNfq8//t0z/W5oMgjq36qzrXOWlojQkGv2SasXQYu8gknw== X-Received: by 2002:a17:902:e98b:b0:1e6:68d0:d6c9 with SMTP id d9443c01a7336-1ef43e27ab7mr382401265ad.40.1716229086143; Mon, 20 May 2024 11:18:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f3066594bdsm15193205ad.303.2024.05.20.11.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 11:18:05 -0700 (PDT) Date: Mon, 20 May 2024 11:18:04 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>, Patrick Robb <probb@iol.unh.edu>, dpdklab <dpdklab@iol.unh.edu>, Aaron Conole <aconole@redhat.com>, dev@dpdk.org Subject: Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program Message-ID: <20240520111804.0ee1fff2@hermes.local> In-Reply-To: <6bb00014-b2ee-4fc9-bdfd-7583e172d3e2@amd.com> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-8-stephen@networkplumber.org> <6bb00014-b2ee-4fc9-bdfd-7583e172d3e2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 18:49:19 +0100 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > There were multiple issues in the RSS queue support in the TAP > > driver. This required extensive rework of the BPF support. > > > > Change the BPF loading to use bpftool to > > create a skeleton header file, and load with libbpf. > > The BPF is always compiled from source so less chance that > > source and instructions diverge. Also resolves issue where > > libbpf and source get out of sync. The program > > is only loaded once, so if multiple rules are created > > only one BPF program is loaded in kernel. > > > > The new BPF program only needs a single action. > > No need for action and re-classification step. > > > > It also fixes the missing bits from the original. > > - supports setting RSS key per flow > > - level of hash can be L3 or L3/L4. > > > > Bugzilla ID: 1329 > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > > > The libbpf version in my Ubuntu box, installed with package manager, is > 'libbpf.so.0.5.0', so it doesn't satisfy the requirement and bpf support > is not compiled for me. > > > @Christian, 'libbpf.so.0.5.0'seems old, it is from 2021, do you know is > there a reason Ubuntu stick to this version? And can we expect an update > soon? > > > @Patric, I assume test environment also doesn't have 'libbpf', version: > '>= 1.0' which we need to test this feature. > Is it possible to update test environment to justify this dependency? > > I think we need to verify at least build (with and without dependency > met) for the set. The BPF API changed a lot, and it is not really possible to support both.