From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC1014407F; Tue, 21 May 2024 04:49:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 878DC4067E; Tue, 21 May 2024 04:49:30 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 1D10C4021E for ; Tue, 21 May 2024 04:49:28 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1ec4dc64c6cso88544415ad.0 for ; Mon, 20 May 2024 19:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716259767; x=1716864567; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=MdgUzZ3eOeTvYZi+4SVXrcNyYZAvnwrPwvZJ+NfpuDVqwX4ltFMmxCFFNob9oN+Xj2 LvPFKKGevQmHvx8ySFnYq6wi6uT2Mv94kHJLdK6TgWL9sSt9VZOzlOHzx1Px4bwIeLt3 IKMQY+YcJ6Ud1LRu6BSdEZttCHufmy/8++8S1MkZR8nZtGl/d8cn0KnelN6eVXKGo2jL nhfkxuNJCGNU1O3ASAhLVbVjyiPfYj5299bv6rTbGe8/w8CVr3W75l6GvLIBw21+vRlg T9BdAUKCwyHI/ZkITQ/KezVbvgTky47iaLXi3Y50H3IP6NHLX61VKwbtSvhRE4cCtqH1 b8TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716259767; x=1716864567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=rFb/Tn3DMXzTcGJDKady/wEVL2+pr8OlpWpwutaX7U/r/BfngepOzhrUBghvLkx23x T0tPzmP/RZ5RcxX9X3RfM7TIQ26mpbkybaVS6VEDGygbZoj44eYaB+YZLRtDH8cyBZmT eXYjl2H16CqDBLutw4FlgWaocWyFKU+UrDH6kQm1obqJJ+YmwDq2toHVE+WXdL9wxcUY yDPlKOShFRAimGoKsmnddLdCjS5ejN/nARdaSZog8Z043ThcmnPXT0jTeYOg/IoNtd62 2GU2jYlr5oXUFcgLWHl2LJ53J6x2RE9Gksngrg2urVoA7zSCwQudvD0IO50TLaIQgaRi 7Z5g== X-Gm-Message-State: AOJu0Yyci3R1ltOltk33zH51JMMpazdPsRQVvKygOAi4BPOqKcV+dJvq XvsQuThOl2WukC2rj1sRjdvzBi1BhUw7Xxr7XXMXqYwzR4dUYUASa75THJhAdBgJUnAOKxp1VGJ L X-Google-Smtp-Source: AGHT+IG85P98IVqr2coneZFoDvGotxUl9bqfRd7jw9Y9LrngJvf20xXJg7VBjvF52PIQW321JSPe1A== X-Received: by 2002:a17:902:eb88:b0:1f2:f948:b8b7 with SMTP id d9443c01a7336-1f2f948c2a6mr68405735ad.63.1716259767265; Mon, 20 May 2024 19:49:27 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d4828sm209742315ad.20.2024.05.20.19.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 19:49:26 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v13 01/11] net/tap: fix fd check in flow_isolate Date: Mon, 20 May 2024 19:47:20 -0700 Message-ID: <20240521024923.150983-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521024923.150983-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521024923.150983-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The check for receive queue fd in flow_isolate is incorrect. If queue has not been setup then fd will be -1 not 0. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/tap_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index fa50fe45d7..79cd6a12ca 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1595,7 +1595,7 @@ tap_flow_isolate(struct rte_eth_dev *dev, * If netdevice is there, setup appropriate flow rules immediately. * Otherwise it will be set when bringing up the netdevice (tun_alloc). */ - if (!process_private->rxq_fds[0]) + if (process_private->rxq_fds[0] == -1) return 0; if (set) { struct rte_flow *remote_flow; -- 2.43.0