From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D929C44088; Tue, 21 May 2024 17:44:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C47244067A; Tue, 21 May 2024 17:44:17 +0200 (CEST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id 09C3340648 for <dev@dpdk.org>; Tue, 21 May 2024 17:44:16 +0200 (CEST) Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-36c8f521122so17994675ab.0 for <dev@dpdk.org>; Tue, 21 May 2024 08:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716306255; x=1716911055; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HOztLn35Xqdk5owZEXZYq3tJ6ZxyYDww2NF2evRPhsk=; b=1M1nTKxvwID2JDY0xHYb3jsbp35Swa4XDO43MZC1bYCeBYBppp51GT5Xr51VWoKR48 JeFeJ4aeqAyJekaFO/dKuNbWzkrafNvz9542oRmLBHS1Qc4ul1DEXoZ6GBWGAlyZnKt2 fxYTmCaSCPyAc79wSLst0yPT5pW2CoW9BCacVURvdn/Yjyjr/ZipyeTh/S6QYkJH9Zw7 fgqFfNjbyWkmQ3VDaCFA9vmANC9wQcZRb8VGUOWpyvVt9gka75v6nKuoGHJ2vx+dqwoN 8oTXzuz39bbbVPkrp05qUV3XkOOiwYsm5VK81Q0BvrOs7hz1Zs9GgYo6pnUWQC1qx3ra sYvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716306255; x=1716911055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HOztLn35Xqdk5owZEXZYq3tJ6ZxyYDww2NF2evRPhsk=; b=ZkF1e4G8+gnN2BpcPDGbVm6AUZl8T2x74rpxnKttHvauj89i7cP9GNMcNEe67/H3as 4rERItfLIHTDjubPcKXPFN499O0qWRquxw/8qrSQ57eojNWN1YBJvOD8vtpTX/3TG2/b 9SGYI9fvMGEj6TkSjP9jHWjGYYpXIhDRLmZlgsQ85StnRXQCqzYXAokegxfF7YZsgWfI GOQb9J9DMpyli3eH1aJoXZlRfzxVyYV+jTlf7yC31f3uQ0k8Neo7AKoFeT/GzVUUiZkr aLjkhEf9GRCQT5Qozkudmw2Ehwo1fTtdubst4BxzNRK/828jCxmSbcOGsV+YGtqEnA/J 8VFg== X-Gm-Message-State: AOJu0Yxb4qbhHkf2MK2mwgJ+TYuG38yI9yCqPC9o/3hdBbKZiYJjPSYq UeM3ogKB3jyasGVEL946unOwUULXVs2KxfPgHr3HKuxf10m2IBCuHL4Gi5yRJzv70nY1eR7qxEi j X-Google-Smtp-Source: AGHT+IFI/A2eA8mXprx7wdGCRrm0jA366GAPyzVjnkCvArvY5GN6olOndmabHQlvBXkjB8P1EXMzJQ== X-Received: by 2002:a05:6e02:1d9c:b0:36d:bb9f:988a with SMTP id e9e14a558f8ab-36dbb9f9ac2mr189730015ab.4.1716306255207; Tue, 21 May 2024 08:44:15 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f66897e209sm13178181b3a.136.2024.05.21.08.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 08:44:15 -0700 (PDT) Date: Tue, 21 May 2024 08:44:13 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: dev@dpdk.org Subject: Re: [PATCH v12 09/12] net/tap: simplify internals Message-ID: <20240521084413.5a6cd347@hermes.local> In-Reply-To: <832e7060-1d2d-4a70-a32c-b4ce729fb357@amd.com> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-10-stephen@networkplumber.org> <832e7060-1d2d-4a70-a32c-b4ce729fb357@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 18:51:37 +0100 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > The names of Linux network devices are IFNAMSIZ(16) not the > > same as DPDK which has up to 64 characters. Don't need to > > hold onto the whole ifreq to save the remote interface flags. > > > > Make sure packet and byte counters are read once, so that global > > and per-queue values add up. No need for separate rx_nombuf counter > > since there is an alloc_failed value in ethdev. > > > > Keep only the statistics that are used. I.e no ipackets on > > tx queues etc. > > > > This patch does multiple things, although each not very complex, I think > splitting the patch makes it simpler to review. The patch got dropped in next rev. The statistics stuff should be addressed by other series about generic SW stats since many drivers have some bugs in this area.