From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2721E4408D; Tue, 21 May 2024 22:14:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B3DD40648; Tue, 21 May 2024 22:14:17 +0200 (CEST) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 88336400D7 for ; Tue, 21 May 2024 22:14:14 +0200 (CEST) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5f415fd71f8so656377a12.3 for ; Tue, 21 May 2024 13:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716322453; x=1716927253; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=jP3avv5dxc++fTjy41nua1GQb1ko5lfCtj0Qe2CKbg4AHn9joIzfW5hqOfNA+XnXmQ kTd7hk+5rxLZ5L/suFtqRKA5feFfPEmRB1PPRB8YHJDBjlsZWCLHAlzsFqowEb4LLp43 Nz4ILdYrZhq3r3HWLRX6luXeOPMT8aZ6WgiWQOr3UW9g0Mi7+ZvXspGjGHdxY1cICF7/ q5IspOWZ9IwpxR0Zm2Nf05BYU4BVBwNdtjzz1sPqyBLV3yEPIzEpo/mk87n29Pb56vLL uJfmCdxLBSCf6o+SPUf5BbqZliMLqshQfBMTa4IyAHtXl5lLlYu2knh1C/DOH8Jl1rds HNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716322453; x=1716927253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=t9MfE9fsQUeJNV4ZiBlcSIURAjr0l+Q9jnYepNyR+W4HK2ABvR7OcCLaGu0dcDHpDU nzbY3tPNyB6RKbLeJsvaJejh3s5tv3E32gLQnffuTX6eMM2TZmTDPouaFaaK0Wqy8ft8 GdM5rom1Td5/Rt9JHPqQyhWqqY8ZhVAldyf8ZR4/xMXCroKEChVfX2OmjKSoO/YGbsyq yXMgRMG5NbVZ/Kpr9Y9Sul6WTNlKBM8zwAJKs7jL4XuRKpEmW9wWhy7ZBpOyO+Vgs/1j 0n94yOD/OJ88H5PBapCukhtQIIj7TtHkz+7veJ4xHZ+7gZuIbgqceTkGfmLC/OPFRwgb VWIg== X-Gm-Message-State: AOJu0Yx6DmrblgnSUOzN3BbDvWx1FZwcEr7/rXYcG5VkanOq4cyj0KZP vefxtUIuCZnq7DAhlbgGLql2YtgH8X6kR7u1Q6EMorVl7+nZPVsVtcSlgbF1vCO3nsq8V2eOONl u X-Google-Smtp-Source: AGHT+IEOuBRi1dFgd4aCejwPgEr+XVY6Mho1RVi8UH7IcYqjGxY8My1xWQZ/Tz29C2aZWdZnoIorEA== X-Received: by 2002:a17:902:ef47:b0:1f2:f5f2:a4a0 with SMTP id d9443c01a7336-1f2f5f2a74fmr100607395ad.68.1716322453668; Tue, 21 May 2024 13:14:13 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f2fccc9d16sm45509895ad.31.2024.05.21.13.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 13:14:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v15 01/11] net/tap: fix fd check in flow_isolate Date: Tue, 21 May 2024 13:12:46 -0700 Message-ID: <20240521201410.126116-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521201410.126116-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521201410.126116-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The check for receive queue fd in flow_isolate is incorrect. If queue has not been setup then fd will be -1 not 0. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/tap_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index fa50fe45d7..79cd6a12ca 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1595,7 +1595,7 @@ tap_flow_isolate(struct rte_eth_dev *dev, * If netdevice is there, setup appropriate flow rules immediately. * Otherwise it will be set when bringing up the netdevice (tun_alloc). */ - if (!process_private->rxq_fds[0]) + if (process_private->rxq_fds[0] == -1) return 0; if (set) { struct rte_flow *remote_flow; -- 2.43.0