From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5212344099; Wed, 22 May 2024 18:15:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E523240684; Wed, 22 May 2024 18:15:32 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id DF05B4067C for ; Wed, 22 May 2024 18:15:30 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6f44a2d1e3dso1593743b3a.3 for ; Wed, 22 May 2024 09:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716394530; x=1716999330; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=4K+12Np5y9M+fphfySpYdo/QL7Li4GJThKq6qc/ALSs=; b=KnNvXSg5zOEbvj67s/2QZnR9S0dc9HaaV9pWu0mze7t81y7UQHvFUuWdIEGjimy/U1 9dSW6I0a7cKRLkyRvJmYl0pHiF2LInOW8UQDs4F+7akPUK+bFala9cMh+ltfzxv5ARol MO/mcgdmwsTQrMXVb4ly6XMGRaVjoiahvWj64npcD/L4ArITHNxgurSsrQ2LJhy9c6Ng W72VcPMkhZApQtRylcR3g7bgKZafFoGur0fvsPDAAZeuiGCPVBQr2iwGYDc645pQ5xz8 7KSLYYAXrn9jUSYILr8dbaRdp0Hw1i7Py8c8A4FGuzXmQ1i8aUs5YT0piVhayhkqjv2I LRGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716394530; x=1716999330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4K+12Np5y9M+fphfySpYdo/QL7Li4GJThKq6qc/ALSs=; b=hFSCXgU2lk0LikOsTixi7GHEebfCmme4rh2VdQnqrM/OGPw2HBY6Qf433087roOrrm HNxwK8LJJPx5fn+Bo2gIv5jIXeZuqtBBa4xxnBFfLa6TNWpnbo7XoikYdAt9lC3OHzy3 VoDABf9vwLeRGFT5IBLqKR+BHz4liq+tVtT61nHj7lsm6NYoxJNoRc8Sc076cZTuloME C9xLuNjJa/saS4U6+4bDZ9dQ/7x9H40qLlyqXXps0TnLi4Gnr4lVMx9AT+4Zv+1WwNwi gbiQctEFvtYfCbpAbJd+KGiUT+/+2wxDYygaOpSq3XEgSuYL1C7sZa69ZH5XyJSv4DOV hH+A== X-Gm-Message-State: AOJu0YxVJc5RhD3zdq7R9UYioNt94HvwkEPzdfas/4h19YfHoW7hhUX3 C/m1fT5E/zejRwAHKRAyhW5skOiDUdaW1gOjVeg96YgDoHG+r+zGrQaqPiPZGFDgpfQb8F8ZCYG 9GlA= X-Google-Smtp-Source: AGHT+IHsncLQpKQzlQSWwKOa1xRlOD5b19A+ym1es5Psyc4w1jyfAUBnEoEhQAddidNMS1MuUBoSPA== X-Received: by 2002:a05:6a21:99a6:b0:1af:6911:7ff4 with SMTP id adf61e73a8af0-1b1f87f7c57mr3178268637.7.1716394530123; Wed, 22 May 2024 09:15:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-63f149765efsm17721944a12.16.2024.05.22.09.15.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 09:15:29 -0700 (PDT) Date: Wed, 22 May 2024 09:15:28 -0700 From: Stephen Hemminger To: dev@dpdk.org Subject: Re: [PATCH v15 09/11] net/tap: simplify internals Message-ID: <20240522091528.54609a98@hermes.local> In-Reply-To: <20240521201410.126116-10-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521201410.126116-1-stephen@networkplumber.org> <20240521201410.126116-10-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 May 2024 13:12:54 -0700 Stephen Hemminger wrote: > The names of Linux network devices are IFNAMSIZ(16) not the > same as DPDK which has up to 64 characters. Don't need to > hold onto the whole ifreq to save the remote interface flags. > > Make sure packet and byte counters are read once, so that global > and per-queue values add up. No need for separate rx_nombuf counter > since there is an alloc_failed value in ethdev. > > Keep only the statistics that are used. I.e no ipackets on > tx queues etc. > > Signed-off-by: Stephen Hemminger Drop this patch when merging, will split and pick up in later updates