From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E63244107; Thu, 30 May 2024 01:40:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B0CC40ECF; Thu, 30 May 2024 01:39:22 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 51DC040289 for ; Thu, 30 May 2024 01:38:25 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2c19bba897bso217322a91.2 for ; Wed, 29 May 2024 16:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717025904; x=1717630704; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=trAkbZT49bJ6O/6HmxX+9AQ6qGq927l9uIzIHWmZqB0=; b=hTNTiVavXkraevGhbqnXwFqUGQQFS83+V6cB1BpcuOM1pP4hJBZtKhVNoWpnR6K7pw 9FWgKNhojmW2Xhi0kgDL+Q3qJwZ1SWWV+2OduJ46/fuf30Xcudxf3mJI85ZlAKc2to2X S69EB44gdvScnQdMzGicQr/W0cWP7RLUDmz2mn8uokEltUp/Fe+I9+DmrrKT/FKmjCvj Sj4eT/dOldml7kAoZ/m3S3736Y9X5mDxV6GjyiEWEdjRt2raCaPasy+0Gu8x21/RXqK/ ivedi6LAO1xrm89CbebukkElUYNCu9gEGQKhQotdyWJzt2e9zg35EaEyP5+bhT+mJ6hT t8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717025904; x=1717630704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=trAkbZT49bJ6O/6HmxX+9AQ6qGq927l9uIzIHWmZqB0=; b=XiLj2g+11F1r+KwodizvWnbxb5OT7q4F4qkqt3GmZOaM95A/3i0JTidsXMNRzgYdI9 PDXA4S5jDogmCeaBHmrvUFihkfYMqx295s3ZYTTTV9SYQevSnhOuG9feL924Jt1iQPnB Hjx+0uoFuD+I5V5u/duPfvJYnKLZHP6/jdCc55BP/gBEnST51x4MGesDlDM+/+ARKKD9 Qzknw2Ul+iUHJidWd+7tr+3OwsJDhLCUVyQTIyEAoJ+dr+rqUrx50AEn6MwnIMuluSiI 2hJaXkRJhHPjZD3GZI5vaPTe6Za//eme7X8EBG641vnvE5irUFtL3RnXCoW/jX0qzF4Y OFDw== X-Gm-Message-State: AOJu0YwSaTPlV3rDStHjEsCtYIYNcO0ezEOUuEcGKkGJKrFh4TVoIRhC ZzMFhZvOoer5A9Zp28IpzGAPLT1WSJeXXdE5vwz53608mnKcE7bMZQTtJVo7VuG2FlZq56GQW6B T X-Google-Smtp-Source: AGHT+IH12KtEHwnEboF7Lvy2bMclxGxLK6x4ffdNy5mzKef7XKk7pPhitLWejsBjUMv3rPGZRRaIUg== X-Received: by 2002:a17:90a:e650:b0:2ac:f010:b1c0 with SMTP id 98e67ed59e1d1-2c1abc38d8bmr628295a91.22.1717025904341; Wed, 29 May 2024 16:38:24 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c1a7761d78sm353955a91.12.2024.05.29.16.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 16:38:24 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 13/20] net/bnx2x: remove reference to sanity Date: Wed, 29 May 2024 16:33:47 -0700 Message-ID: <20240529233811.663211-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240529233811.663211-1-stephen@networkplumber.org> References: <20240529233811.663211-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 ++++---- drivers/net/bnx2x/ecore_sp.c | 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 597ee43359..92abd2d3f1 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -7820,7 +7820,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc) uint32_t ovlan2; uint8_t i, j; - /* various MF mode sanity checks... */ + /* various MF mode checks... */ if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) { PMD_DRV_LOG(NOTICE, sc, diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index d473c5e7ec..9dcb90bda8 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -181,7 +181,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc) */ return; } - /* sanity */ + /* input validation */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -231,7 +231,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc) uint32_t mac_addr; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input validation */ if (!sc->link_vars.link_up || !sc->port.pmf) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -457,7 +457,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc) struct dmae_command *dmae = &sc->stats_dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input validation */ if (!sc->func_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -1280,7 +1280,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc) struct dmae_command *dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input validation */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c index c6c3857778..158205266f 100644 --- a/drivers/net/bnx2x/ecore_sp.c +++ b/drivers/net/bnx2x/ecore_sp.c @@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc, break; } - /* Sanity check */ + /* Argument check */ if (!cur_len) return ECORE_SUCCESS; diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 2c81f85b96..6ebd47d927 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin, { uint32_t epio_mask, gp_oenable; *en = 0; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin); return; @@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e { uint32_t epio_mask, gp_output, gp_oenable; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin); return; -- 2.43.0