From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DB3544107; Thu, 30 May 2024 01:39:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C38140A81; Thu, 30 May 2024 01:39:03 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id BAE8E40289 for ; Thu, 30 May 2024 01:38:19 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2bdd8968dabso211137a91.3 for ; Wed, 29 May 2024 16:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717025899; x=1717630699; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tIfb8+eBP19eJHu+3Ju2F1eoR7OufKzHVgtYR+Mx0KA=; b=oNxfgj0z7fRxXvVhWx7LUjyL/ZFcCIKIATZ2Qo7mybaeP7tJgIdaul2CSuYo2br/Ng S26p1pWe+DsSIJoLk/uCYZOvbQv79JHltGhOgt2nUp9J/1E4+sLo+TsHNhGPNd/n3StU v/exRab5UCyWrVPsns9MPjxH5PG70U11c7qENJ8PcBuYBRaBArqqOVIR/BtHIXsiObGV BxfkoghbeKNYwQD5VKNJDppAmhHeVuxrew5mMISZDI46eGpS0+hjEf7flsarDT0U02YC W3xVvkzfQfmnVMdwXRWFj0/95fSGCLH7EIkNWy6+uJgEedDmWSFlCMGkcawtvzIOJ8ID i/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717025899; x=1717630699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tIfb8+eBP19eJHu+3Ju2F1eoR7OufKzHVgtYR+Mx0KA=; b=aYlTdtYXrpBM22Ft4wnCU3ZMbBEL1fbrG6csEXnwDg+P8jX8d3ceXi01lvdP6GXcEe MRm9Yi/dVEwI35OulCInfsExO1JuITC7uhDwl58CeHlswab+6baJ42p7BYbGlePJSv3I xiYb0EiQ01lcl/7vZtgnNbzxfSQ/D7cJ8IVzTWe1ZxZNSrEYGbwe55uAQAyJWs5skBKx mavleYav0CfqObI/UZNSFwKI9hUqbgP9Zgc4WlBTRU00BOIKC+LrNTLfOi1uCZ1MKFgw 46PqftPhxSyrd/LHMj+UhEHAokzaQH6BeFmu6el8poJE4YW2fOt6/Ezdf4scKx0bAL5O HyPw== X-Gm-Message-State: AOJu0Yy/hXQ+1nQfG16QQtOunIU0j//dIlRngLtlC/Hg/9FCHgInMsh9 gVnJOnqEhleDWNLB6DCxpGoY0Bs6rRtIrS+simGOj17JULMogNipgJqOCqdCtIpwGEMcFjmq86s 5 X-Google-Smtp-Source: AGHT+IGDzRNinLmktkXzaXtQWV8/UktnqtfdxKBHK47KwcUEdV9hkxZ2ehZnF3+x/AlAxe62yPCTCA== X-Received: by 2002:a17:90a:ac09:b0:2c1:a55e:b95d with SMTP id 98e67ed59e1d1-2c1aace3d70mr808581a91.0.1717025898788; Wed, 29 May 2024 16:38:18 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c1a7761d78sm353955a91.12.2024.05.29.16.38.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 16:38:18 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 05/20] lib: replace use of sanity check in comments and messages Date: Wed, 29 May 2024 16:33:39 -0700 Message-ID: <20240529233811.663211-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240529233811.663211-1-stephen@networkplumber.org> References: <20240529233811.663211-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c | 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib/pcapng/rte_pcapng.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/graph/graph.c b/lib/graph/graph.c index 26f0968a97..e51dcc3056 100644 --- a/lib/graph/graph.c +++ b/lib/graph/graph.c @@ -344,7 +344,7 @@ rte_graph_create(const char *name, struct rte_graph_param *prm) graph_spinlock_lock(); - /* Check arguments sanity */ + /* Check argument validity */ if (prm == NULL) SET_ERR_JMP(EINVAL, fail, "Param should not be NULL"); diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index 2fb808b21e..d0a636dde8 100644 --- a/lib/graph/graph_stats.c +++ b/lib/graph/graph_stats.c @@ -317,7 +317,7 @@ rte_graph_cluster_stats_create(const struct rte_graph_cluster_stats_param *prm) const char *pattern; rte_graph_t i; - /* Sanity checks */ + /* Validate arguments */ if (!rte_graph_has_stats_feature()) SET_ERR_JMP(EINVAL, fail, "Stats feature is not enabled"); diff --git a/lib/graph/node.c b/lib/graph/node.c index 99a9622779..c238d140ed 100644 --- a/lib/graph/node.c +++ b/lib/graph/node.c @@ -68,7 +68,7 @@ __rte_node_register(const struct rte_node_register *reg) graph_spinlock_lock(); - /* Check sanity */ + /* Check argument validity */ if (reg == NULL || reg->process == NULL) { rte_errno = EINVAL; goto fail; diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index af565a14ea..1c4b280c95 100644 --- a/lib/jobstats/rte_jobstats.c +++ b/lib/jobstats/rte_jobstats.c @@ -124,7 +124,7 @@ rte_jobstats_start(struct rte_jobstats_context *ctx, struct rte_jobstats *job) { uint64_t now; - /* Some sanity check. */ + /* Check validity of arguments. */ if (unlikely(ctx == NULL || job == NULL || job->context != NULL)) return -EINVAL; @@ -144,7 +144,7 @@ rte_jobstats_abort(struct rte_jobstats *job) struct rte_jobstats_context *ctx; uint64_t now, exec_time; - /* Some sanity check. */ + /* Check that arguments are valid */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; @@ -165,7 +165,7 @@ rte_jobstats_finish(struct rte_jobstats *job, int64_t job_value) uint64_t now, exec_time; int need_update; - /* Some sanity check. */ + /* Check arguments */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index 0ccdbabc04..f60d4f3f6e 100644 --- a/lib/metrics/rte_metrics.c +++ b/lib/metrics/rte_metrics.c @@ -120,7 +120,7 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) uint16_t idx_name; uint16_t idx_base; - /* Some sanity checks */ + /* Some consistency checks */ if (cnt_names < 1 || names == NULL) return -EINVAL; for (idx_name = 0; idx_name < cnt_names; idx_name++) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 7254defce7..ee065acda6 100644 --- a/lib/pcapng/rte_pcapng.c +++ b/lib/pcapng/rte_pcapng.c @@ -620,7 +620,7 @@ rte_pcapng_write_packets(rte_pcapng_t *self, struct pcapng_enhance_packet_block *epb; uint64_t cycles, timestamp; - /* sanity check that is really a pcapng mbuf */ + /* Check that is really a pcapng mbuf */ epb = rte_pktmbuf_mtod(m, struct pcapng_enhance_packet_block *); if (unlikely(epb->block_type != PCAPNG_ENHANCED_PACKET_BLOCK || epb->block_length != rte_pktmbuf_data_len(m))) { -- 2.43.0