From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D298944114; Thu, 30 May 2024 18:37:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77EB7427D8; Thu, 30 May 2024 18:37:10 +0200 (CEST) Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) by mails.dpdk.org (Postfix) with ESMTP id DF215410E8 for ; Thu, 30 May 2024 18:37:09 +0200 (CEST) Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-62027fcf9b1so9559347b3.0 for ; Thu, 30 May 2024 09:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717087029; x=1717691829; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xVp79mA6QOJkIcB5urNE76VJ1GL0q87VMvMZ6wtBHrM=; b=QDpexvx/6njoqC6UgHL/GHoa9kzEX8PA69fS6xVnnBPfOLKxQElDxoVimMYrL/xAr9 13/ZXZPHb/dJnEx8H/JDxfqV8NwGHgubuAFwZd6+ClNwdthWt8e1RRHCcTH8XQ8DLQVS hGnvVA2KxDdOTHCmZhNtE4QLkzFqqvjYpkAYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717087029; x=1717691829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xVp79mA6QOJkIcB5urNE76VJ1GL0q87VMvMZ6wtBHrM=; b=uRj3QUHxnigcDftTxFLh5wvbHr9UmCAXQhNNRhWJ9asYzaykrliP4qvDnoUyriDkcW Ms5y5LCyCJHfm458s8yzInF/jCEKKu5U5fJl/D8fz+W3FPO1CsW03dA3RVCqNId6hTZ0 EcEPix/1+nhkZH+UcZKk/ZWhWF32f0Xu2HRwSVGzVQKkq5Ock2riQBGhG/ZGXep51OKe 8kfqF0VIhg4e9lXJbHjx/gLBF7pFG8izROphpXhO3tG5TXi8KPtIJjM0jY5xBq1iUJom /qQtLI2OZKlSUIqEbc8sAZohcwPT1PAf0GW9qlDvc05VkhtzfLvZ5nTyc9ed6KhuOnxh v0tQ== X-Gm-Message-State: AOJu0Yx9W6Z87XbNV08NbzU3WPTVK89QpiNY4PWvuAjnLzUWA+DkxRsk vilOyclJ3/eZytjbfUQFTOb+4dxBYI//tQVCi9Zr/RQZahKsDwA7NQLSW5O/af8aIM05+luONDJ fbJ1qpHLeaHOmDqDW2PHEMIg9T1R/Bs+XxiRpEnbmxiM4nn1v X-Google-Smtp-Source: AGHT+IGRUpqT+0eQkwBQqik1W6uLh/EIeqQ+EhMVQiexb241ZiPBGvn+i7yQrO+Q0LheLLDQT4f6q1wvlMIj X-Received: by 2002:a0d:e486:0:b0:61a:e323:46e9 with SMTP id 00721157ae682-62c6cd3ca16mr15455047b3.25.1717087029210; Thu, 30 May 2024 09:37:09 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-62c76645d42sm9557b3.36.2024.05.30.09.37.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2024 09:37:09 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::1083]) by postal.iol.unh.edu (Postfix) with ESMTP id 4DF1D605C374; Thu, 30 May 2024 12:37:08 -0400 (EDT) From: jspewock@iol.unh.edu To: juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, thomas@monjalon.net Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v2 3/4] dts: add methods for modifying MTU to testpmd shell Date: Thu, 30 May 2024 12:33:38 -0400 Message-ID: <20240530163339.14566-4-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240530163339.14566-1-jspewock@iol.unh.edu> References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240530163339.14566-1-jspewock@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there needs to be a way to modify the value while bound to said driver as well. This is done by using testpmd to modify the MTU. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index ca30aac264..3f425154dd 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -227,6 +227,74 @@ def set_forward_mode(self, mode: TestPmdForwardingModes, verify: bool = True): f"Test pmd failed to set fwd mode to {mode.value}" ) + def _stop_port(self, port_id: int, verify: bool = True) -> None: + """Stop port `port_id` in testpmd. + + Depending on the PMD, the port may need to be stopped before configuration can take place. + This method wraps the command needed to properly stop ports and take their link down. + + Args: + port_id: ID of the port to take down. + verify: If :data:`True` the output will be scanned in an attempt to verify that the + stopping of ports was successful. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the port did not + successfully stop. + """ + stop_port_output = self.send_command(f"port stop {port_id}") + if verify and ("Done" not in stop_port_output): + self._logger.debug(f"Failed to stop port {port_id}. Output was:\n{stop_port_output}") + raise InteractiveCommandExecutionError(f"Test pmd failed to stop port {port_id}.") + + def _start_port(self, port_id: int, verify: bool = True) -> None: + """Start port `port_id` in testpmd. + + Because the port may need to be stopped to make some configuration changes, it naturally + follows that it will need to be started again once those changes have been made. + + Args: + port_id: ID of the port to start. + verify: If :data:`True` the output will be scanned in an attempt to verify that the + port came back up without error. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the port did not come + back up. + """ + start_port_output = self.send_command(f"port start {port_id}") + if verify and ("Done" not in start_port_output): + self._logger.debug(f"Failed to start port {port_id}. Output was:\n{start_port_output}") + raise InteractiveCommandExecutionError(f"Test pmd failed to start port {port_id}.") + + def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True) -> None: + """Change the MTU of a port using testpmd. + + Some PMDs require that the port be stopped before changing the MTU, and it does no harm to + stop the port before configuring in cases where it isn't required, so we first stop ports, + then update the MTU, then start the ports again afterwards. + + Args: + port_id: ID of the port to adjust the MTU on. + mtu: Desired value for the MTU to be set to. + verify: If `verify` is :data:`True` then the output will be scanned in an attempt to + verify that the mtu was properly set on the port. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the MTU was not + properly updated on the port matching `port_id`. + """ + self._stop_port(port_id, verify) + set_mtu_output = self.send_command(f"port config mtu {port_id} {mtu}") + self._start_port(port_id, verify) + if verify and (f"MTU: {mtu}" not in self.send_command(f"show port info {port_id}")): + self._logger.debug( + f"Failed to set mtu to {mtu} on port {port_id}." f" Output was:\n{set_mtu_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to update mtu of port {port_id} to {mtu}" + ) + def _close(self) -> None: """Overrides :meth:`~.interactive_shell.close`.""" self.send_command("quit", "Bye...") -- 2.45.1