From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B47E44115; Thu, 30 May 2024 20:38:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A396402E6; Thu, 30 May 2024 20:38:03 +0200 (CEST) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by mails.dpdk.org (Postfix) with ESMTP id DF5B840289 for ; Thu, 30 May 2024 20:38:01 +0200 (CEST) Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6ab8f838cc6so1651476d6.3 for ; Thu, 30 May 2024 11:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717094281; x=1717699081; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qw1FZ6HEhIgKD/PAGyKSM9MCvNJUCCWuqQQLoGiqNeo=; b=O1/5QJ8vTbdbRQZkPeQ0qV8rRM1E4URwi4g5x/L4imeFpB3l6mVcSmGN9oD/24Linr m1LkCbdsaBPlOpu0JuPOnjaEbIVAktrrLAtR7zhDrXehxqrFa5soHZiCSO8j7bLU5WoR 6qCKD4/wQwi9pM13AOTNUc+bvZKaVD92qa7io= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717094281; x=1717699081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qw1FZ6HEhIgKD/PAGyKSM9MCvNJUCCWuqQQLoGiqNeo=; b=vp8oP6VoR6IY8UnAneKWG+zSHZcRxjMAYw+HceSfO0knQm5UAkESo4Dl68wfBZkbKj Wz63H1h9lrnfCiHf/BXnQC62wZhN9X/piBNK2Mk0vXDnkhM8bfAgxGXAftaGiZaeyy44 0cRamifV9xly/YhdmaFu+xR4PIIrJODpvgeMKnl/z90wVfddZgP1eWoCU0uujaTOk4zc ohxkAHjwg6EVz2sUqr+bIaxqAqD4MrjAO+WkAoDIuja023YXJ2sb/FdmctpLDYEhiH3m OeEba//0i8Cx1RHvxfDPQEJl216MOZ73WQFk20F8OaXaeEHtobdL3Y23KxXsDSuEL5gj qhVQ== X-Gm-Message-State: AOJu0Yybhb1OHw3MoEjZ4DTfg29lUQgFQxw6QgFGAmfaxpqS9JFQJ0W4 M9r1WyjXTqLoJILIfe6vYl9QNkoZNDKaVfOHqxojEkstZzn3Z4mmE3WF6XOMGMA= X-Google-Smtp-Source: AGHT+IGcYI7+7Cg8AVSNlga7PuVDhwWLl9YqTSVcG82VLehVJvDAK2PgbugTemWgP4j1TCQ/Fbmtag== X-Received: by 2002:ac8:5d54:0:b0:43d:89f6:9104 with SMTP id d75a77b69052e-43fe92a66d4mr37315931cf.1.1717094281003; Thu, 30 May 2024 11:38:01 -0700 (PDT) Received: from localhost.unh.edu ([2606:4100:3880:1271:e2f8:4ec3:8bf3:864c]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43ff23a4ac1sm752731cf.8.2024.05.30.11.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 11:38:00 -0700 (PDT) From: Nicholas Pratte To: npratte@iol.unh.edu Cc: dev@dpdk.org Subject: [PATCH v8 0/2] Methodology change for hugepage configuration Date: Thu, 30 May 2024 14:37:47 -0400 Message-ID: <20240530183751.23213-1-npratte@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430184533.29247-4-npratte@iol.unh.edu> References: <20240430184533.29247-4-npratte@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem with this implementation is that, assuming the end-user has made prior modifications to the system, /proc/meminfo may default to hugepage sizes that are not recommended to be configured at runtime (i.e. 1GB hugepages). This can lead to two problems: overallocation of hugepages (which may crash the remote host) configuration of hugepages sizes that are not recommended during runtime. In this new implementation, we stipulate that any runtime hugepage configuration size that is not 2MB is considered an outlier. If the end-user would like to configure either 1GB hugepages or any unique hugepage size outside of 2MB, then they should make these configurations either at startup (in the case of 1GB hugepages) or runtime outside of DTS configuration (if a user would like hugepages that are not 2MB). In either case, the expectation is that, if wish to use hugepage sizes that are not 2MB, you will make these changes outside and prior to the initialization of DTS. The end-user has two options: remove the option for hugepage configuration in the conf.yaml, or keep the option and specify the amount of 2MB hugepages desired. In the case of the former, then we assume that hugepages are already configured prior to DTS initialization. In the latter case, the user must define the amount of 2MB hugepages to be configured at runtime. If the amount of 2MB hugepages requested exceeds the amount of 2MB hugepages already configured on the system, then the system will remount hugepages to cover the difference. If the amount of hugepages requested is either greater than or equal to the amount already configured on the system, then nothing is done. Nicholas Pratte (2): dts: Change hugepage runtime config to 2MB Exclusively dts: Change hugepage 'amount' to a different term doc/guides/tools/dts.rst | 14 +++++---- dts/conf.yaml | 8 +++--- dts/framework/config/__init__.py | 8 +++--- dts/framework/config/conf_yaml_schema.json | 12 ++++---- dts/framework/config/types.py | 4 +-- dts/framework/testbed_model/linux_session.py | 30 +++++++++++--------- dts/framework/testbed_model/node.py | 4 ++- dts/framework/testbed_model/os_session.py | 11 +++++-- 8 files changed, 52 insertions(+), 39 deletions(-) -- 2.44.0