From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EE7644115; Thu, 30 May 2024 21:38:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1E2F402E6; Thu, 30 May 2024 21:38:18 +0200 (CEST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by mails.dpdk.org (Postfix) with ESMTP id B3CDB40289 for ; Thu, 30 May 2024 21:38:16 +0200 (CEST) Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3d1b8bacf67so136378b6e.2 for ; Thu, 30 May 2024 12:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717097896; x=1717702696; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qw1FZ6HEhIgKD/PAGyKSM9MCvNJUCCWuqQQLoGiqNeo=; b=M5J9p4Ha7Cb2+41A8+ncXSw4rQBi/IK/bT0ixtzi/QUy0TWrLsSuTdgscaTT9B7R01 BsYxm7Za0vX8K7NXGD6XBkujU7kx4PWiu5uuB/Nwn4qpzX2UzrROCbYlpK0FhAH6R4x8 qmCBbnR9o6CsU/WSfBLs8KI0637p16S5xtqSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717097896; x=1717702696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qw1FZ6HEhIgKD/PAGyKSM9MCvNJUCCWuqQQLoGiqNeo=; b=nbd5iWSz26MvNdUGQQikP5PA9PuIlXMwWRGhoz+jbJ57Ze4H3eIN9GOy8Pakn1zvdG KZX0TPL59DlaJOK2RL8mkeWtjvX9rDfxMQZevLf6SmE5gkCmlgyPhTEaaTgGDlQD89u3 18uOddW4toYA5/c/wK2Yulq4lZh80hZ6k+phc+Mafixsp2NAWjef0CAyfaVlW6O/4BL5 lgOOvYIU81KytJH5e2GJHDlxjDUCSGqLX59Lhf40NL64ar3BdnnahMEltq1aUxtY7Fun Z9ySscoR62BUq32U6SKR7JRbuyQAxVPk1bW3JhjeElZFfIg/VWuAtcpAgrl2wuv4nTKR OBUQ== X-Gm-Message-State: AOJu0Yw/B6sMSk6zEYnlSqO/WE6E09bH4RhY72JpB8X04uFk88V+7vTu sArIYd8o9mJcMHLnWJIOA/Wyr7HraeQbObBvNcNEeeF3BT7e9TQVLSRUzw6QUOY= X-Google-Smtp-Source: AGHT+IG+qKhYxAiVMH4PDcqYLQRUvdD6dlrfatx8x/XzaRvJfuWanxTcyBv3LeBl9AyuEvdRV3slRw== X-Received: by 2002:a05:6808:1403:b0:3c9:96cd:5bbf with SMTP id 5614622812f47-3d1dcc97a1cmr3720553b6e.1.1717097895890; Thu, 30 May 2024 12:38:15 -0700 (PDT) Received: from localhost.unh.edu ([2606:4100:3880:1271:e2f8:4ec3:8bf3:864c]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ae4a73e425sm1185136d6.24.2024.05.30.12.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 12:38:15 -0700 (PDT) From: Nicholas Pratte To: luca.vizzarro@arm.com, juraj.linkes@pantheon.tech, jspewock@iol.unh.edu, paul.szczepanek@arm.com, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, yoan.picchi@foss.arm.com, probb@iol.unh.edu Cc: dev@dpdk.org, Nicholas Pratte Subject: [PATCH v8 0/2] Methodology change for hugepage configuration Date: Thu, 30 May 2024 15:37:58 -0400 Message-ID: <20240530193801.11867-1-npratte@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430184533.29247-4-npratte@iol.unh.edu> References: <20240430184533.29247-4-npratte@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem with this implementation is that, assuming the end-user has made prior modifications to the system, /proc/meminfo may default to hugepage sizes that are not recommended to be configured at runtime (i.e. 1GB hugepages). This can lead to two problems: overallocation of hugepages (which may crash the remote host) configuration of hugepages sizes that are not recommended during runtime. In this new implementation, we stipulate that any runtime hugepage configuration size that is not 2MB is considered an outlier. If the end-user would like to configure either 1GB hugepages or any unique hugepage size outside of 2MB, then they should make these configurations either at startup (in the case of 1GB hugepages) or runtime outside of DTS configuration (if a user would like hugepages that are not 2MB). In either case, the expectation is that, if wish to use hugepage sizes that are not 2MB, you will make these changes outside and prior to the initialization of DTS. The end-user has two options: remove the option for hugepage configuration in the conf.yaml, or keep the option and specify the amount of 2MB hugepages desired. In the case of the former, then we assume that hugepages are already configured prior to DTS initialization. In the latter case, the user must define the amount of 2MB hugepages to be configured at runtime. If the amount of 2MB hugepages requested exceeds the amount of 2MB hugepages already configured on the system, then the system will remount hugepages to cover the difference. If the amount of hugepages requested is either greater than or equal to the amount already configured on the system, then nothing is done. Nicholas Pratte (2): dts: Change hugepage runtime config to 2MB Exclusively dts: Change hugepage 'amount' to a different term doc/guides/tools/dts.rst | 14 +++++---- dts/conf.yaml | 8 +++--- dts/framework/config/__init__.py | 8 +++--- dts/framework/config/conf_yaml_schema.json | 12 ++++---- dts/framework/config/types.py | 4 +-- dts/framework/testbed_model/linux_session.py | 30 +++++++++++--------- dts/framework/testbed_model/node.py | 4 ++- dts/framework/testbed_model/os_session.py | 11 +++++-- 8 files changed, 52 insertions(+), 39 deletions(-) -- 2.44.0